[communication]-SMS-Replaced DefaultAzureCredential with get_credential() (Azure#38941)

* Replaced DefaultAzureCredential with get_credential() to get all available auth options

* Testing env variables for AzurePipelinesCredential

* Added logging

* Adjusted logging to warning

* Trying to see values of system variables

* Added system access token as env variable

* Removed system access token as it is defined already

* Removed logging lines

* Reverted changes in shared files.

* Reverted changes in shared tests utils.py.

---------

Co-authored-by: Dina Saparbaeva <[email protected]>

Author: dinazavyr

sdk/communication/azure-communication-sms/samples/sms_token_credential_auth_sample.py

@@ -31,12 +31,18 @@ class SmsTokenCredentialAuthSample(object):
 
     connection_string = os.getenv("COMMUNICATION_LIVETEST_STATIC_CONNECTION_STRING")
     phone_number = os.getenv("SMS_PHONE_NUMBER")
+    client_id = os.getenv("AZURE_CLIENT_ID")
+    client_secret = os.getenv("AZURE_CLIENT_SECRET")
+    tenant_id = os.getenv("AZURE_TENANT_ID")
 
     def sms_token_credential_auth(self):
         # To use Azure Active Directory Authentication (DefaultAzureCredential) make sure to have
         # AZURE_TENANT_ID, AZURE_CLIENT_ID and AZURE_CLIENT_SECRET as env variables.
-        endpoint, _ = parse_connection_str(self.connection_string)
-        sms_client = SmsClient(endpoint, DefaultAzureCredential())
+        if self.client_id is not None and self.client_secret is not None and self.tenant_id is not None:
+            endpoint, _ = parse_connection_str(self.connection_string)
+            sms_client = SmsClient(endpoint, DefaultAzureCredential())
+        else:
+            sms_client = SmsClient.from_connection_string(self.connection_string)
 
         # calling send() with sms values
         sms_responses = sms_client.send(from_=self.phone_number, to=self.phone_number, message="Hello World via SMS")

sdk/communication/azure-communication-sms/samples/sms_token_credential_auth_sample_async.py

@@ -32,36 +32,38 @@ class SmsTokenCredentialAuthSampleAsync(object):
 
     connection_string = os.getenv("COMMUNICATION_LIVETEST_STATIC_CONNECTION_STRING")
     phone_number = os.getenv("SMS_PHONE_NUMBER")
+    client_id = os.getenv("AZURE_CLIENT_ID")
+    client_secret = os.getenv("AZURE_CLIENT_SECRET")
+    tenant_id = os.getenv("AZURE_TENANT_ID")
 
     async def sms_token_credential_auth_async(self):
         # To use Azure Active Directory Authentication (DefaultAzureCredential) make sure to have
         # AZURE_TENANT_ID, AZURE_CLIENT_ID and AZURE_CLIENT_SECRET as env variables.
-        endpoint, _ = parse_connection_str(self.connection_string)
-        sms_client = SmsClient(endpoint, DefaultAzureCredential())
+        if self.client_id is not None and self.client_secret is not None and self.tenant_id is not None:
+            endpoint, _ = parse_connection_str(self.connection_string)
+            sms_client = SmsClient(endpoint, DefaultAzureCredential())
+        else:
+            sms_client = SmsClient.from_connection_string(self.connection_string)
 
         async with sms_client:
-            try:
-                # calling send() with sms values
-                sms_responses = await sms_client.send(
-                    from_=self.phone_number, to=self.phone_number, message="Hello World via SMS"
-                )
-                sms_response = sms_responses[0]
+            # calling send() with sms values
+            sms_responses = await sms_client.send(
+                from_=self.phone_number, to=self.phone_number, message="Hello World via SMS"
+            )
+            sms_response = sms_responses[0]
 
-                if sms_response.successful:
-                    print(
-                        "Message with message id {} was successful sent to {}".format(
-                            sms_response.message_id, sms_response.to
-                        )
+            if sms_response.successful:
+                print(
+                    "Message with message id {} was successful sent to {}".format(
+                        sms_response.message_id, sms_response.to
                     )
-                else:
-                    print(
-                        "Message failed to send to {} with the status code {} and error: {}".format(
-                            sms_response.to, sms_response.http_status_code, sms_response.error_message
-                        )
+                )
+            else:
+                print(
+                    "Message failed to send to {} with the status code {} and error: {}".format(
+                        sms_response.to, sms_response.http_status_code, sms_response.error_message
                     )
-            except Exception:
-                print(Exception)
-                pass
+                )
 
 
 if __name__ == "__main__":

sdk/communication/azure-communication-sms/tests/test_sms_client_e2e.py

@@ -3,12 +3,15 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
+import os
+import logging
+import sys
+
 import pytest
-from devtools_testutils import AzureRecordedTestCase, is_live, recorded_by_proxy, set_bodiless_matcher
-from _shared.utils import get_http_logging_policy
 from devtools_testutils.fake_credentials import FakeTokenCredential
+from devtools_testutils import get_credential, is_live, recorded_by_proxy, set_bodiless_matcher
+from _shared.utils import get_http_logging_policy
 from azure.core.exceptions import HttpResponseError
-from azure.identity import DefaultAzureCredential
 from acs_sms_test_case import ACSSMSTestCase
 from azure.communication.sms import SmsClient
 
@@ -52,7 +55,7 @@ def test_send_sms_from_managed_identity(self):
         if not is_live():
             credential = FakeTokenCredential()
         else:
-            credential = DefaultAzureCredential()
+            credential = get_credential()
         sms_client = SmsClient(self.endpoint, credential, http_logging_policy=get_http_logging_policy())
 
         # calling send() with sms values

sdk/communication/azure-communication-sms/tests/test_sms_client_e2e_async.py

@@ -3,15 +3,18 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
+import os
+import logging
+import sys
+
 import pytest
 from devtools_testutils.aio import recorded_by_proxy_async
-from devtools_testutils import is_live
+from devtools_testutils.fake_credentials_async import AsyncFakeCredential
+from devtools_testutils import get_credential, is_live
 from azure.communication.sms.aio import SmsClient
 from azure.core.exceptions import HttpResponseError
-from _shared.utils import get_http_logging_policy
+from _shared.utils import async_create_token_credential, get_http_logging_policy
 from acs_sms_test_case import ACSSMSTestCase
-from azure.identity.aio import DefaultAzureCredential
-from devtools_testutils.fake_credentials_async import AsyncFakeCredential
 
 
 @pytest.mark.asyncio
@@ -57,7 +60,7 @@ async def test_send_sms_from_managed_identity_async(self):
         if not is_live():
             credential = AsyncFakeCredential()
         else:
-            credential = DefaultAzureCredential()
+            credential = get_credential(is_async=True)
         sms_client = SmsClient(self.endpoint, credential, http_logging_policy=get_http_logging_policy())
 
         async with sms_client: