Revert "update the package namespaces for all packages in the artifact directory (Azure#37198)" (Azure#37221)

This reverts commit 00f7455.

Author: scbedd

eng/pipelines/templates/steps/build-extended-artifacts.yml

@@ -84,6 +84,7 @@ steps:
       filePath: $(Build.SourcesDirectory)/eng/scripts/Save-Package-Namespaces-Property.ps1
       arguments: >
         -ArtifactStagingDirectory "$(Build.ArtifactStagingDirectory)"
+        -ArtifactsList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json)
       pwsh: true
       workingDirectory: $(Pipeline.Workspace)
     displayName: Update package properties with namespaces

eng/scripts/Save-Package-Namespaces-Property.ps1

@@ -14,37 +14,48 @@ The root directory of the staged artifacts. The PackageInfo files will be in the
 PackageInfo subdirectory. The whl files are going to be in the subdirectory which
 is the same as the artifact's name but artifact name in the file's name will have
  underscores instead of dashes.
+
+.PARAMETER ArtifactsList
+The list of artifacts to gather namespaces for, this is only done for libraries that are
+producing docs.
+-ArtifactsList ('${{ convertToJson(parameters.Artifacts) }}' | ConvertFrom-Json)
 #>
 [CmdletBinding()]
 Param (
     [Parameter(Mandatory = $True)]
-    [string] $ArtifactStagingDirectory
+    [string] $ArtifactStagingDirectory,
+    [Parameter(Mandatory=$true)]
+    [array] $ArtifactsList
 )
 
 $ArtifactsList = $ArtifactsList | Where-Object -Not "skipPublishDocMs"
 
 . (Join-Path $PSScriptRoot ".." common scripts common.ps1)
 
+if (-not $ArtifactsList) {
+    Write-Host "ArtifactsList is empty, nothing to process. This can happen if skipPublishDocMs is set to true for all libraries being built."
+    exit 0
+}
+
 Write-Host "ArtifactStagingDirectory=$ArtifactStagingDirectory"
 if (-not (Test-Path -Path $ArtifactStagingDirectory)) {
     LogError "ArtifactStagingDirectory '$ArtifactStagingDirectory' does not exist."
     exit 1
 }
 
-$packageInfoDirectory = Join-Path $ArtifactStagingDirectory "PackageInfo"
-$foundError = $false
-$artifacts = Get-ChildItem -Path $packageInfoDirectory -File -Filter "*.json"
-$artifacts | Format-Table -Property Name | Out-String | Write-Host
+Write-Host ""
+Write-Host "ArtifactsList:"
+$ArtifactsList | Format-Table -Property Name | Out-String | Write-Host
 
-if (-not $artifacts) {
-    Write-Host "Zero artifacts were discovered, nothing to process. This can happen if skipPublishDocMs is set to true for all libraries being built."
-    exit 0
-}
+$packageInfoDirectory = Join-Path $ArtifactStagingDirectory "PackageInfo"
 
-# by this point, the PackageInfo folder will have a json file for each artifact
-# we simply need to read each file, get the appropriate metadata, and add the namespaces if necessary
-foreach($packageInfoFile in $artifacts) {
+$foundError = $false
+# At this point the packageInfo files should have been already been created.
+# The only thing being done here is adding or updating namespaces for libraries
+# that will be producing docs.
+foreach($artifact in $ArtifactsList) {
     # Get the version from the packageInfo file
+    $packageInfoFile = Join-Path $packageInfoDirectory "$($artifact.Name).json"
     Write-Host "processing $($packageInfoFile.FullName)"
     $packageInfo = ConvertFrom-Json (Get-Content $packageInfoFile -Raw)
     $version = $packageInfo.Version
@@ -58,7 +69,8 @@ foreach($packageInfoFile in $artifacts) {
     $WhlFile = Get-ChildItem -Path $WhlDir -File -Filter "$whlName-$version*.whl"
 
     if (!(Test-Path $WhlFile -PathType Leaf)) {
-        Write-Host "Whl file for, $($packageInfo.Name), was not found in $WhlDir. Unable to update package namespaces."
+        LogError "Whl file for, $($packageInfo.Name), was not found in $WhlDir. Please ensure that a .whl file is being produced for the library."
+        $foundError = $true
         continue
     }
     $namespaces = Get-NamespacesFromWhlFile $packageInfo.Name $version -PythonWhlFile $WhlFile