Skip to content

Commit ed8e8ab

Browse files
authored
[engsys] ci: Fix tox_harness.py dropping package extras when rewriting dev_requirements.txt (Azure#32864)
* ci: Don't drop extras when rewriting dev_requirements.txt * fix: Preserve log that shows original and modified dev-requirements
1 parent 7264ccd commit ed8e8ab

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

scripts/devops_tasks/tox_harness.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -116,20 +116,23 @@ def replace_dev_reqs(file, pkg_root):
116116
adjusted_req_lines = []
117117

118118
with open(file, "r") as f:
119-
for line in f:
120-
args = [part.strip() for part in line.split() if part and not part.strip() == "-e"]
121-
amended_line = " ".join(args)
119+
original_req_lines = list(line.strip() for line in f)
122120

123-
if amended_line.endswith("]"):
124-
trim_amount = amended_line[::-1].index("[") + 1
125-
amended_line = amended_line[0 : (len(amended_line) - trim_amount)]
121+
for line in original_req_lines:
122+
args = [part.strip() for part in line.split() if part and not part.strip() == "-e"]
123+
amended_line = " ".join(args)
124+
extras = ""
126125

127-
adjusted_req_lines.append(amended_line)
126+
if amended_line.endswith("]"):
127+
amended_line, extras = amended_line.rsplit("[", maxsplit=1)
128+
if extras:
129+
extras = f"[{extras}"
130+
131+
adjusted_req_lines.append(f"{build_whl_for_req(amended_line, pkg_root)}{extras}")
128132

129133
req_file_name = os.path.basename(file)
130-
logging.info("Old {0}:{1}".format(req_file_name, adjusted_req_lines))
134+
logging.info("Old {0}:{1}".format(req_file_name, original_req_lines))
131135

132-
adjusted_req_lines = list(map(lambda x: build_whl_for_req(x, pkg_root), adjusted_req_lines))
133136
logging.info("New {0}:{1}".format(req_file_name, adjusted_req_lines))
134137

135138
with open(file, "w") as f:

0 commit comments

Comments
 (0)