remove mgmt from typing exclusion filter (Azure#38963)

* remove mgmt from mypy global exclusion

* touch mgmt code to trigger pipeline

* Revert "touch mgmt code to trigger pipeline"

This reverts commit c95a4a8.

* update mypy and pyright to run on generated_samples dir

* redefine filter for health status script

* test mgmt

* Revert "test mgmt"

This reverts commit e140847.

* mccoy feedback

Author: kristapratico

eng/tox/run_mypy.py

@@ -80,7 +80,9 @@
         )
     else:
         # check if samples dir exists, if not, skip sample code check
-        if not os.path.exists(os.path.join(args.target_package, "samples")):
+        samples = os.path.exists(os.path.join(args.target_package, "samples"))
+        generated_samples = os.path.exists(os.path.join(args.target_package, "generated_samples"))
+        if not samples and not generated_samples:
             logging.info(
                 f"Package {package_name} does not have a samples directory."
             )
@@ -89,7 +91,7 @@
                 *commands,
                 "--check-untyped-defs",
                 "--follow-imports=silent",
-                os.path.join(args.target_package, "samples")
+                os.path.join(args.target_package, "samples" if samples else "generated_samples"),
             ]
             try:
                 logging.info(

eng/tox/run_pyright.py

@@ -91,15 +91,22 @@ def get_pyright_config_path(args):
     top_level_module = pkg_details.namespace.split(".")[0]
     paths = [
         os.path.join(args.target_package, top_level_module),
-        os.path.join(args.target_package, "samples"),
     ]
-
-    if not args.next and in_ci():
-        if not is_check_enabled(args.target_package, "type_check_samples"):
+    if not args.next and in_ci() and not is_check_enabled(args.target_package, "type_check_samples"):
+        logging.info(
+            f"Package {package_name} opts-out of pyright check on samples."
+        )
+    else:
+        # check if samples dir exists, if not, skip sample code check
+        samples = os.path.exists(os.path.join(args.target_package, "samples"))
+        generated_samples = os.path.exists(os.path.join(args.target_package, "generated_samples"))
+        if not samples and not generated_samples:
             logging.info(
-                f"Package {package_name} opts-out of pyright check on samples."
+                f"Package {package_name} does not have a samples directory."
             )
-            paths = paths[:-1]
+        else:
+            paths.append(os.path.join(args.target_package, "samples" if samples else "generated_samples"))
+
 
     pyright_config_path = get_pyright_config_path(args)
 

scripts/repo_health_status_report/output_health_report.py

@@ -27,7 +27,8 @@
     IGNORE_PACKAGES,
     FILTER_EXCLUSIONS,
 )
-
+IGNORE_FILTER.append("mgmt")
+FILTER_EXCLUSIONS.append("azure-mgmt-core")
 IGNORE_PACKAGES.append("azure-openai")
 
 # Github

tools/azure-sdk-tools/ci_tools/environment_exclusions.py

@@ -15,8 +15,8 @@
 # For CI exclusion of type checks, look into adding a pyproject.toml, as indicated in the `The pyproject.toml` section
 # of `.doc/eng_sys_checks.md`.
 
-IGNORE_FILTER = ["nspkg", "mgmt", "cognitiveservices"]
-FILTER_EXCLUSIONS = ["azure-mgmt-core"]
+IGNORE_FILTER = ["nspkg", "cognitiveservices"]
+FILTER_EXCLUSIONS = []
 IGNORE_PACKAGES = [
     "azure-applicationinsights",
     "azure-servicemanagement-legacy",