[EH/SB/EG] next* (Azure#40483)

* next*

* shouldnt return

* pylint

* this

* this

* tis

Author: l0lawrence

eng/pylintrc

@@ -1,5 +1,5 @@
 [MASTER]
-py-version=3.9
+py-version=3.8
 ignore-patterns=test_*,conftest,setup
 reports=no
 

sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_helpers.py

@@ -88,17 +88,15 @@ def _get_authentication_policy(credential, bearer_token_policy=BearerTokenCreden
     )
 
 
-def _is_cloud_event(event):
-    # type: (Any) -> bool
+def _is_cloud_event(event: Any) -> bool:
     required = ("id", "source", "specversion", "type")
     try:
         return all((_ in event for _ in required)) and event["specversion"] == "1.0"
     except TypeError:
         return False
 
 
-def _is_eventgrid_event_format(event):
-    # type: (Any) -> bool
+def _is_eventgrid_event_format(event: Any) -> bool:
     required = ("subject", "eventType", "data", "dataVersion", "id", "eventTime")
     try:
         return all((prop in event for prop in required))

sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_policies.py

@@ -27,8 +27,7 @@ class CloudEventDistributedTracingPolicy(SansIOHTTPPolicy):
 
     _CONTENT_TYPE = "application/cloudevents-batch+json; charset=utf-8"
 
-    def on_request(self, request):
-        # type: (PipelineRequest) -> None
+    def on_request(self, request: "PipelineRequest") -> None:
         try:
             traceparent = request.http_request.headers["traceparent"]
             tracestate = request.http_request.headers["tracestate"]

sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_publisher_client.py

@@ -116,8 +116,10 @@ def __init__(
         self._api_version = api_version if api_version is not None else DEFAULT_API_VERSION
 
     @staticmethod
-    def _policies(credential, **kwargs):
-        # type: (Union[AzureKeyCredential, AzureSasCredential, TokenCredential], Any) -> List[Any]
+    def _policies(
+        credential: Union["AzureKeyCredential", "AzureSasCredential", "TokenCredential"],
+        **kwargs: Any
+    ) -> List[Any]:
         auth_policy = _get_authentication_policy(credential)
         sdk_moniker = "eventgrid/{}".format(VERSION)
         policies = [
@@ -234,16 +236,13 @@ def send(self, events: SendType, *, channel_name: Optional[str] = None, **kwargs
             map_error(status_code=response.status_code, response=response, error_map=error_map)
             raise HttpResponseError(response=response)
 
-    def close(self):
-        # type: () -> None
-        """Close the :class:`~azure.eventgrid.EventGridPublisherClient` session."""
-        return self._client.close()
+    def close(self) -> None:
+        """Closes the EventGridPublisherClient session."""
+        self._client.close()
 
-    def __enter__(self):
-        # type: () -> EventGridPublisherClient
+    def __enter__(self) -> "EventGridPublisherClient":
         self._client.__enter__()
         return self
 
-    def __exit__(self, *args):
-        # type: (*Any) -> None
+    def __exit__(self, *args) -> None:
         self._client.__exit__(*args)

sdk/eventgrid/azure-eventgrid/azure/eventgrid/_legacy/_signature_credential_policy.py

@@ -20,8 +20,7 @@ class EventGridSasCredentialPolicy(SansIOHTTPPolicy):
     :raises: ValueError or TypeError
     """
 
-    def __init__(self, credential, name, **kwargs):  # pylint: disable=unused-argument
-        # type: (AzureSasCredential, str, Any) -> None
+    def __init__(self, credential: "AzureSasCredential", name: str, **kwargs: Any) -> None:  # pylint: disable=unused-argument
         super(EventGridSasCredentialPolicy, self).__init__()
         self._credential = credential
         if not name:

sdk/eventgrid/azure-eventgrid/azure/eventgrid/_model_base.py

@@ -633,7 +633,7 @@ def _deserialize(cls, data, exist_discriminators):
                 discriminator_value = data.find(xml_name).text  # pyright: ignore
         else:
             discriminator_value = data.get(discriminator._rest_name)
-        mapped_cls = cls.__mapping__.get(discriminator_value, cls)  # pyright: ignore
+        mapped_cls = cls.__mapping__.get(discriminator_value, cls)  # pyright: ignore # pylint: disable=no-member
         return mapped_cls._deserialize(data, exist_discriminators)
 
     def as_dict(self, *, exclude_readonly: bool = False) -> typing.Dict[str, typing.Any]:

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_client_async.py

@@ -4,7 +4,7 @@
 # license information.
 # --------------------------------------------------------------------------
 # TODO: Check types of kwargs (issue exists for this)
-import asyncio
+import asyncio # pylint:disable=do-not-import-asyncio
 import logging
 import time
 import queue

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_connection_async.py

@@ -10,7 +10,7 @@
 from urllib.parse import urlparse
 import socket
 from ssl import SSLError
-import asyncio
+import asyncio # pylint:disable=do-not-import-asyncio
 from typing import Any, Dict, List, Tuple, Optional, NamedTuple, Type, Union, cast
 
 from ._transport_async import AsyncTransport

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_sender_async.py

@@ -7,7 +7,7 @@
 import uuid
 import logging
 import time
-import asyncio
+import asyncio # pylint:disable=do-not-import-asyncio
 
 from .._encode import encode_payload
 from ._link_async import Link

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_session_async.py

@@ -8,7 +8,7 @@
 import uuid
 import logging
 import time
-import asyncio
+import asyncio # pylint:disable=do-not-import-asyncio
 from typing import Optional, Union
 
 from ..constants import ConnectionState, SessionState, SessionTransferState, Role
@@ -105,8 +105,7 @@ async def _on_connection_state_change(self):
             if self.state not in [SessionState.DISCARDING, SessionState.UNMAPPED]:
                 await self._set_state(SessionState.DISCARDING)
 
-    def _get_next_output_handle(self):
-        # type: () -> int
+    def _get_next_output_handle(self) -> int:
         """Get the next available outgoing handle number within the max handle limit.
 
         :raises ValueError: If maximum handle has been reached.