[lint] update pylint 2.9 (Azure#23850)

* update

* disabling the final few pylint checkers from 2.9 that are causing issues

* removing core run

* updating to the latest version of pylint possible that still supports python 3.6.0

* updating python version that goes with 2.9.3

* verify all additional added checkers have been disabled

* fixed naming issues

* had to remove 2 disabled checkers that were new due to issues with cspell

* removing core run

* add simplifiable and evals

* adding simplifiable and evals as words

Author: l0lawrence

.vscode/cspell.json

@@ -155,6 +155,7 @@
     "encryptor",
     "engsys",
     "envname",
+    "evals",
     "fileno",
     "fqdns",
     "fstat",
@@ -262,6 +263,7 @@
     "setfacl",
     "signalr",
     "signup",
+    "simplifiable",
     "skipif",
     "skus",
     "southcentralus",

eng/test_tools.txt

@@ -34,7 +34,7 @@ wrapt==1.12.1
 
 # Locking pylint and required packages
 pylint==1.8.4; python_version < '3.4'
-pylint==2.5.2; python_version >= '3.4'
+pylint==2.9.3; python_version >= '3.6'
 
 # python-dotenv
 python-dotenv==0.15.0

pylintrc

@@ -14,7 +14,9 @@ load-plugins=pylint_guidelines_checker
 # cyclic-import: because of https://github.com/PyCQA/pylint/issues/850
 # too-many-arguments: Due to the nature of the CLI many commands have large arguments set which reflect in large arguments set in corresponding methods.
 # Let's black deal with bad-continuation
-disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,bad-continuation,check-docstrings,import-outside-toplevel
+
+# Added disables from super-with-arguments
+disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,bad-continuation,check-docstrings,import-outside-toplevel,super-with-arguments,raise-missing-from,inconsistent-return-statements,deprecated-module,use-a-generator,consider-using-max-builtin,consider-using-min-builtin,simplifiable-condition,condition-evals-to-constant,consider-using-dict-items,assigning-non-slot,consider-using-with,consider-using-generator,unused-private-member,deprecated-class,consider-using-from-import,ungrouped-imports,nan-comparison,ignored-arguments-name,empty-comment,deprecated-argument,deprecated-decorator,consider-using-dict-items,use-maxsplit-arg,unnecessary-dict-index-lookup,unused-private-member,invalid-class-object,invalid-all-format,await-outside-async
 
 [FORMAT]
 max-line-length=120

scripts/pylint_custom_plugin/dev_requirements.txt

@@ -1 +1 @@
-pylint==2.5.2
+pylint==2.9.3