Skip to content

Commit fcd717b

Browse files
authored
Unvendor (Azure#31744)
* Removed _vendor * Update references * Tests * Fix
1 parent 9367722 commit fcd717b

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+55
-5774
lines changed

sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
([#310](https://github.com/microsoft/ApplicationInsights-Python/pull/310))
99
- Replace explicit log processor exporter interval env var with OT SDK env var
1010
([#31740](https://github.com/Azure/azure-sdk-for-python/pull/31740))
11+
- Un-vendoring instrumentations
12+
([#31744](https://github.com/Azure/azure-sdk-for-python/pull/31740))
1113

1214
### Breaking Changes
1315

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py

Lines changed: 18 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@
77
from typing import Dict, cast
88

99
from opentelemetry._logs import get_logger_provider, set_logger_provider
10+
from opentelemetry.instrumentation.dependencies import (
11+
get_dist_dependency_conflicts,
12+
)
13+
from opentelemetry.instrumentation.instrumentor import (
14+
BaseInstrumentor,
15+
)
1016
from opentelemetry.metrics import set_meter_provider
1117
from opentelemetry.sdk._logs import LoggerProvider, LoggingHandler
1218
from opentelemetry.sdk._logs.export import BatchLogRecordProcessor
@@ -28,12 +34,6 @@
2834
SAMPLING_RATIO_ARG,
2935
)
3036
from azure.monitor.opentelemetry._types import ConfigurationValue
31-
from azure.monitor.opentelemetry._vendor.v0_39b0.opentelemetry.instrumentation.dependencies import (
32-
get_dependency_conflicts,
33-
)
34-
from azure.monitor.opentelemetry._vendor.v0_39b0.opentelemetry.instrumentation.instrumentor import (
35-
BaseInstrumentor,
36-
)
3737
from azure.monitor.opentelemetry.exporter import ( # pylint: disable=import-error
3838
ApplicationInsightsSampler,
3939
AzureMonitorLogExporter,
@@ -44,16 +44,15 @@
4444

4545
_logger = getLogger(__name__)
4646

47-
48-
_SUPPORTED_INSTRUMENTED_LIBRARIES_DEPENDENCIES_MAP = {
49-
"django": ("django >= 1.10",),
50-
"fastapi": ("fastapi ~= 0.58",),
51-
"flask": ("flask >= 1.0, < 3.0",),
52-
"psycopg2": ("psycopg2 >= 2.7.3.1",),
53-
"requests": ("requests ~= 2.0",),
54-
"urllib": tuple(),
55-
"urllib3": ("urllib3 >= 1.0.0, < 2.0.0",),
56-
}
47+
_SUPPORTED_INSTRUMENTED_LIBRARIES = (
48+
"django",
49+
"fastapi",
50+
"flask",
51+
"psycopg2",
52+
"requests",
53+
"urllib",
54+
"urllib3",
55+
)
5756

5857

5958
def configure_azure_monitor(**kwargs) -> None:
@@ -138,10 +137,10 @@ def _setup_instrumentations(configurations: Dict[str, ConfigurationValue]):
138137

139138
# use pkg_resources for now until https://github.com/open-telemetry/opentelemetry-python/pull/3168 is merged
140139
for entry_point in iter_entry_points(
141-
"azure_monitor_opentelemetry_instrumentor"
140+
"opentelemetry_instrumentor"
142141
):
143142
lib_name = entry_point.name
144-
if lib_name not in _SUPPORTED_INSTRUMENTED_LIBRARIES_DEPENDENCIES_MAP:
143+
if lib_name not in _SUPPORTED_INSTRUMENTED_LIBRARIES:
145144
continue
146145
if entry_point.name in disabled_instrumentations:
147146
_logger.debug(
@@ -150,10 +149,7 @@ def _setup_instrumentations(configurations: Dict[str, ConfigurationValue]):
150149
continue
151150
try:
152151
# Check if dependent libraries/version are installed
153-
instruments = _SUPPORTED_INSTRUMENTED_LIBRARIES_DEPENDENCIES_MAP[
154-
lib_name
155-
]
156-
conflict = get_dependency_conflicts(instruments)
152+
conflict = get_dist_dependency_conflicts(entry_point.dist)
157153
if conflict:
158154
_logger.debug(
159155
"Skipping instrumentation %s: %s",

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_vendor/__init__.py

Lines changed: 0 additions & 5 deletions
This file was deleted.

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_vendor/v0_39b0/__init__.py

Lines changed: 0 additions & 5 deletions
This file was deleted.

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_vendor/v0_39b0/opentelemetry/__init__.py

Lines changed: 0 additions & 5 deletions
This file was deleted.

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_vendor/v0_39b0/opentelemetry/instrumentation/__init__.py

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)