Add manual approval before yanking test pipeline crates (Azure#2355)

Author: hallipr

eng/pipelines/templates/stages/archetype-rust-release.yml

@@ -153,9 +153,24 @@ stages:
                 BaseBranchName: main
 
         - ${{ if eq(parameters.TestPipeline, true) }}:
+          - job: ManualApproval
+            displayName: "Manual approval"
+            dependsOn: PublishPackage
+            condition: ne(variables['Skip.PublishPackage'], 'true')
+            pool: server
+            timeoutInMinutes: 120 # 2 hours
+            steps:
+            - task: ManualValidation@1
+              timeoutInMinutes: 60 # 1 hour
+              inputs:
+                notifyUsers: '' # Required, but empty string allowed
+                allowApproversToApproveTheirOwnRuns: true
+                instructions: "Approve yank of ${{ artifact.name }}"
+                onTimeout: 'resume'
+
           - job: YankCrates
             displayName: "Yank Crates"
-            dependsOn: PublishPackage
+            dependsOn: ManualApproval
             condition: and(succeeded(), ne(variables['Skip.PublishPackage'], 'true'))
             steps:
             - template: /eng/common/pipelines/templates/steps/sparse-checkout.yml

eng/scripts/Yank-Crates.ps1

@@ -14,14 +14,20 @@ foreach ($crateName in $crateNames) {
   $crate = Get-Content "$PackageInfoDirectory/$crateName.json" -Raw | ConvertFrom-Json
   $crateVersion = $crate.Version
 
-  Write-Host "Yanking crate: '$crateName@$crateVersion'"
+  Write-Host "> cargo yank $crateName --version $crateVersion"
+  cargo yank $crateName --version $crateVersion 2>&1 | Tee-Object -Variable output
 
-  Write-Host "cargo yank $crateName --version $crateVersion"
-  cargo yank $crateName --version $crateVersion
-
-  if (!$?) {
-    Write-Host "Failed to yank crate: '$crateName@$crateVersion'"
-    $hasErrors = $true
+  if ($LASTEXITCODE -ne 0) {
+    if ($output -match 'status 404 Not Found') {
+      Write-Host "Crate '$crateName@$crateVersion' not found. Skipping yank."
+    }
+    else {
+      Write-Host "Error yanking crate: '$crateName@$crateVersion'"
+      $hasErrors = $true
+    }
+  }
+  else {
+    Write-Host "Successfully yanked crate: '$crateName@$crateVersion'"
   }
 }