Move process executor from azure_core to azure_identity (Azure#2712)

Author: chlowell

sdk/core/azure_core/CHANGELOG.md

@@ -9,6 +9,8 @@ the asynchronous runtime used by the Azure SDK.
 
 ### Breaking Changes
 
+- Moved `process::Executor` to `azure_identity`.
+
 ### Bugs Fixed
 
 ### Other Changes

sdk/core/azure_core/Cargo.toml

@@ -57,7 +57,7 @@ reqwest_deflate = ["typespec_client_core/reqwest_deflate"]
 reqwest_gzip = ["typespec_client_core/reqwest_gzip"]
 reqwest_rustls = ["typespec_client_core/reqwest_rustls"]
 test = ["typespec_client_core/test"]
-tokio = ["dep:tokio", "tokio/process", "typespec_client_core/tokio"]
+tokio = ["dep:tokio", "typespec_client_core/tokio"]
 xml = ["typespec_client_core/xml"]
 
 [lints]

sdk/core/azure_core/src/lib.rs

@@ -14,7 +14,6 @@ pub mod credentials;
 pub mod fs;
 pub mod hmac;
 pub mod http;
-pub mod process;
 
 #[cfg(feature = "test")]
 pub mod test;

sdk/core/azure_core/src/process/mod.rs

@@ -6,6 +6,8 @@
 
 ### Breaking Changes
 
+- Replaced `azure_core::process::Executor` with `azure_identity::process::Executor`.
+
 ### Bugs Fixed
 
 ### Other Changes

sdk/identity/azure_identity/CHANGELOG.md

@@ -21,6 +21,7 @@ openssl = { workspace = true, optional = true }
 pin-project.workspace = true
 serde.workspace = true
 time.workspace = true
+tokio = { workspace = true, optional = true }
 tracing.workspace = true
 typespec_client_core = { workspace = true, features = ["derive"] }
 url.workspace = true
@@ -39,7 +40,7 @@ tracing-subscriber.workspace = true
 default = ["reqwest"]
 reqwest = ["azure_core/reqwest"]
 reqwest_rustls = ["azure_core/reqwest_rustls"]
-tokio = ["azure_core/tokio"]
+tokio = ["dep:tokio", "azure_core/tokio", "tokio/process"]
 client_certificate = ["openssl"]
 
 [lints]

sdk/identity/azure_identity/Cargo.toml

@@ -3,14 +3,13 @@
 
 use crate::{
     env::Env,
-    process::{shell_exec, OutputProcessor},
+    process::{new_executor, shell_exec, Executor, OutputProcessor},
     validate_scope, validate_subscription, validate_tenant_id, TokenCredentialOptions,
 };
 use azure_core::{
     credentials::{AccessToken, Secret, TokenCredential, TokenRequestOptions},
     error::{Error, ErrorKind, ResultExt},
     json::from_json,
-    process::{new_executor, Executor},
 };
 use serde::Deserialize;
 use std::{ffi::OsString, sync::Arc};

sdk/identity/azure_identity/src/azure_cli_credential.rs

@@ -3,14 +3,13 @@
 
 use crate::{
     env::Env,
-    process::{shell_exec, OutputProcessor},
+    process::{new_executor, shell_exec, Executor, OutputProcessor},
     validate_scope, validate_tenant_id, TokenCredentialOptions,
 };
 use azure_core::{
     credentials::{AccessToken, Secret, TokenCredential, TokenRequestOptions},
     error::{Error, ErrorKind},
     json::from_json,
-    process::{new_executor, Executor},
 };
 use serde::de::{self, Deserializer};
 use serde::Deserialize;

sdk/identity/azure_identity/src/azure_developer_cli_credential.rs

@@ -34,6 +34,7 @@ pub use client_secret_credential::*;
 pub use default_azure_credential::*;
 pub use managed_identity_credential::*;
 pub use options::TokenCredentialOptions;
+pub use process::{new_executor, Executor};
 pub use workload_identity_credential::*;
 
 pub(crate) use app_service_managed_identity_credential::*;
@@ -172,11 +173,11 @@ fn test_validate_tenant_id() {
 
 #[cfg(test)]
 mod tests {
+    use crate::process::Executor;
     use async_trait::async_trait;
     use azure_core::{
         error::ErrorKind,
         http::{RawResponse, Request},
-        process::Executor,
         Error, Result,
     };
     use std::{

sdk/identity/azure_identity/src/lib.rs

@@ -1,11 +1,13 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-use crate::env::Env;
+use crate::{
+    env::Env,
+    process::{new_executor, Executor},
+};
 use azure_core::{
     error::{ErrorKind, Result, ResultExt},
     http::{new_http_client, HttpClient, Url},
-    process::Executor,
 };
 use std::sync::Arc;
 
@@ -36,7 +38,7 @@ impl Default for TokenCredentialOptions {
             env: Env::default(),
             http_client: new_http_client(),
             authority_host,
-            executor: azure_core::process::new_executor(),
+            executor: new_executor(),
         }
     }
 }