Rename read_xml to from_xml (Azure#3218)

Also removes `read_xml_str()` that was unused.

Author: heaths

sdk/core/azure_core/CHANGELOG.md

@@ -10,6 +10,8 @@
 - Removed `constants` module.
 - Removed `CustomHeaders` policy.
 - Removed `ErrorKind::MockFramework`.
+- Removed `xml::read_xml_str()`.
+- Renamed `xml::read_xml()` to `xml::from_xml()` congruent with `json::from_json()`.
 
 ### Bugs Fixed
 

sdk/core/azure_core/benches/deserialization.rs

@@ -61,7 +61,7 @@ fn deserialize_list_blobs(c: &mut Criterion) {
         group.bench_function("xml", |b| {
             b.iter(|| {
                 let _: ListBlobsFlatSegmentResponse =
-                    black_box(xml::read_xml(&blobs_xml).expect("deserialize xml"));
+                    black_box(xml::from_xml(&blobs_xml).expect("deserialize xml"));
             });
         });
         group.finish();

sdk/core/typespec/CHANGELOG.md

@@ -7,6 +7,8 @@
 ### Breaking Changes
 
 - Removed `ErrorKind::MockFramework`.
+- Removed `xml::read_xml_str()`.
+- Renamed `xml::read_xml()` to `xml::from_xml()` congruent with `json::from_json()`.
 
 ### Bugs Fixed
 

sdk/core/typespec/src/http/response.rs

@@ -93,7 +93,7 @@ impl ResponseBody {
     where
         T: DeserializeOwned,
     {
-        crate::xml::read_xml(&self.0)
+        crate::xml::from_xml(&self.0)
     }
 }
 

sdk/core/typespec/src/xml.rs

@@ -6,7 +6,7 @@ use crate::error::{ErrorKind, Result, ResultExt};
 use bytes::Bytes;
 pub use quick_xml::serde_helpers::text_content as content;
 use quick_xml::{
-    de::{from_reader, from_str},
+    de::from_reader,
     se::{to_string, to_string_with_root},
 };
 use serde::de::DeserializeOwned;
@@ -18,18 +18,7 @@ const UTF8_BOM: [u8; 3] = [0xEF, 0xBB, 0xBF];
 const DECLARATION: &[u8; 38] = br#"<?xml version="1.0" encoding="utf-8"?>"#;
 
 /// Reads XML from bytes.
-pub fn read_xml_str<T>(body: &str) -> Result<T>
-where
-    T: DeserializeOwned,
-{
-    from_str(body).with_context_fn(ErrorKind::DataConversion, || {
-        let t = core::any::type_name::<T>();
-        format!("failed to deserialize the following xml into a {t}\n{body}")
-    })
-}
-
-/// Reads XML from bytes.
-pub fn read_xml<T>(body: &[u8]) -> Result<T>
+pub fn from_xml<T>(body: &[u8]) -> Result<T>
 where
     T: DeserializeOwned,
 {
@@ -110,15 +99,9 @@ mod test {
             x: "Hello, world!".into(),
         };
         let xml = br#"<?xml version="1.0" encoding="utf-8"?><Foo><x>Hello, world!</x></Foo>"#;
-        assert_eq!(test, read_xml(xml)?);
-
-        let error = read_xml::<Test>(&xml[..xml.len() - 2]).unwrap_err();
-        assert!(format!("{error}").contains("typespec::xml::test::Test"));
-
-        let xml = r#"<?xml version="1.0" encoding="utf-8"?><Foo><x>Hello, world!</x></Foo>"#;
-        assert_eq!(test, read_xml_str(xml)?);
+        assert_eq!(test, from_xml(xml)?);
 
-        let error = read_xml_str::<Test>(&xml[..xml.len() - 2]).unwrap_err();
+        let error = from_xml::<Test>(&xml[..xml.len() - 2]).unwrap_err();
         assert!(format!("{error}").contains("typespec::xml::test::Test"));
         Ok(())
     }

sdk/core/typespec_client_core/CHANGELOG.md

@@ -9,6 +9,8 @@
 - Moved deserializers and serializers for optional base64-encoded bytes to `base64::option` module. `base64` module now deserializes or serializes non-optional fields congruent with the `time` module.
 - Removed `CustomHeaders` policy.
 - Removed `ErrorKind::MockFramework`.
+- Removed `xml::read_xml_str()`.
+- Renamed `xml::read_xml()` to `xml::from_xml()` congruent with `json::from_json()`.
 
 ### Bugs Fixed