Remove parity features (Azure#2933)

Resolves Azure#2750 and replaces Azure#2811 by removing the `reqwest_rustls`
feature which was there only to enable
`reqwest/rustls-tls-native-roots-no-provider`. But using resolver v2 and
newer, dependents can already do that by just taking a dependency on
`reqwest` themselves to add that feature. In some cases, they may need
to import `azure_core` with `default-features=false`, but passing a
different `reqwest::Client` via our `TransportOptions` is easy.

Not only will this scale better, but should help avoid opinionated
feature selection that adversely impacts customers as with Azure#2750.

Author: heaths

.vscode/cspell.json

@@ -60,17 +60,18 @@
     "msrv",
     "newtonsoft",
     "oidc",
-    "otel",
     "opentelemetry",
+    "otel",
     "pageable",
     "pageables",
     "pkce",
     "pkcs",
-    "pwsh",
     "posix",
+    "pwsh",
     "reqwest",
     "runtimes",
     "rustup",
+    "schannel",
     "seekable",
     "servicebus",
     "spector",
@@ -79,8 +80,8 @@
     "telemetered",
     "typespec",
     "undelete",
-    "upvote",
     "uninlined",
+    "upvote",
     "userdelegationkey",
     "vcpkg",
     "versionid",

Cargo.lock

@@ -49,6 +49,7 @@ version = "0.7.0"
 path = "sdk/typespec/typespec_macros"
 
 [workspace.dependencies.azure_core]
+default-features = false
 version = "0.28.0"
 path = "sdk/core/azure_core"
 
@@ -117,7 +118,6 @@ quote = "1.0.37"
 rand = "0.9.1"
 rand_chacha = "0.9"
 reqwest = { version = "0.12.23", features = [
-  "json",
   "stream",
 ], default-features = false }
 rust_decimal.version = "1.37.2"

Cargo.toml

@@ -28,7 +28,7 @@ sha2 = { workspace = true, optional = true }
 tokio = { workspace = true, optional = true }
 tracing.workspace = true
 typespec = { workspace = true, features = ["http", "json"] }
-typespec_client_core = { workspace = true, features = [
+typespec_client_core = { workspace = true, default-features = false, features = [
   "derive",
   "http",
   "json",
@@ -54,18 +54,20 @@ default = [
   "reqwest",
   "reqwest_deflate",
   "reqwest_gzip",
+  "reqwest_native_tls",
 ]
 azurite_workaround = []
 debug = ["typespec_client_core/debug"]
 decimal = ["typespec_client_core/decimal"]
 hmac_openssl = ["dep:openssl"]
 hmac_rust = ["dep:sha2", "dep:hmac"]
 reqwest = ["typespec_client_core/reqwest"]
-reqwest_deflate = ["typespec_client_core/reqwest_deflate"]
-reqwest_gzip = ["typespec_client_core/reqwest_gzip"]
-reqwest_rustls = ["typespec_client_core/reqwest_rustls"]
+reqwest_deflate = ["reqwest", "typespec_client_core/reqwest_deflate"]
+reqwest_gzip = ["reqwest", "typespec_client_core/reqwest_gzip"]
+reqwest_native_tls = ["reqwest", "typespec_client_core/reqwest_native_tls"]
 test = ["typespec_client_core/test"]
 tokio = ["dep:tokio", "typespec_client_core/tokio"]
+wasm_bindgen = ["typespec_client_core/wasm_bindgen"]
 xml = ["typespec_client_core/xml"]
 
 [lints]
@@ -80,8 +82,9 @@ features = [
   "reqwest",
   "reqwest_deflate",
   "reqwest_gzip",
-  "reqwest_rustls",
+  "reqwest_native_tls",
   "tokio",
+  "wasm_bindgen",
   "xml",
 ]
 

sdk/core/azure_core/Cargo.toml

@@ -45,13 +45,16 @@ We guarantee that all client instance methods are thread-safe and independent of
 ## Features
 
 - `debug`: enables extra information for developers e.g., emitting all fields in `std::fmt::Debug` implementation.
-- `hmac_openssl`: configures HMAC using `openssl`.
-- `hmac_rust`: configures HMAC using pure Rust.
+- `decimal`: enables support for `rust_decimal::Decimal` type.
+- `derive`: enable derive macros e.g., `SafeDebug`.
+- `hmac_openssl`: enables HMAC signing using `openssl`. If both `hmac_openssl` and `hmac_rust` are enabled, `hmac_openssl` is used.
+- `hmac_rust`: enables HMAC signing using rust-native libraries `sha2` and `hmac`. If both `hmac_openssl` and `hmac_rust` are enabled, `hmac_openssl` is used.
 - `reqwest` (default): enables and sets `reqwest` as the default `HttpClient`. Enables `reqwest`'s `native-tls` feature.
 - `reqwest_deflate` (default): enables deflate compression for `reqwest`.
 - `reqwest_gzip` (default): enables gzip compression for `reqwest`.
-- `reqwest_rustls`: enables `reqwest`'s `rustls-tls-native-roots-no-provider` feature,
+- `reqwest_native-tls` (default): enables `reqwest`'s `native-tls` feature, which uses schannel on Windows and openssl elsewhere.
 - `tokio`: enables and sets `tokio` as the default async runtime.
+- `wasm_bindgen`: enables the async runtime for WASM.
 - `xml`: enables XML support.
 
 ## Examples

sdk/core/azure_core/README.md

@@ -13,6 +13,9 @@ categories = ["api-bindings", "development-tools::debugging"]
 edition.workspace = true
 rust-version.workspace = true
 
+[features]
+default = ["azure_core/default"]
+
 [dependencies]
 azure_core.workspace = true
 opentelemetry.workspace = true

sdk/core/azure_core_opentelemetry/Cargo.toml

@@ -32,4 +32,4 @@ tokio.workspace = true
 tracing-subscriber.workspace = true
 
 [features]
-default = []
+default = ["azure_core/default"]

sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/Cargo.toml

@@ -23,7 +23,6 @@ serde.workspace = true
 time.workspace = true
 tokio = { workspace = true, optional = true }
 tracing.workspace = true
-typespec_client_core = { workspace = true, features = ["derive"] }
 url.workspace = true
 
 [dev-dependencies]
@@ -37,19 +36,9 @@ tokio.workspace = true
 tracing-subscriber.workspace = true
 
 [features]
-default = ["reqwest"]
-reqwest = ["azure_core/reqwest"]
-reqwest_rustls = ["azure_core/reqwest_rustls"]
+default = ["azure_core/default"]
 tokio = ["dep:tokio", "azure_core/tokio", "tokio/process"]
 client_certificate = ["openssl"]
 
 [lints]
 workspace = true
-
-[package.metadata.docs.rs]
-features = [
-  "client_certificate",
-  "reqwest",
-  "reqwest_rustls",
-  "tokio",
-]

sdk/identity/azure_identity/Cargo.toml

@@ -13,6 +13,9 @@ documentation = "https://docs.rs/azure_security_keyvault_certificates"
 keywords = ["sdk", "azure", "keyvault", "security", "certificates"]
 categories = ["api-bindings"]
 
+[features]
+default = ["azure_core/default"]
+
 [dependencies]
 async-trait = { workspace = true }
 azure_core = { workspace = true }

sdk/keyvault/azure_security_keyvault_certificates/Cargo.toml

@@ -13,6 +13,9 @@ documentation = "https://docs.rs/azure_security_keyvault_keys"
 keywords = ["sdk", "azure", "keyvault", "security", "keys"]
 categories = ["api-bindings"]
 
+[features]
+default = ["azure_core/default"]
+
 [dependencies]
 async-trait = { workspace = true }
 azure_core = { workspace = true }