Skip to content

Commit b61e0dd

Browse files
authored
Set IncludeForValidation correctly for additional validation packages (Azure#2310)
- Exclude dev and build dependencies from DependantPackages list - Remove implicit addition of azure_core and azure_template - The common script automatically includes all /sdk/tempalte packages when there's no other package being tested - Set IncludedForValidation to $true for all packages included because of service directory changes
1 parent 588ff8d commit b61e0dd

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

eng/scripts/Language-Settings.ps1

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ function Get-AllPackageInfoFromRepo ([string] $ServiceDirectory) {
7171

7272
# Invert the manifest dependency graph
7373
foreach ($package in $packageManifests.Values) {
74-
foreach ($dependency in $package.dependencies) {
74+
foreach ($dependency in $package.dependencies | Where-Object { $null -eq $_.kind }) {
7575
$dependencyManifest = $packageManifests[$dependency.name]
7676
if ($dependencyManifest) {
7777
$dependencyManifest.DependentPackages += $package
@@ -131,9 +131,8 @@ function Get-rust-AdditionalValidationPackagesFromPackageSet ($packagesWithChang
131131

132132
[array]$additionalPackages = $affectedPackages | Where-Object { $packagesWithChanges -notcontains $_ }
133133

134-
# if the change affected no packages, e.g. eng/common change, we use core and template for validation
135-
if ($packagesWithChanges.Length -eq 0) {
136-
$additionalPackages += $allPackageProperties | Where-Object { $_.Name -eq "azure_core" -or $_.Name -eq "azure_template" }
134+
foreach ($package in $additionalPackages) {
135+
$package.IncludedForValidation = $true
137136
}
138137

139138
return $additionalPackages

0 commit comments

Comments
 (0)