|
| 1 | +From a459b0c22a8f53dbaa9f84e8320c4176a051cc23 Mon Sep 17 00:00:00 2001 |
| 2 | +From: Azure Linux Security Servicing Account |
| 3 | + |
| 4 | +Date: Wed, 9 Jul 2025 05:27:25 +0000 |
| 5 | +Subject: [PATCH] Fix CVE CVE-2025-32023 in redis |
| 6 | + |
| 7 | +Upstream Patch Reference: https://github.com/redis/redis/commit/50188747cbfe43528d2719399a2a3c9599169445.diff |
| 8 | +--- |
| 9 | + src/hyperloglog.c | 47 ++++++++++++++++++++++++++++++++++++++++++----- |
| 10 | + 1 file changed, 42 insertions(+), 5 deletions(-) |
| 11 | + |
| 12 | +diff --git a/src/hyperloglog.c b/src/hyperloglog.c |
| 13 | +index 75a0422..7cabfa1 100644 |
| 14 | +--- a/src/hyperloglog.c |
| 15 | ++++ b/src/hyperloglog.c |
| 16 | +@@ -586,6 +586,7 @@ int hllSparseToDense(robj *o) { |
| 17 | + struct hllhdr *hdr, *oldhdr = (struct hllhdr*)sparse; |
| 18 | + int idx = 0, runlen, regval; |
| 19 | + uint8_t *p = (uint8_t*)sparse, *end = p+sdslen(sparse); |
| 20 | ++ int valid = 1; |
| 21 | + |
| 22 | + /* If the representation is already the right one return ASAP. */ |
| 23 | + hdr = (struct hllhdr*) sparse; |
| 24 | +@@ -605,16 +606,27 @@ int hllSparseToDense(robj *o) { |
| 25 | + while(p < end) { |
| 26 | + if (HLL_SPARSE_IS_ZERO(p)) { |
| 27 | + runlen = HLL_SPARSE_ZERO_LEN(p); |
| 28 | ++ if ((runlen + idx) > HLL_REGISTERS) { /* Overflow. */ |
| 29 | ++ valid = 0; |
| 30 | ++ break; |
| 31 | ++ } |
| 32 | + idx += runlen; |
| 33 | + p++; |
| 34 | + } else if (HLL_SPARSE_IS_XZERO(p)) { |
| 35 | + runlen = HLL_SPARSE_XZERO_LEN(p); |
| 36 | ++ if ((runlen + idx) > HLL_REGISTERS) { /* Overflow. */ |
| 37 | ++ valid = 0; |
| 38 | ++ break; |
| 39 | ++ } |
| 40 | + idx += runlen; |
| 41 | + p += 2; |
| 42 | + } else { |
| 43 | + runlen = HLL_SPARSE_VAL_LEN(p); |
| 44 | + regval = HLL_SPARSE_VAL_VALUE(p); |
| 45 | +- if ((runlen + idx) > HLL_REGISTERS) break; /* Overflow. */ |
| 46 | ++ if ((runlen + idx) > HLL_REGISTERS) { /* Overflow. */ |
| 47 | ++ valid = 0; |
| 48 | ++ break; |
| 49 | ++ } |
| 50 | + while(runlen--) { |
| 51 | + HLL_DENSE_SET_REGISTER(hdr->registers,idx,regval); |
| 52 | + idx++; |
| 53 | +@@ -625,7 +637,7 @@ int hllSparseToDense(robj *o) { |
| 54 | + |
| 55 | + /* If the sparse representation was valid, we expect to find idx |
| 56 | + * set to HLL_REGISTERS. */ |
| 57 | +- if (idx != HLL_REGISTERS) { |
| 58 | ++ if (!valid || idx != HLL_REGISTERS) { |
| 59 | + sdsfree(dense); |
| 60 | + return C_ERR; |
| 61 | + } |
| 62 | +@@ -911,27 +923,40 @@ int hllSparseAdd(robj *o, unsigned char *ele, size_t elesize) { |
| 63 | + void hllSparseRegHisto(uint8_t *sparse, int sparselen, int *invalid, int* reghisto) { |
| 64 | + int idx = 0, runlen, regval; |
| 65 | + uint8_t *end = sparse+sparselen, *p = sparse; |
| 66 | ++ int valid = 1; |
| 67 | + |
| 68 | + while(p < end) { |
| 69 | + if (HLL_SPARSE_IS_ZERO(p)) { |
| 70 | + runlen = HLL_SPARSE_ZERO_LEN(p); |
| 71 | ++ if ((runlen + idx) > HLL_REGISTERS) { /* Overflow. */ |
| 72 | ++ valid = 0; |
| 73 | ++ break; |
| 74 | ++ } |
| 75 | + idx += runlen; |
| 76 | + reghisto[0] += runlen; |
| 77 | + p++; |
| 78 | + } else if (HLL_SPARSE_IS_XZERO(p)) { |
| 79 | + runlen = HLL_SPARSE_XZERO_LEN(p); |
| 80 | ++ if ((runlen + idx) > HLL_REGISTERS) { /* Overflow. */ |
| 81 | ++ valid = 0; |
| 82 | ++ break; |
| 83 | ++ } |
| 84 | + idx += runlen; |
| 85 | + reghisto[0] += runlen; |
| 86 | + p += 2; |
| 87 | + } else { |
| 88 | + runlen = HLL_SPARSE_VAL_LEN(p); |
| 89 | + regval = HLL_SPARSE_VAL_VALUE(p); |
| 90 | ++ if ((runlen + idx) > HLL_REGISTERS) { /* Overflow. */ |
| 91 | ++ valid = 0; |
| 92 | ++ break; |
| 93 | ++ } |
| 94 | + idx += runlen; |
| 95 | + reghisto[regval] += runlen; |
| 96 | + p++; |
| 97 | + } |
| 98 | + } |
| 99 | +- if (idx != HLL_REGISTERS && invalid) *invalid = 1; |
| 100 | ++ if ((!valid || idx != HLL_REGISTERS) && invalid) *invalid = 1; |
| 101 | + } |
| 102 | + |
| 103 | + /* ========================= HyperLogLog Count ============================== |
| 104 | +@@ -1079,22 +1104,34 @@ int hllMerge(uint8_t *max, robj *hll) { |
| 105 | + } else { |
| 106 | + uint8_t *p = hll->ptr, *end = p + sdslen(hll->ptr); |
| 107 | + long runlen, regval; |
| 108 | ++ int valid = 1; |
| 109 | + |
| 110 | + p += HLL_HDR_SIZE; |
| 111 | + i = 0; |
| 112 | + while(p < end) { |
| 113 | + if (HLL_SPARSE_IS_ZERO(p)) { |
| 114 | + runlen = HLL_SPARSE_ZERO_LEN(p); |
| 115 | ++ if ((runlen + i) > HLL_REGISTERS) { /* Overflow. */ |
| 116 | ++ valid = 0; |
| 117 | ++ break; |
| 118 | ++ } |
| 119 | + i += runlen; |
| 120 | + p++; |
| 121 | + } else if (HLL_SPARSE_IS_XZERO(p)) { |
| 122 | + runlen = HLL_SPARSE_XZERO_LEN(p); |
| 123 | ++ if ((runlen + i) > HLL_REGISTERS) { /* Overflow. */ |
| 124 | ++ valid = 0; |
| 125 | ++ break; |
| 126 | ++ } |
| 127 | + i += runlen; |
| 128 | + p += 2; |
| 129 | + } else { |
| 130 | + runlen = HLL_SPARSE_VAL_LEN(p); |
| 131 | + regval = HLL_SPARSE_VAL_VALUE(p); |
| 132 | +- if ((runlen + i) > HLL_REGISTERS) break; /* Overflow. */ |
| 133 | ++ if ((runlen + i) > HLL_REGISTERS) { /* Overflow. */ |
| 134 | ++ valid = 0; |
| 135 | ++ break; |
| 136 | ++ } |
| 137 | + while(runlen--) { |
| 138 | + if (regval > max[i]) max[i] = regval; |
| 139 | + i++; |
| 140 | +@@ -1102,7 +1139,7 @@ int hllMerge(uint8_t *max, robj *hll) { |
| 141 | + p++; |
| 142 | + } |
| 143 | + } |
| 144 | +- if (i != HLL_REGISTERS) return C_ERR; |
| 145 | ++ if (!valid || i != HLL_REGISTERS) return C_ERR; |
| 146 | + } |
| 147 | + return C_OK; |
| 148 | + } |
| 149 | +-- |
| 150 | +2.45.3 |
| 151 | + |
0 commit comments