Skip to content

Commit 12ba94f

Browse files
authored
Reduce docs warnings and correct adding guidelines (ros-controls#219)
* Correct docs * More corrections
1 parent 6a53981 commit 12ba94f

File tree

9 files changed

+24
-19
lines changed

9 files changed

+24
-19
lines changed

diff_drive_controller/doc/userdoc.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
.. _diff_drive_controller_userdoc:
22

33
diff_drive_controller
4-
---------------------
4+
=====================
55

66
Controller for mobile robots with differential drive.
77
Input for control are robot body velocity commands which are translated to wheel commands for the differential drive base.
88
Odometry is computed from hardware feedback and published.
99

1010
Velocity commands
11-
^^^^^^^^^^^^^^^^^
11+
-----------------
1212

1313
The controller works with a velocity twist from which it extracts the x component of the linear velocity and the z component of the angular velocity. Velocities on other components are ignored.
1414

1515
Hardware interface type
16-
^^^^^^^^^^^^^^^^^^^^^^^
16+
-----------------------
1717

1818
The controller works with wheel joints through a velocity interface.
1919

2020
Other features
21-
^^^^^^^^^^^^^^
21+
--------------
2222

2323
Realtime-safe implementation.
2424
Odometry publishing

doc/controllers_index.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,12 @@ Guidelines and Best Practices
3333
=============================
3434

3535
.. toctree::
36-
:titlesonly: 1
36+
:titlesonly:
3737
:glob:
3838

3939
*
4040

41+
4142
Available Controllers
4243
=====================
4344

@@ -51,6 +52,7 @@ Available Controllers
5152
Velocity Controllers <../velocity_controllers/doc/userdoc.rst>
5253
Effort Controllers <../effort_controllers/doc/userdoc.rst>
5354

55+
5456
Available Broadcasters
5557
======================
5658

doc/writing_new_controller.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ The following is a step-by-step guide to create source files, basic tests, and c
104104

105105
5. Export for pluginlib description file using the following command:
106106
.. code:: cmake
107+
107108
pluginlib_export_plugin_description_file(controller_interface <controller_name>.xml)
108109
109110
6. Add install directives for targets and include directory.

effort_controllers/doc/userdoc.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
.. _effort_controllers_userdoc:
22

33
effort_controllers
4-
---------------------
4+
==================
55

66
This is a collection of controllers that work using the "effort" joint command interface but may accept different joint-level commands at the controller level, e.g. controlling the effort on a certain joint to achieve a set position.
77

88
Hardware interface type
9-
^^^^^^^^^^^^^^^^^^^^^^^
9+
-----------------------
1010

1111
These controllers work with joints using the "effort" command interface.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
.. _forward_command_controller_userdoc:
22

33
forward_command_controller
4-
--------------------------
4+
==========================
55

66
This is a collection of controllers that work using the "effort" joint command interface but may accept different joint-level commands at the controller level, e.g. controlling the effort on a certain joint to achieve a set position.
77

88
Hardware interface type
9-
^^^^^^^^^^^^^^^^^^^^^^^
9+
-----------------------
1010

1111
These controllers work with joints using the "effort" command interface.
Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,22 @@
11
.. _joint_state_broadcaster_userdoc:
22

33
joint_state_broadcaster
4-
----------------------
4+
=======================
55

66
The broadcaster reads all state interfaces and reports them on ``/joint_states`` and ``/dynamic_joint_states``.
77

88
Commands
9-
^^^^^^^^
9+
--------
1010

1111
Broadcasters are not real controllers, and therefore take no commands.
1212

1313
Hardware interface type
14-
^^^^^^^^^^^^^^^^^^^^^^^
14+
-----------------------
1515

1616
All available *joint state interfaces* are used by this broadcaster.
1717

1818
Parameters
19-
^^^^^^^^^^
19+
----------
2020

21-
The parameter ``extra_joints`` is optional and is an array of strings consisting of the names of the extra joints that will be added to ``/joint_states`` and ``/dynamic_joint_states`` with state set to 0.
21+
extra_joints (optional; string array; default: empty)
22+
Names of extra joints to be added to ``/joint_states`` and ``/dynamic_joint_states`` with state set to 0.

joint_trajectory_controller/doc/userdoc.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.. _joint_trajectory_controller_userdoc:
22

33
joint_trajectory_controller
4-
---------------------------
4+
===========================
55

66
Controller for executing joint-space trajectories on a group of joints. Trajectories are specified as a set of waypoints to be reached at specific time instants, which the controller attempts to execute as well as the mechanism allows. Waypoints consist of positions, and optionally velocities and accelerations.
77

@@ -95,6 +95,7 @@ The following version of the Joint Trajectory Controller are available mapping t
9595
- position_velocity_acceleration_controllers::JointTrajectoryController
9696
- Input: position, [velocity, [acceleration]]
9797
- Output: position, velocity and acceleration
98+
9899
.. - velocity_controllers::JointTrajectoryController
99100
.. - Input: position, [velocity, [acceleration]]
100101
.. - Output: velocity
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
.. _position_controllers_userdoc:
22

33
position_controllers
4-
---------------------
4+
=====================
55

66
This is a collection of controllers that work using the "position" joint command interface but may accept different joint-level commands at the controller level, e.g. controlling the position on a certain joint to achieve a set velocity.
77

88
Hardware interface type
9-
^^^^^^^^^^^^^^^^^^^^^^^
9+
-----------------------
1010

1111
These controllers work with joints using the "position" command interface.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
.. _velocity_controllers_userdoc:
22

33
velocity_controllers
4-
---------------------
4+
====================
55

66
This is a collection of controllers that work using the "velocity" joint command interface but may accept different joint-level commands at the controller level, e.g. controlling the velocity on a certain joint to achieve a set position.
77

88
Hardware interface type
9-
^^^^^^^^^^^^^^^^^^^^^^^
9+
-----------------------
1010

1111
These controllers work with joints using the "velocity" command interface.

0 commit comments

Comments
 (0)