Skip to content

Commit 71f4757

Browse files
committed
add some output for knowing whats going on
1 parent 167e8dc commit 71f4757

File tree

4 files changed

+32
-21
lines changed

4 files changed

+32
-21
lines changed

controller_manager/src/controller_manager.cpp

Lines changed: 29 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -453,15 +453,17 @@ void ControllerManager::add_hardware_command_forwarders()
453453
catch (const std::runtime_error & e)
454454
{
455455
RCLCPP_WARN_STREAM(
456-
get_logger(), "ControllerManager: Can't create StatePublishers<"
456+
get_logger(), "ControllerManager: Can't create CommandForwarder<"
457457
<< command_forwarder->command_interface_name() << ">." << e.what());
458458
}
459459
}
460460
}
461461

462462
void ControllerManager::register_sub_controller_manager()
463463
{
464-
RCLCPP_INFO(get_logger(), "SubControllerManager: Trying to register StatePublishers.");
464+
RCLCPP_INFO_STREAM(
465+
get_logger(),
466+
"SubControllerManager:<" << get_namespace() << "/" << get_name() << "> trying to register.");
465467
rclcpp::Client<controller_manager_msgs::srv::RegisterSubControllerManager>::SharedPtr client =
466468
create_client<controller_manager_msgs::srv::RegisterSubControllerManager>(
467469
"/register_sub_controller_manager");
@@ -495,16 +497,18 @@ void ControllerManager::register_sub_controller_manager()
495497
{
496498
if (!rclcpp::ok())
497499
{
498-
RCLCPP_ERROR(
499-
get_logger(),
500-
"SubControllerManager: Interrupted while waiting for central controller managers "
501-
"registration service. Exiting.");
500+
RCLCPP_ERROR_STREAM(
501+
get_logger(), "SubControllerManager:<"
502+
<< get_namespace() << "/" << get_name()
503+
<< ">. Interrupted while waiting for central controller managers "
504+
"registration service. Exiting.");
502505
return;
503506
}
504-
RCLCPP_INFO(
505-
get_logger(),
506-
"SubControllerManager:Central controller managers registration service not available, "
507-
"waiting again...");
507+
RCLCPP_INFO_STREAM(
508+
get_logger(), "SubControllerManager:<"
509+
<< get_namespace() << "/" << get_name()
510+
<< ">. Central controller managers registration service not available, "
511+
"waiting again...");
508512
}
509513

510514
auto result = client->async_send_request(request);
@@ -532,23 +536,30 @@ void ControllerManager::register_sub_controller_manager()
532536
else
533537
{
534538
RCLCPP_WARN_STREAM(
535-
get_logger(), "SubControllerManager: Could not find a CommandForwarder for key["
536-
<< key << "]. No subscription to command state possible.");
539+
get_logger(), "SubControllerManager:<"
540+
<< get_namespace() << "/" << get_name()
541+
<< ">. Could not find a CommandForwarder for key[" << key
542+
<< "]. No subscription to command state possible.");
537543
}
538544
}
539-
RCLCPP_INFO(get_logger(), "SubControllerManager: Successfully registered StatePublishers.");
545+
RCLCPP_INFO_STREAM(
546+
get_logger(), "SubControllerManager:<" << get_namespace() << "/" << get_name()
547+
<< ">. Successfully registered.");
540548
}
541549
else
542550
{
543-
RCLCPP_WARN(
544-
get_logger(),
545-
"SubControllerManager: Registration of StatePublishers failed. Central ControllerManager "
546-
"returned error code.");
551+
RCLCPP_WARN_STREAM(
552+
get_logger(), "SubControllerManager: <"
553+
<< get_namespace() << "/" << get_name()
554+
<< ">. Registration of StatePublishers failed. Central ControllerManager "
555+
"returned error code.");
547556
}
548557
}
549558
else
550559
{
551-
RCLCPP_WARN(get_logger(), "SubControllerManager: Registration of StatePublishers failed.");
560+
RCLCPP_WARN_STREAM(
561+
get_logger(), "SubControllerManager: <" << get_namespace() << "/" << get_name()
562+
<< ">. Registration of StatePublishers failed.");
552563
}
553564
}
554565

hardware_interface/include/hardware_interface/handle.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ class DistributedReadWriteHandle : public ReadWriteHandle
396396
auto msg = std::make_unique<std_msgs::msg::Float64>();
397397
msg->data = value;
398398

399-
RCLCPP_INFO(node_->get_logger(), "DistributedCommandInterface Publishing: '%.7lf'", msg->data);
399+
RCLCPP_WARN(node_->get_logger(), "DistributedCommandInterface Publishing: '%.7lf'", msg->data);
400400
std::flush(std::cout);
401401

402402
command_value_pub_->publish(std::move(msg));

hardware_interface/src/hardware_interface/distributed_control_interface/command_forwarder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ void CommandForwarder::publish_value_on_timer()
9898
{
9999
msg->data = std::numeric_limits<double>::quiet_NaN();
100100
}
101-
RCLCPP_INFO(node_->get_logger(), "Publishing: '%.7lf'", msg->data);
101+
RCLCPP_WARN(node_->get_logger(), "Publishing: '%.7lf'", msg->data);
102102
std::flush(std::cout);
103103

104104
// Put the message into a queue to be processed by the middleware.

hardware_interface/src/hardware_interface/distributed_control_interface/state_publisher.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ void StatePublisher::publish_value_on_timer()
8989
// Make explicit note implicit!!!
9090
msg->data = std::numeric_limits<double>::quiet_NaN();
9191
}
92-
RCLCPP_INFO(node_->get_logger(), "Publishing: '%.7lf'", msg->data);
92+
RCLCPP_WARN(node_->get_logger(), "Publishing: '%.7lf'", msg->data);
9393
std::flush(std::cout);
9494

9595
// Put the message into a queue to be processed by the middleware.

0 commit comments

Comments
 (0)