Skip to content

Commit 765241e

Browse files
Bump version of pre-commit hooks (ros-controls#1556)
* Bump version of pre-commit hooks * Fix codespell and satisfy linter --------- Co-authored-by: christophfroehlich <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>
1 parent 9f1007b commit 765241e

File tree

6 files changed

+16
-12
lines changed

6 files changed

+16
-12
lines changed

.pre-commit-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ repos:
6262

6363
# CPP hooks
6464
- repo: https://github.com/pre-commit/mirrors-clang-format
65-
rev: v18.1.4
65+
rev: v18.1.5
6666
hooks:
6767
- id: clang-format
6868
args: ['-fallback-style=none', '-i']
@@ -125,14 +125,14 @@ repos:
125125
# Spellcheck in comments and docs
126126
# skipping of *.svg files is not working...
127127
- repo: https://github.com/codespell-project/codespell
128-
rev: v2.2.6
128+
rev: v2.3.0
129129
hooks:
130130
- id: codespell
131131
args: ['--write-changes', '--uri-ignore-words-list=ist', '-L manuel']
132132
exclude: CHANGELOG\.rst|\.(svg|pyc|drawio)$
133133

134134
- repo: https://github.com/python-jsonschema/check-jsonschema
135-
rev: 0.28.2
135+
rev: 0.28.4
136136
hooks:
137137
- id: check-github-workflows
138138
args: ["--verbose"]

controller_manager/test/test_spawner_unspawner.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,8 @@ TEST_F(TestLoadController, unload_on_kill)
315315
// Launch spawner with unload on kill
316316
// timeout command will kill it after the specified time with signal SIGINT
317317
std::stringstream ss;
318-
ss << "timeout --signal=INT 5 " << "ros2 run controller_manager spawner "
318+
ss << "timeout --signal=INT 5 "
319+
<< "ros2 run controller_manager spawner "
319320
<< "ctrl_3 -c test_controller_manager -t "
320321
<< std::string(test_controller::TEST_CONTROLLER_CLASS_NAME) << " --unload-on-kill";
321322

hardware_interface/include/hardware_interface/actuator_interface.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ class ActuatorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNod
131131
* \note All starting and stopping interface keys are passed to all components, so the function
132132
* should return return_type::OK by default when given interface keys not relevant for this
133133
* component. \param[in] start_interfaces vector of string identifiers for the command interfaces
134-
* starting. \param[in] stop_interfaces vector of string identifiers for the command interfacs
134+
* starting. \param[in] stop_interfaces vector of string identifiers for the command interfaces
135135
* stopping. \return return_type::OK if the new command interface combination can be prepared, or
136136
* if the interface key is not relevant to this system. Returns return_type::ERROR otherwise.
137137
*/
@@ -150,7 +150,7 @@ class ActuatorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNod
150150
* \note All starting and stopping interface keys are passed to all components, so the function
151151
* should return return_type::OK by default when given interface keys not relevant for this
152152
* component. \param[in] start_interfaces vector of string identifiers for the command interfaces
153-
* starting. \param[in] stop_interfaces vector of string identifiers for the command interfacs
153+
* starting. \param[in] stop_interfaces vector of string identifiers for the command interfaces
154154
* stopping. \return return_type::OK if the new command interface combination can be switched to,
155155
* or if the interface key is not relevant to this system. Returns return_type::ERROR otherwise.
156156
*/

hardware_interface/include/hardware_interface/resource_manager.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ class HARDWARE_INTERFACE_PUBLIC ResourceManager
353353
* \note it is assumed that `prepare_command_mode_switch` is called just before this method
354354
* with the same input arguments.
355355
* \param[in] start_interfaces vector of string identifiers for the command interfaces starting.
356-
* \param[in] stop_interfaces vector of string identifiers for the command interfacs stopping.
356+
* \param[in] stop_interfaces vector of string identifiers for the command interfaces stopping.
357357
* \return true if switch is performed, false if a component rejects switching.
358358
*/
359359
bool perform_command_mode_switch(

hardware_interface/include/hardware_interface/system_interface.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ class SystemInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
132132
* \note All starting and stopping interface keys are passed to all components, so the function
133133
* should return return_type::OK by default when given interface keys not relevant for this
134134
* component. \param[in] start_interfaces vector of string identifiers for the command interfaces
135-
* starting. \param[in] stop_interfaces vector of string identifiers for the command interfacs
135+
* starting. \param[in] stop_interfaces vector of string identifiers for the command interfaces
136136
* stopping. \return return_type::OK if the new command interface combination can be prepared, or
137137
* if the interface key is not relevant to this system. Returns return_type::ERROR otherwise.
138138
*/
@@ -151,7 +151,7 @@ class SystemInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
151151
* \note All starting and stopping interface keys are passed to all components, so the function
152152
* should return return_type::OK by default when given interface keys not relevant for this
153153
* component. \param[in] start_interfaces vector of string identifiers for the command interfaces
154-
* starting. \param[in] stop_interfaces vector of string identifiers for the command interfacs
154+
* starting. \param[in] stop_interfaces vector of string identifiers for the command interfaces
155155
* stopping. \return return_type::OK if the new command interface combination can be switched to,
156156
* or if the interface key is not relevant to this system. Returns return_type::ERROR otherwise.
157157
*/

joint_limits/include/joint_limits/joint_limits.hpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,14 @@ struct SoftJointLimits
128128
{
129129
std::stringstream ss_output;
130130

131-
ss_output << " soft position limits: " << "[" << min_position << ", " << max_position << "]\n";
131+
ss_output << " soft position limits: "
132+
<< "[" << min_position << ", " << max_position << "]\n";
132133

133-
ss_output << " k-position: " << "[" << k_position << "]\n";
134+
ss_output << " k-position: "
135+
<< "[" << k_position << "]\n";
134136

135-
ss_output << " k-velocity: " << "[" << k_velocity << "]\n";
137+
ss_output << " k-velocity: "
138+
<< "[" << k_velocity << "]\n";
136139

137140
return ss_output.str();
138141
}

0 commit comments

Comments
 (0)