Skip to content

Commit d3feeaa

Browse files
committed
add some output for knowing whats going on
1 parent 7d8efe9 commit d3feeaa

File tree

4 files changed

+32
-21
lines changed

4 files changed

+32
-21
lines changed

controller_manager/src/controller_manager.cpp

Lines changed: 29 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -459,15 +459,17 @@ void ControllerManager::add_hardware_command_forwarders()
459459
catch (const std::runtime_error & e)
460460
{
461461
RCLCPP_WARN_STREAM(
462-
get_logger(), "ControllerManager: Can't create StatePublishers<"
462+
get_logger(), "ControllerManager: Can't create CommandForwarder<"
463463
<< command_forwarder->command_interface_name() << ">." << e.what());
464464
}
465465
}
466466
}
467467

468468
void ControllerManager::register_sub_controller_manager()
469469
{
470-
RCLCPP_INFO(get_logger(), "SubControllerManager: Trying to register StatePublishers.");
470+
RCLCPP_INFO_STREAM(
471+
get_logger(),
472+
"SubControllerManager:<" << get_namespace() << "/" << get_name() << "> trying to register.");
471473
rclcpp::Client<controller_manager_msgs::srv::RegisterSubControllerManager>::SharedPtr client =
472474
create_client<controller_manager_msgs::srv::RegisterSubControllerManager>(
473475
"/register_sub_controller_manager");
@@ -501,16 +503,18 @@ void ControllerManager::register_sub_controller_manager()
501503
{
502504
if (!rclcpp::ok())
503505
{
504-
RCLCPP_ERROR(
505-
get_logger(),
506-
"SubControllerManager: Interrupted while waiting for central controller managers "
507-
"registration service. Exiting.");
506+
RCLCPP_ERROR_STREAM(
507+
get_logger(), "SubControllerManager:<"
508+
<< get_namespace() << "/" << get_name()
509+
<< ">. Interrupted while waiting for central controller managers "
510+
"registration service. Exiting.");
508511
return;
509512
}
510-
RCLCPP_INFO(
511-
get_logger(),
512-
"SubControllerManager:Central controller managers registration service not available, "
513-
"waiting again...");
513+
RCLCPP_INFO_STREAM(
514+
get_logger(), "SubControllerManager:<"
515+
<< get_namespace() << "/" << get_name()
516+
<< ">. Central controller managers registration service not available, "
517+
"waiting again...");
514518
}
515519

516520
auto result = client->async_send_request(request);
@@ -538,23 +542,30 @@ void ControllerManager::register_sub_controller_manager()
538542
else
539543
{
540544
RCLCPP_WARN_STREAM(
541-
get_logger(), "SubControllerManager: Could not find a CommandForwarder for key["
542-
<< key << "]. No subscription to command state possible.");
545+
get_logger(), "SubControllerManager:<"
546+
<< get_namespace() << "/" << get_name()
547+
<< ">. Could not find a CommandForwarder for key[" << key
548+
<< "]. No subscription to command state possible.");
543549
}
544550
}
545-
RCLCPP_INFO(get_logger(), "SubControllerManager: Successfully registered StatePublishers.");
551+
RCLCPP_INFO_STREAM(
552+
get_logger(), "SubControllerManager:<" << get_namespace() << "/" << get_name()
553+
<< ">. Successfully registered.");
546554
}
547555
else
548556
{
549-
RCLCPP_WARN(
550-
get_logger(),
551-
"SubControllerManager: Registration of StatePublishers failed. Central ControllerManager "
552-
"returned error code.");
557+
RCLCPP_WARN_STREAM(
558+
get_logger(), "SubControllerManager: <"
559+
<< get_namespace() << "/" << get_name()
560+
<< ">. Registration of StatePublishers failed. Central ControllerManager "
561+
"returned error code.");
553562
}
554563
}
555564
else
556565
{
557-
RCLCPP_WARN(get_logger(), "SubControllerManager: Registration of StatePublishers failed.");
566+
RCLCPP_WARN_STREAM(
567+
get_logger(), "SubControllerManager: <" << get_namespace() << "/" << get_name()
568+
<< ">. Registration of StatePublishers failed.");
558569
}
559570
}
560571

hardware_interface/include/hardware_interface/handle.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ class DistributedReadWriteHandle : public ReadWriteHandle
396396
auto msg = std::make_unique<std_msgs::msg::Float64>();
397397
msg->data = value;
398398

399-
RCLCPP_INFO(node_->get_logger(), "DistributedCommandInterface Publishing: '%.7lf'", msg->data);
399+
RCLCPP_WARN(node_->get_logger(), "DistributedCommandInterface Publishing: '%.7lf'", msg->data);
400400
std::flush(std::cout);
401401

402402
command_value_pub_->publish(std::move(msg));

hardware_interface/src/hardware_interface/distributed_control_interface/command_forwarder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ void CommandForwarder::publish_value_on_timer()
9898
{
9999
msg->data = std::numeric_limits<double>::quiet_NaN();
100100
}
101-
RCLCPP_INFO(node_->get_logger(), "Publishing: '%.7lf'", msg->data);
101+
RCLCPP_WARN(node_->get_logger(), "Publishing: '%.7lf'", msg->data);
102102
std::flush(std::cout);
103103

104104
// Put the message into a queue to be processed by the middleware.

hardware_interface/src/hardware_interface/distributed_control_interface/state_publisher.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ void StatePublisher::publish_value_on_timer()
8989
// Make explicit note implicit!!!
9090
msg->data = std::numeric_limits<double>::quiet_NaN();
9191
}
92-
RCLCPP_INFO(node_->get_logger(), "Publishing: '%.7lf'", msg->data);
92+
RCLCPP_WARN(node_->get_logger(), "Publishing: '%.7lf'", msg->data);
9393
std::flush(std::cout);
9494

9595
// Put the message into a queue to be processed by the middleware.

0 commit comments

Comments
 (0)