Skip to content

Commit d7d534e

Browse files
mamueluthmamueluth
committed
review suggestions
1 parent 884c472 commit d7d534e

8 files changed

+17
-17
lines changed

‎hardware_interface/include/hardware_interface/actuator_interface.hpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,27 +159,27 @@ class ActuatorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNod
159159
// create error signal interface
160160
InterfaceInfo error_interface_info;
161161
error_interface_info.name = hardware_interface::ERROR_SIGNAL_INTERFACE_NAME;
162-
error_interface_info.data_type = "std::array<uint8_t>";
162+
error_interface_info.data_type = "array<uint8_t>[32]";
163163
InterfaceDescription error_interface_descr(info_.name, error_interface_info);
164164
error_signal_ = std::make_shared<StateInterface>(error_interface_descr);
165165
// create error signal report message interface
166166
InterfaceInfo error_msg_interface_info;
167167
error_msg_interface_info.name = hardware_interface::ERROR_SIGNAL_MESSAGE_INTERFACE_NAME;
168-
error_msg_interface_info.data_type = "std::array<std::string>";
168+
error_msg_interface_info.data_type = "array<string>[32]";
169169
InterfaceDescription error_msg_interface_descr(info_.name, error_msg_interface_info);
170170
error_signal_message_ = std::make_shared<StateInterface>(error_msg_interface_descr);
171171

172172
// WARNING
173173
// create warning signal interface
174174
InterfaceInfo warning_interface_info;
175175
warning_interface_info.name = hardware_interface::WARNING_SIGNAL_INTERFACE_NAME;
176-
warning_interface_info.data_type = "std::array<uint8_t>";
176+
warning_interface_info.data_type = "array<int8_t>[32]";
177177
InterfaceDescription warning_interface_descr(info_.name, warning_interface_info);
178178
warning_signal_ = std::make_shared<StateInterface>(warning_interface_descr);
179179
// create warning signal report message interface
180180
InterfaceInfo warning_msg_interface_info;
181181
warning_msg_interface_info.name = hardware_interface::WARNING_SIGNAL_MESSAGE_INTERFACE_NAME;
182-
warning_msg_interface_info.data_type = "std::array<std::string>";
182+
warning_msg_interface_info.data_type = "array<string>[32]";
183183
InterfaceDescription warning_msg_interface_descr(info_.name, warning_msg_interface_info);
184184
warning_signal_message_ = std::make_shared<StateInterface>(warning_msg_interface_descr);
185185
}

‎hardware_interface/include/hardware_interface/sensor_interface.hpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,27 +136,27 @@ class SensorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
136136
// create error signal interface
137137
InterfaceInfo error_interface_info;
138138
error_interface_info.name = hardware_interface::ERROR_SIGNAL_INTERFACE_NAME;
139-
error_interface_info.data_type = "std::array<uint8_t>";
139+
error_interface_info.data_type = "array<uint8_t>[32]";
140140
InterfaceDescription error_interface_descr(info_.name, error_interface_info);
141141
error_signal_ = std::make_shared<StateInterface>(error_interface_descr);
142142
// create error signal report message interface
143143
InterfaceInfo error_msg_interface_info;
144144
error_msg_interface_info.name = hardware_interface::ERROR_SIGNAL_MESSAGE_INTERFACE_NAME;
145-
error_msg_interface_info.data_type = "std::array<std::string>";
145+
error_msg_interface_info.data_type = "array<string>[32]";
146146
InterfaceDescription error_msg_interface_descr(info_.name, error_msg_interface_info);
147147
error_signal_message_ = std::make_shared<StateInterface>(error_msg_interface_descr);
148148

149149
// WARNING
150150
// create warning signal interface
151151
InterfaceInfo warning_interface_info;
152152
warning_interface_info.name = hardware_interface::WARNING_SIGNAL_INTERFACE_NAME;
153-
warning_interface_info.data_type = "std::array<uint8_t>";
153+
warning_interface_info.data_type = "array<int8_t>[32]";
154154
InterfaceDescription warning_interface_descr(info_.name, warning_interface_info);
155155
warning_signal_ = std::make_shared<StateInterface>(warning_interface_descr);
156156
// create warning signal report message interface
157157
InterfaceInfo warning_msg_interface_info;
158158
warning_msg_interface_info.name = hardware_interface::WARNING_SIGNAL_MESSAGE_INTERFACE_NAME;
159-
warning_msg_interface_info.data_type = "std::array<std::string>";
159+
warning_msg_interface_info.data_type = "array<string>[32]";
160160
InterfaceDescription warning_msg_interface_descr(info_.name, warning_msg_interface_info);
161161
warning_signal_message_ = std::make_shared<StateInterface>(warning_msg_interface_descr);
162162
}

‎hardware_interface/include/hardware_interface/system_interface.hpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,27 +179,27 @@ class SystemInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
179179
// create error signal interface
180180
InterfaceInfo error_interface_info;
181181
error_interface_info.name = hardware_interface::ERROR_SIGNAL_INTERFACE_NAME;
182-
error_interface_info.data_type = "std::array<uint8_t>";
182+
error_interface_info.data_type = "array<uint8_t>[32]";
183183
InterfaceDescription error_interface_descr(info_.name, error_interface_info);
184184
error_signal_ = std::make_shared<StateInterface>(error_interface_descr);
185185
// create error signal report message interface
186186
InterfaceInfo error_msg_interface_info;
187187
error_msg_interface_info.name = hardware_interface::ERROR_SIGNAL_MESSAGE_INTERFACE_NAME;
188-
error_msg_interface_info.data_type = "std::array<std::string>";
188+
error_msg_interface_info.data_type = "array<string>[32]";
189189
InterfaceDescription error_msg_interface_descr(info_.name, error_msg_interface_info);
190190
error_signal_message_ = std::make_shared<StateInterface>(error_msg_interface_descr);
191191

192192
// WARNING
193193
// create warning signal interface
194194
InterfaceInfo warning_interface_info;
195195
warning_interface_info.name = hardware_interface::WARNING_SIGNAL_INTERFACE_NAME;
196-
warning_interface_info.data_type = "std::array<uint8_t>";
196+
warning_interface_info.data_type = "array<int8_t>[32]";
197197
InterfaceDescription warning_interface_descr(info_.name, warning_interface_info);
198198
warning_signal_ = std::make_shared<StateInterface>(warning_interface_descr);
199199
// create warning signal report message interface
200200
InterfaceInfo warning_msg_interface_info;
201201
warning_msg_interface_info.name = hardware_interface::WARNING_SIGNAL_MESSAGE_INTERFACE_NAME;
202-
warning_msg_interface_info.data_type = "std::array<std::string>";
202+
warning_msg_interface_info.data_type = "array<string>[32]";
203203
InterfaceDescription warning_msg_interface_descr(info_.name, warning_msg_interface_info);
204204
warning_signal_message_ = std::make_shared<StateInterface>(warning_msg_interface_descr);
205205
}

‎hardware_interface/include/hardware_interface/types/hardware_interface_emergency_stop_signal.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2017 Open Source Robotics Foundation, Inc.
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

‎hardware_interface/include/hardware_interface/types/hardware_interface_error_signals.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2017 Open Source Robotics Foundation, Inc.
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

‎hardware_interface/include/hardware_interface/types/hardware_interface_warning_signals.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2017 Open Source Robotics Foundation, Inc.
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

‎hardware_interface/test/test_component_interfaces_custom_export.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2020 ros2_control development team
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

‎hardware_interface/test/test_error_warning_codes.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2020 ros2_control development team
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)