Skip to content

Commit e260049

Browse files
Fix dependencies for source build (ros-controls#1533)
* Don't use std::system call inside test * Give launch_ros as explicit dependency * Test the source build on this branch * Revert "Test the source build on this branch" This reverts commit 9884b11.
1 parent ac5dfb4 commit e260049

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

controller_interface/test/test_controller_interface.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ TEST(TestableControllerInterface, setting_update_rate_in_configure)
8888
ASSERT_EQ(controller.get_update_rate(), 2812u);
8989

9090
// Test updating of update_rate parameter
91-
EXPECT_EQ(std::system("ros2 param set /testable_controller_interface update_rate 623"), 0);
91+
auto res = controller.get_node()->set_parameter(rclcpp::Parameter("update_rate", 623));
92+
EXPECT_EQ(res.successful, true);
9293
// Keep the same update rate until transition from 'UNCONFIGURED' TO 'INACTIVE' does not happen
9394
controller.configure(); // No transition so the update rate should stay intact
9495
ASSERT_NE(controller.get_update_rate(), 623u);

joint_limits/package.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
<depend>rclcpp_lifecycle</depend>
2121
<depend>urdf</depend>
2222

23+
<test_depend>launch_ros</test_depend>
2324
<test_depend>launch_testing_ament_cmake</test_depend>
2425
<test_depend>ament_cmake_gtest</test_depend>
2526

0 commit comments

Comments
 (0)