Skip to content

Commit ee6ae9e

Browse files
mamueluthmamueluth
committed
review suggestions
1 parent a7996c3 commit ee6ae9e

8 files changed

+17
-17
lines changed

‎hardware_interface/include/hardware_interface/actuator_interface.hpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,27 +160,27 @@ class ActuatorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNod
160160
// create error signal interface
161161
InterfaceInfo error_interface_info;
162162
error_interface_info.name = hardware_interface::ERROR_SIGNAL_INTERFACE_NAME;
163-
error_interface_info.data_type = "std::array<uint8_t>";
163+
error_interface_info.data_type = "array<uint8_t>[32]";
164164
InterfaceDescription error_interface_descr(info_.name, error_interface_info);
165165
error_signal_ = std::make_shared<StateInterface>(error_interface_descr);
166166
// create error signal report message interface
167167
InterfaceInfo error_msg_interface_info;
168168
error_msg_interface_info.name = hardware_interface::ERROR_SIGNAL_MESSAGE_INTERFACE_NAME;
169-
error_msg_interface_info.data_type = "std::array<std::string>";
169+
error_msg_interface_info.data_type = "array<string>[32]";
170170
InterfaceDescription error_msg_interface_descr(info_.name, error_msg_interface_info);
171171
error_signal_message_ = std::make_shared<StateInterface>(error_msg_interface_descr);
172172

173173
// WARNING
174174
// create warning signal interface
175175
InterfaceInfo warning_interface_info;
176176
warning_interface_info.name = hardware_interface::WARNING_SIGNAL_INTERFACE_NAME;
177-
warning_interface_info.data_type = "std::array<uint8_t>";
177+
warning_interface_info.data_type = "array<int8_t>[32]";
178178
InterfaceDescription warning_interface_descr(info_.name, warning_interface_info);
179179
warning_signal_ = std::make_shared<StateInterface>(warning_interface_descr);
180180
// create warning signal report message interface
181181
InterfaceInfo warning_msg_interface_info;
182182
warning_msg_interface_info.name = hardware_interface::WARNING_SIGNAL_MESSAGE_INTERFACE_NAME;
183-
warning_msg_interface_info.data_type = "std::array<std::string>";
183+
warning_msg_interface_info.data_type = "array<string>[32]";
184184
InterfaceDescription warning_msg_interface_descr(info_.name, warning_msg_interface_info);
185185
warning_signal_message_ = std::make_shared<StateInterface>(warning_msg_interface_descr);
186186
}

‎hardware_interface/include/hardware_interface/sensor_interface.hpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,27 +137,27 @@ class SensorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
137137
// create error signal interface
138138
InterfaceInfo error_interface_info;
139139
error_interface_info.name = hardware_interface::ERROR_SIGNAL_INTERFACE_NAME;
140-
error_interface_info.data_type = "std::array<uint8_t>";
140+
error_interface_info.data_type = "array<uint8_t>[32]";
141141
InterfaceDescription error_interface_descr(info_.name, error_interface_info);
142142
error_signal_ = std::make_shared<StateInterface>(error_interface_descr);
143143
// create error signal report message interface
144144
InterfaceInfo error_msg_interface_info;
145145
error_msg_interface_info.name = hardware_interface::ERROR_SIGNAL_MESSAGE_INTERFACE_NAME;
146-
error_msg_interface_info.data_type = "std::array<std::string>";
146+
error_msg_interface_info.data_type = "array<string>[32]";
147147
InterfaceDescription error_msg_interface_descr(info_.name, error_msg_interface_info);
148148
error_signal_message_ = std::make_shared<StateInterface>(error_msg_interface_descr);
149149

150150
// WARNING
151151
// create warning signal interface
152152
InterfaceInfo warning_interface_info;
153153
warning_interface_info.name = hardware_interface::WARNING_SIGNAL_INTERFACE_NAME;
154-
warning_interface_info.data_type = "std::array<uint8_t>";
154+
warning_interface_info.data_type = "array<int8_t>[32]";
155155
InterfaceDescription warning_interface_descr(info_.name, warning_interface_info);
156156
warning_signal_ = std::make_shared<StateInterface>(warning_interface_descr);
157157
// create warning signal report message interface
158158
InterfaceInfo warning_msg_interface_info;
159159
warning_msg_interface_info.name = hardware_interface::WARNING_SIGNAL_MESSAGE_INTERFACE_NAME;
160-
warning_msg_interface_info.data_type = "std::array<std::string>";
160+
warning_msg_interface_info.data_type = "array<string>[32]";
161161
InterfaceDescription warning_msg_interface_descr(info_.name, warning_msg_interface_info);
162162
warning_signal_message_ = std::make_shared<StateInterface>(warning_msg_interface_descr);
163163
}

‎hardware_interface/include/hardware_interface/system_interface.hpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,27 +180,27 @@ class SystemInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
180180
// create error signal interface
181181
InterfaceInfo error_interface_info;
182182
error_interface_info.name = hardware_interface::ERROR_SIGNAL_INTERFACE_NAME;
183-
error_interface_info.data_type = "std::array<uint8_t>";
183+
error_interface_info.data_type = "array<uint8_t>[32]";
184184
InterfaceDescription error_interface_descr(info_.name, error_interface_info);
185185
error_signal_ = std::make_shared<StateInterface>(error_interface_descr);
186186
// create error signal report message interface
187187
InterfaceInfo error_msg_interface_info;
188188
error_msg_interface_info.name = hardware_interface::ERROR_SIGNAL_MESSAGE_INTERFACE_NAME;
189-
error_msg_interface_info.data_type = "std::array<std::string>";
189+
error_msg_interface_info.data_type = "array<string>[32]";
190190
InterfaceDescription error_msg_interface_descr(info_.name, error_msg_interface_info);
191191
error_signal_message_ = std::make_shared<StateInterface>(error_msg_interface_descr);
192192

193193
// WARNING
194194
// create warning signal interface
195195
InterfaceInfo warning_interface_info;
196196
warning_interface_info.name = hardware_interface::WARNING_SIGNAL_INTERFACE_NAME;
197-
warning_interface_info.data_type = "std::array<uint8_t>";
197+
warning_interface_info.data_type = "array<int8_t>[32]";
198198
InterfaceDescription warning_interface_descr(info_.name, warning_interface_info);
199199
warning_signal_ = std::make_shared<StateInterface>(warning_interface_descr);
200200
// create warning signal report message interface
201201
InterfaceInfo warning_msg_interface_info;
202202
warning_msg_interface_info.name = hardware_interface::WARNING_SIGNAL_MESSAGE_INTERFACE_NAME;
203-
warning_msg_interface_info.data_type = "std::array<std::string>";
203+
warning_msg_interface_info.data_type = "array<string>[32]";
204204
InterfaceDescription warning_msg_interface_descr(info_.name, warning_msg_interface_info);
205205
warning_signal_message_ = std::make_shared<StateInterface>(warning_msg_interface_descr);
206206
}

‎hardware_interface/include/hardware_interface/types/hardware_interface_emergency_stop_signal.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2017 Open Source Robotics Foundation, Inc.
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

‎hardware_interface/include/hardware_interface/types/hardware_interface_error_signals.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2017 Open Source Robotics Foundation, Inc.
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

‎hardware_interface/include/hardware_interface/types/hardware_interface_warning_signals.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2017 Open Source Robotics Foundation, Inc.
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

‎hardware_interface/test/test_component_interfaces_custom_export.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2020 ros2_control development team
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

‎hardware_interface/test/test_error_warning_codes.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2020 ros2_control development team
1+
// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)