[TASK] make CI happy with TYPO3 13.4.5

Datahandlers log method changed method annotations
Context Menu Accessibility has been improved

Author: achimfritz

Classes/Hooks/Datahandler/CommandMapBeforeStartHook.php

@@ -18,6 +18,7 @@
 use B13\Container\Domain\Service\ContainerService;
 use B13\Container\Tca\Registry;
 use TYPO3\CMS\Core\DataHandling\DataHandler;
+use TYPO3\CMS\Core\Information\Typo3Version;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 class CommandMapBeforeStartHook
@@ -301,14 +302,20 @@ protected function dataFromContainerIdColPos(array $data): array
 
     protected function logAndUnsetCmd(int $id, string $cmd, string $message, DataHandler $dataHandler): void
     {
+        $recpid = null;
+        $details = null;
+        if ((GeneralUtility::makeInstance(Typo3Version::class))->getMajorVersion() < 13) {
+            $recpid = 0;
+            $details = 28;
+        }
         $dataHandler->log(
             'tt_content',
             $id,
             1,
-            0,
+            $recpid,
             1,
             $cmd . ' ' . $message,
-            28
+            $details
         );
         unset($dataHandler->cmdmap['tt_content'][$id][$cmd]);
         if (!empty($dataHandler->cmdmap['tt_content'][$id])) {

Tests/Acceptance/Backend/ContentDefenderCest.php

@@ -106,18 +106,29 @@ public function doNotSeeNotAllowedContentElementsInNewContentElementWizardTrigge
             $I->waitForElement('#element-tt_content-800 [data-contextmenu-uid="810"]');
             $I->click('#element-tt_content-800 [data-contextmenu-uid="810"]');
         }
-        $I->waitForText('More options...');
-        if ($typo3Version->getMajorVersion() < 12) {
-            $I->click('.list-group-item-submenu');
-        } else {
-            $I->click('.context-menu-item-submenu');
-        }
-        $I->waitForText('\'Create New\' wizard');
-        if ($typo3Version->getMajorVersion() < 12) {
-            $I->click('#contentMenu1 [data-callback-action="newContentWizard"]');
-        } else {
-            $I->click('#contentMenu1');
+        switch ($typo3Version->getMajorVersion()) {
+            case 11:
+                $I->waitForText('More options...');
+                $I->click('.list-group-item-submenu');
+                $I->waitForText('\'Create New\' wizard');
+                $I->click('#contentMenu1 [data-callback-action="newContentWizard"]');
+                break;
+            case 12:
+                $I->waitForText('More options...');
+                $I->click('.context-menu-item-submenu');
+                $I->waitForText('\'Create New\' wizard');
+                $I->click('#contentMenu1');
+                break;
+            default:
+                // v13
+                $I->switchToMainFrame();
+                $I->waitForElementVisible('typo3-backend-context-menu button[data-contextmenu-id="root_more"]', 5);
+                $I->click('button[data-contextmenu-id="root_more"]', 'typo3-backend-context-menu');
+                $I->waitForElementVisible('typo3-backend-context-menu button[data-contextmenu-id="root_more_newWizard"]', 5);
+                $I->click('button[data-contextmenu-id="root_more_newWizard"]', 'typo3-backend-context-menu');
+                break;
         }
+
         $I->switchToIFrame();
         $I->waitForElement('.modal-dialog');
         if (GeneralUtility::makeInstance(Typo3Version::class)->getMajorVersion() > 12) {

Tests/README.md

@@ -20,7 +20,7 @@
     cp Build/LocalConfiguration.php .Build/Web/typo3conf/
     .Build/bin/typo3 extension:setup
     # run php webserver and chromedriver
-    php -S 0.0.0.0:8888 -t .Build/Web/ &
+    php -S 0.0.0.0:8080 -t .Build/Web/ &
     chromedriver --url-base=/wd/hub  --port=9515 &
     # create database with "_at" postfix
     mysql -e 'CREATE DATABASE IF NOT EXISTS foox_at;'