Skip to content

Commit 2f91030

Browse files
bnfachimfritz
authored andcommitted
[BUGFIX] Replace undefined variable with locallang key
The title of the "edit column" button in the page module is now using the correct locallang key instead of an undefined variable, which fixes a11y of this button and helps mouse users. The same fix has also been applied to TYPO3 some years ago, and has been backported back to TYPO3 v11: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77026 Fixes: #637
1 parent 7ff2844 commit 2f91030

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Resources/Private/Partials/PageLayout/Grid/ColumnHeader.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<f:then>
44
<div class="t3-page-column-header-icons">
55
<f:if condition="{allowEditContent} && {column.editUrl}">
6-
<a href="{column.editUrl}" title="{column.editLinkTitle}"><core:icon identifier="actions-document-open" /></a>
6+
<a href="{column.editUrl}" title="{f:translate(key: 'LLL:EXT:backend/Resources/Private/Language/locallang_layout.xlf:editColumn')}"><core:icon identifier="actions-document-open" /></a>
77
</f:if>
88
</div>
99
{column.title}

Resources/Private/Partials11/PageLayout/Grid/Column.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<f:then>
1515
<div class="t3-page-column-header-icons">
1616
<f:if condition="{allowEditContent} && {column.editUrl}">
17-
<a href="{column.editUrl}" title="{column.editLinkTitle}"><core:icon identifier="actions-document-open" /></a>
17+
<a href="{column.editUrl}" title="{f:translate(key: 'LLL:EXT:backend/Resources/Private/Language/locallang_layout.xlf:editColumn')}"><core:icon identifier="actions-document-open" /></a>
1818
</f:if>
1919
</div>
2020
{column.title}

Resources/Private/Partials12/PageLayout/Grid/ColumnHeader.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<f:then>
44
<div class="t3-page-column-header-icons">
55
<f:if condition="{allowEditContent} && {column.editUrl}">
6-
<a href="{column.editUrl}" title="{column.editLinkTitle}"><core:icon identifier="actions-document-open" /></a>
6+
<a href="{column.editUrl}" title="{f:translate(key: 'LLL:EXT:backend/Resources/Private/Language/locallang_layout.xlf:editColumn')}"><core:icon identifier="actions-document-open" /></a>
77
</f:if>
88
</div>
99
{column.title}

0 commit comments

Comments
 (0)