[BUGFIX] use addRules instead setRules for php-cs-fixer

achimfritz · achimfritz · commit 9a0a756aecc1 · 2025-08-13T15:51:12.000+02:00
diff --git a/Build/php-cs-fixer.php b/Build/php-cs-fixer.php
@@ -2,7 +2,7 @@
 
 $config = \TYPO3\CodingStandards\CsFixerConfig::create();
 $config->getFinder()->exclude(['var'])->in(__DIR__ . '/..');
-$config->setRules([
+$config->addRules([
     'nullable_type_declaration' => [
         'syntax' => 'question_mark',
     ],
diff --git a/Build/phpunit/FunctionalTestsBootstrap.php b/Build/phpunit/FunctionalTestsBootstrap.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * This file is part of the TYPO3 CMS project.
  *
diff --git a/Build/phpunit/UnitTestsBootstrap.php b/Build/phpunit/UnitTestsBootstrap.php
@@ -1,4 +1,5 @@
 <?php
+
 /*
  * This file is part of the TYPO3 CMS project.
  *
diff --git a/Build/sites/autogenerated-2-c81e728d9d4c2f636f067f89cc14862c/config.yaml b/Build/sites/autogenerated-2-c81e728d9d4c2f636f067f89cc14862c/config.yaml
@@ -0,0 +1,13 @@
+base: autogenerated-2
+errorHandling: {  }
+languages:
+  -
+    title: English
+    enabled: true
+    languageId: 0
+    base: /
+    locale: en_US.UTF-8
+    navigationTitle: English
+    flag: us
+rootPageId: 2
+routes: {  }
diff --git a/Classes/Backend/Preview/ContainerPreviewRenderer.php b/Classes/Backend/Preview/ContainerPreviewRenderer.php
@@ -12,7 +12,6 @@
  * of the License, or any later version.
  */
 
-
 use TYPO3\CMS\Backend\Preview\StandardContentPreviewRenderer;
 use TYPO3\CMS\Backend\View\BackendLayout\Grid\GridColumnItem;
 use TYPO3\CMS\Core\Cache\Frontend\FrontendInterface;
@@ -24,7 +23,8 @@ class ContainerPreviewRenderer extends StandardContentPreviewRenderer
     protected GridRenderer $gridRenderer;
     protected FrontendInterface $runtimeCache;
 
-    public function __construct(GridRenderer $gridRenderer, FrontendInterface $runtimeCache) {
+    public function __construct(GridRenderer $gridRenderer, FrontendInterface $runtimeCache)
+    {
         $this->gridRenderer = $gridRenderer;
         $this->runtimeCache = $runtimeCache;
     }
diff --git a/Classes/Backend/Preview/GridRenderer.php b/Classes/Backend/Preview/GridRenderer.php
@@ -18,7 +18,6 @@
 use B13\Container\Domain\Factory\Exception;
 use B13\Container\Domain\Factory\PageView\Backend\ContainerFactory;
 use B13\Container\Events\BeforeContainerPreviewIsRenderedEvent;
-use B13\Container\Events\BeforeContainerPreviewIsRenderedEventV12;
 use B13\Container\Tca\Registry;
 use Psr\EventDispatcher\EventDispatcherInterface;
 use TYPO3\CMS\Backend\Utility\BackendUtility;
@@ -36,7 +35,6 @@
 
 class GridRenderer
 {
-
     protected Registry $tcaRegistry;
     protected ContainerFactory $containerFactory;
     protected NewContentUrlBuilder $newContentUrlBuilder;
diff --git a/Classes/ContentDefender/Xclasses/CommandMapHook.php b/Classes/ContentDefender/Xclasses/CommandMapHook.php
@@ -40,8 +40,7 @@ public function __construct(
 
     public function processCmdmap_beforeStart(DataHandler $dataHandler): void
     {
-        if (isset($dataHandler->cmdmap['pages']))
-        {
+        if (isset($dataHandler->cmdmap['pages'])) {
             $this->containerColumnConfigurationService->startCmdMap();
         }
         if (!empty($dataHandler->cmdmap['tt_content'])) {
diff --git a/Classes/ContentDefender/Xclasses/DatamapHook.php b/Classes/ContentDefender/Xclasses/DatamapHook.php
@@ -13,7 +13,6 @@
  */
 
 use B13\Container\ContentDefender\ContainerColumnConfigurationService;
-use B13\Container\Hooks\Datahandler\Database;
 use B13\Container\Hooks\Datahandler\DatahandlerProcess;
 use IchHabRecht\ContentDefender\Hooks\DatamapDataHandlerHook;
 use IchHabRecht\ContentDefender\Repository\ContentRepository;
@@ -29,7 +28,6 @@ class DatamapHook extends DatamapDataHandlerHook
      */
     protected $containerColumnConfigurationService;
 
-
     public function __construct(
         ?ContentRepository $contentRepository = null,
         ?ContainerColumnConfigurationService $containerColumnConfigurationService = null
diff --git a/Classes/DataProcessing/ContainerProcessor.php b/Classes/DataProcessing/ContainerProcessor.php
@@ -24,7 +24,6 @@
 
 class ContainerProcessor implements DataProcessorInterface
 {
-
     /**
      * @var ContentDataProcessor
      */
diff --git a/Classes/Domain/Factory/FrontendContainerFactory.php b/Classes/Domain/Factory/FrontendContainerFactory.php
@@ -21,7 +21,6 @@
 
 class FrontendContainerFactory implements SingletonInterface
 {
-
     protected Registry $tcaRegistry;
 
     public function __construct(Registry $tcaRegistry)
diff --git a/Classes/Events/BeforeContainerPreviewIsRenderedEvent.php b/Classes/Events/BeforeContainerPreviewIsRenderedEvent.php
@@ -24,7 +24,7 @@ final class BeforeContainerPreviewIsRenderedEvent
     protected StandaloneView $view;
 
     protected Grid $grid;
-    
+
     protected GridColumnItem $item;
 
     public function __construct(Container $container, StandaloneView $view, Grid $grid, GridColumnItem $item)
diff --git a/Classes/Hooks/Datahandler/CommandMapPostProcessingHook.php b/Classes/Hooks/Datahandler/CommandMapPostProcessingHook.php
@@ -65,7 +65,7 @@ protected function copyToLanguageChildren(int $uid, int $language, string $comma
                     'target' => $pos,
                     'action' => 'paste',
                     'update' => [],
-                ]
+                ],
             ]]];
             $localDataHandler = GeneralUtility::makeInstance(DataHandler::class);
             $localDataHandler->enableLogging = $dataHandler->enableLogging;
@@ -88,8 +88,8 @@ protected function copyToLanguageChildren(int $uid, int $language, string $comma
                         'action' => 'paste',
                         'update' => [
                             'tx_container_parent' => $containerId,
-                        ]
-                    ]
+                        ],
+                    ],
                 ]]];
                 $localDataHandler = GeneralUtility::makeInstance(DataHandler::class);
                 $localDataHandler->enableLogging = $dataHandler->enableLogging;
diff --git a/Classes/Hooks/Datahandler/DatamapPreProcessFieldArrayHook.php b/Classes/Hooks/Datahandler/DatamapPreProcessFieldArrayHook.php
@@ -17,7 +17,6 @@
 use B13\Container\Domain\Service\ContainerService;
 use B13\Container\Tca\Registry;
 use TYPO3\CMS\Core\DataHandling\DataHandler;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\MathUtility;
 
 class DatamapPreProcessFieldArrayHook
diff --git a/Classes/Listener/PageContentPreviewRendering.php b/Classes/Listener/PageContentPreviewRendering.php
@@ -34,7 +34,7 @@ public function __invoke(PageContentPreviewRenderingEvent $event): void
         }
 
         $record = $event->getRecord();
-        if (!$this->tcaRegistry->isContainerElement( (string) $record['CType'])) {
+        if (!$this->tcaRegistry->isContainerElement((string)$record['CType'])) {
             return;
         }
         $record['tx_container_grid'] = $this->gridRenderer->renderGrid($record, $event->getPageLayoutContext());
diff --git a/Classes/Tca/Registry.php b/Classes/Tca/Registry.php
@@ -67,7 +67,6 @@ public function configureContainer(ContainerConfiguration $containerConfiguratio
         }
         $GLOBALS['TCA']['tt_content']['types'][$containerConfiguration->getCType()]['previewRenderer'] = \B13\Container\Backend\Preview\ContainerPreviewRenderer::class;
 
-
         if ((GeneralUtility::makeInstance(Typo3Version::class))->getMajorVersion() >= 13) {
             if (!isset($GLOBALS['TCA']['tt_content']['types'][$containerConfiguration->getCType()]['creationOptions'])) {
                 $GLOBALS['TCA']['tt_content']['types'][$containerConfiguration->getCType()]['creationOptions'] = [];
diff --git a/Tests/Acceptance/Backend/ContentDefenderCest.php b/Tests/Acceptance/Backend/ContentDefenderCest.php
@@ -277,7 +277,6 @@ public function canCreateNewChildInContainerIfMaxitemsIsReachedInOtherContainer(
         $I->seeElement('#EditDocumentController');
     }
 
-
     /**
      * @group content_defender
      */
@@ -302,5 +301,4 @@ public function seeEditDocumentWhenAddingChildrenToColposWhereOnlyHeaderIsAllowe
         $I->see('header', 'select');
         $I->dontSee('Images Only', 'select');
     }
-
 }
diff --git a/Tests/Acceptance/Support/Extension/BackendContainerEnvironment.php b/Tests/Acceptance/Support/Extension/BackendContainerEnvironment.php
@@ -12,9 +12,6 @@
  * of the License, or any later version.
  */
 
-use Codeception\Event\SuiteEvent;
-use TYPO3\CMS\Core\Information\Typo3Version;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\TestingFramework\Core\Acceptance\Extension\BackendEnvironment;
 
 class BackendContainerEnvironment extends BackendEnvironment
diff --git a/Tests/Functional/Datahandler/ContentDefender/AbstractContentDefender.php b/Tests/Functional/Datahandler/ContentDefender/AbstractContentDefender.php
@@ -31,4 +31,4 @@ protected function setUp(): void
             $GLOBALS['TYPO3_REQUEST'] = (new ServerRequest())->withAttribute('applicationType', SystemEnvironmentBuilder::REQUESTTYPE_BE);
         }
     }
-}
+}
diff --git a/Tests/Functional/Frontend/DefaultLanguageTest.php b/Tests/Functional/Frontend/DefaultLanguageTest.php
@@ -82,7 +82,6 @@ public function canRenderContainerFromOtherPage(): void
         $body = (string)$response->getBody();
         $body = $this->prepareContent($body);
         self::assertStringContainsString('<h2>left side (201)</h2><div class="left-children"><h6 class="left-children">child</h6><div id="c2"', $body);
-
     }
 
     /**
diff --git a/Tests/Unit/DataProcessing/ContainerProcessorTest.php b/Tests/Unit/DataProcessing/ContainerProcessorTest.php
@@ -31,12 +31,14 @@ public function configuredContentIdIsUsed(): void
     {
         $processorConfiguration = ['contentId' => 1];
         $contentObjectRenderer = $this->getMockBuilder(ContentObjectRenderer::class)->disableOriginalConstructor()->getMock();
-        $contentObjectRenderer->expects($this->never())->method('stdWrap');
+        $contentObjectRenderer->expects(self::never())->method('stdWrap');
         $context = $this->getMockBuilder(Context::class)->getMock();
         $contentDataProcessor = $this->getMockBuilder(ContentDataProcessor::class)->disableOriginalConstructor()->getMock();
         $frontendContainerFactory = $this->getMockBuilder(FrontendContainerFactory::class)->disableOriginalConstructor()->getMock();
-        $frontendContainerFactory->expects($this->once())->method('buildContainer')->with(
-            $contentObjectRenderer, $context, 1
+        $frontendContainerFactory->expects(self::once())->method('buildContainer')->with(
+            $contentObjectRenderer,
+            $context,
+            1
         )->willReturn(new Container([], []));
         $containerProcessor = new ContainerProcessor($contentDataProcessor, $context, $frontendContainerFactory);
         $containerProcessor->process($contentObjectRenderer, [], $processorConfiguration, []);
@@ -49,12 +51,14 @@ public function configuredContentIdStdWrapIsUsed(): void
     {
         $processorConfiguration = ['contentId' => 1, 'contentId.' => 'foo'];
         $contentObjectRenderer = $this->getMockBuilder(ContentObjectRenderer::class)->disableOriginalConstructor()->getMock();
-        $contentObjectRenderer->expects($this->once())->method('stdWrap')->with(1, 'foo')->willReturn(2);
+        $contentObjectRenderer->expects(self::once())->method('stdWrap')->with(1, 'foo')->willReturn(2);
         $context = $this->getMockBuilder(Context::class)->getMock();
         $contentDataProcessor = $this->getMockBuilder(ContentDataProcessor::class)->disableOriginalConstructor()->getMock();
         $frontendContainerFactory = $this->getMockBuilder(FrontendContainerFactory::class)->disableOriginalConstructor()->getMock();
-        $frontendContainerFactory->expects($this->once())->method('buildContainer')->with(
-            $contentObjectRenderer, $context, 2
+        $frontendContainerFactory->expects(self::once())->method('buildContainer')->with(
+            $contentObjectRenderer,
+            $context,
+            2
         )->willReturn(new Container([], []));
         $containerProcessor = new ContainerProcessor($contentDataProcessor, $context, $frontendContainerFactory);
         $containerProcessor->process($contentObjectRenderer, [], $processorConfiguration, []);
@@ -67,12 +71,14 @@ public function canBeCalledWithoutContentId(): void
     {
         $processorConfiguration = ['contentId.' => 'foo'];
         $contentObjectRenderer = $this->getMockBuilder(ContentObjectRenderer::class)->disableOriginalConstructor()->getMock();
-        $contentObjectRenderer->expects($this->once())->method('stdWrap')->with('', 'foo')->willReturn(2);
+        $contentObjectRenderer->expects(self::once())->method('stdWrap')->with('', 'foo')->willReturn(2);
         $context = $this->getMockBuilder(Context::class)->getMock();
         $contentDataProcessor = $this->getMockBuilder(ContentDataProcessor::class)->disableOriginalConstructor()->getMock();
         $frontendContainerFactory = $this->getMockBuilder(FrontendContainerFactory::class)->disableOriginalConstructor()->getMock();
-        $frontendContainerFactory->expects($this->once())->method('buildContainer')->with(
-            $contentObjectRenderer, $context, 2
+        $frontendContainerFactory->expects(self::once())->method('buildContainer')->with(
+            $contentObjectRenderer,
+            $context,
+            2
         )->willReturn(new Container([], []));
         $containerProcessor = new ContainerProcessor($contentDataProcessor, $context, $frontendContainerFactory);
         $containerProcessor->process($contentObjectRenderer, [], $processorConfiguration, []);
@@ -85,15 +91,16 @@ public function nullIsUsedForFactoryIfNoContentIdIsGiven(): void
     {
         $processorConfiguration = [];
         $contentObjectRenderer = $this->getMockBuilder(ContentObjectRenderer::class)->disableOriginalConstructor()->getMock();
-        $contentObjectRenderer->expects($this->never())->method('stdWrap');
+        $contentObjectRenderer->expects(self::never())->method('stdWrap');
         $context = $this->getMockBuilder(Context::class)->getMock();
         $contentDataProcessor = $this->getMockBuilder(ContentDataProcessor::class)->disableOriginalConstructor()->getMock();
         $frontendContainerFactory = $this->getMockBuilder(FrontendContainerFactory::class)->disableOriginalConstructor()->getMock();
-        $frontendContainerFactory->expects($this->once())->method('buildContainer')->with(
-            $contentObjectRenderer, $context, null
+        $frontendContainerFactory->expects(self::once())->method('buildContainer')->with(
+            $contentObjectRenderer,
+            $context,
+            null
         )->willReturn(new Container([], []));
         $containerProcessor = new ContainerProcessor($contentDataProcessor, $context, $frontendContainerFactory);
         $containerProcessor->process($contentObjectRenderer, [], $processorConfiguration, []);
     }
-
 }
diff --git a/ext_localconf.php b/ext_localconf.php
@@ -60,7 +60,7 @@
             = B13\Container\Updates\ContainerDeleteChildrenWithWrongPid::class;
     }
 
-    if(TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(TYPO3\CMS\Core\Information\Typo3Version::class)->getMajorVersion() < 12) {
+    if (TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(TYPO3\CMS\Core\Information\Typo3Version::class)->getMajorVersion() < 12) {
         $GLOBALS['TYPO3_CONF_VARS']['BE']['ContextMenu']['ItemProviders'][1729106358] = \B13\Container\Backend\ContextMenu\RecordContextMenuItemProvider::class;
     }
 });

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`<?php`
	`2`	`+`
`2`	`3`	`/*`
`3`	`4`	`* This file is part of the TYPO3 CMS project.`
`4`	`5`	`*`
Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,7 @@ public function __construct(`
`40`	`40`
`41`	`41`	`public function processCmdmap_beforeStart(DataHandler $dataHandler): void`
`42`	`42`	`{`
`43`		`- if (isset($dataHandler->cmdmap['pages']))`
`44`		`- {`
	`43`	`+ if (isset($dataHandler->cmdmap['pages'])) {`
`45`	`44`	`$this->containerColumnConfigurationService->startCmdMap();`
`46`	`45`	`}`
`47`	`46`	`if (!empty($dataHandler->cmdmap['tt_content'])) {`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`
`25`	`25`	`class ContainerProcessor implements DataProcessorInterface`
`26`	`26`	`{`
`27`		`-`
`28`	`27`	`/**`
`29`	`28`	`* @var ContentDataProcessor`
`30`	`29`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@`
`21`	`21`
`22`	`22`	`class FrontendContainerFactory implements SingletonInterface`
`23`	`23`	`{`
`24`		`-`
`25`	`24`	`protected Registry $tcaRegistry;`
`26`	`25`
`27`	`26`	`public function __construct(Registry $tcaRegistry)`