Skip to content

Commit ce30c46

Browse files
committed
[TASK] Add PHP 7.2 compatability
The lint task not ignores files in "Resources/Private/CodeTemplates/"
1 parent 1a70405 commit ce30c46

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

Build/testing-docker/docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ services:
285285
set -x
286286
fi
287287
php -v | grep '^PHP';
288-
find . -name \\*.php ! -path "./.Build/\\*" -print0 | xargs -0 -n1 -P4 php -dxdebug.mode=off -l >/dev/null
288+
find . -name \\*.php ! -path "./.Build/\\*" ! -path "./Resources/Private/CodeTemplates/\\*" -print0 | xargs -0 -n1 -P4 php -dxdebug.mode=off -l >/dev/null
289289
"
290290
291291
phpstan:

Classes/Command/AcceptanceTestsCommand.php

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,20 @@
2828
*/
2929
class AcceptanceTestsCommand extends AbstractCommand
3030
{
31-
protected Filesystem $filesystem;
32-
protected SymfonyStyle $io;
33-
protected PackageInterface $package;
31+
/**
32+
* @var Filesystem $filesystem
33+
*/
34+
protected $filesystem;
35+
36+
/**
37+
* @var SymfonyStyle $io
38+
*/
39+
protected $io;
40+
41+
/**
42+
* @var PackageInterface $package
43+
*/
44+
protected $package;
3445

3546
protected function configure(): void
3647
{
@@ -117,7 +128,7 @@ protected function updateComposerFile(string $packagePath): bool
117128
{
118129
$composerFile = $packagePath . '/composer.json';
119130
$composerJson = file_get_contents($composerFile);
120-
$composer = json_decode($composerJson, true, 512, JSON_THROW_ON_ERROR);
131+
$composer = json_decode($composerJson, true);
121132
$namespace = rtrim($this->getNamespace(), '\\');
122133

123134
// @todo: if a value already exists ask for permission to change it?!

0 commit comments

Comments
 (0)