small test improvements for getMapsOfUser (#1136)

Author: JannikStreek

teammapper-backend/src/map/controllers/maps.controller.spec.ts

@@ -131,7 +131,7 @@ describe('MapsController', () => {
     })
 
     it('should return an empty array when req is undefined', async () => {
-      const response = await mapsController.findAll(undefined)
+      const response = await mapsController.findAll()
       expect(response).toEqual([])
     })
   })

teammapper-backend/src/map/services/maps.service.spec.ts

@@ -947,19 +947,25 @@ describe('MapsService', () => {
 
     it('returns [] if the id is the string undefined', async () => {
       await mapsRepo.save({ ownerExternalId: undefined })
-      const result = await mapsService.getMapsOfUser('undefined')
+      const result = await mapsService.getMapsOfUser(undefined as unknown as string)
       expect(result).toEqual([])
     })
 
     it('returns [] if the id is the string null', async () => {
       await mapsRepo.save({ ownerExternalId: null })
-      const result = await mapsService.getMapsOfUser('null')
+      const result = await mapsService.getMapsOfUser(null as unknown as string)
       expect(result).toEqual([])
     })
 
-    it('returns [] if the id is an empty array []', async () => {
+    it('returns [] if the id is an empty string', async () => {
       await mapsRepo.save({ ownerExternalId: undefined })
-      const result = await mapsService.getMapsOfUser('[]')
+      const result = await mapsService.getMapsOfUser('')
+      expect(result).toEqual([])
+    })
+
+    it('returns [] if the id is an empty array', async () => {
+      await mapsRepo.save({ ownerExternalId: undefined })
+      const result = await mapsService.getMapsOfUser([] as unknown as string)
       expect(result).toEqual([])
     })