build(deps): Bump SonarAnalyzer.CSharp from 8.52.0.60960 to 8.53.0.62665 (#988)

* build(deps): Bump SonarAnalyzer.CSharp from 8.52.0.60960 to 8.53.0.62665

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.52.0.60960 to 8.53.0.62665.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@8.52.0.60960...8.53.0.62665)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: code analyzer rules code updates

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Egil Hansen <[email protected]>

Author: dependabot[bot]

.editorconfig

@@ -504,3 +504,4 @@ dotnet_diagnostic.S125.severity = none # S125: Sections of code should not be co
 dotnet_diagnostic.S3459.severity = none # S3459: Unassigned members should be removed
 dotnet_diagnostic.S3871.severity = none # S3871: Exception types should be "public"
 dotnet_diagnostic.S1186.severity = none # S1186: Methods should not be empty
+dotnet_diagnostic.S1133.severity = none # S1133: Deprecated code should be removed

Directory.Build.props

@@ -50,7 +50,7 @@
 	<!-- Shared code analyzers used for all projects in the solution -->
 	<ItemGroup Label="Code Analyzers">
 		<PackageReference Include="AsyncFixer" Version="1.6.0" PrivateAssets="All" />
-		<PackageReference Include="SonarAnalyzer.CSharp" Version="8.52.0.60960" PrivateAssets="All" />
+		<PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665" PrivateAssets="All" />
 	</ItemGroup>
 
 	<ItemGroup Label="Implicit usings"

src/.editorconfig

@@ -36,3 +36,5 @@
 ##########################################
 # Custom - Code Analyzers Rules
 ##########################################
+
+dotnet_diagnostic.S1133.severity = none # S1133: Deprecated code should be removed

src/bunit.web/ComponentFactories/StubComponentFactory.cs

@@ -22,7 +22,7 @@ public bool CanCreate(Type componentType)
 	public IComponent Create(Type componentType)
 	{
 		var typeToCreate = StubType.MakeGenericType(componentType);
-		return (IComponent)Activator.CreateInstance(typeToCreate, new object?[] { replacementContent })!;
+		return (IComponent)Activator.CreateInstance(typeToCreate, replacementContent)!;
 	}
 }
 #endif

tests/.editorconfig

@@ -42,5 +42,5 @@ dotnet_diagnostic.CA2007.severity = none            # https://github.com/atc-net
 
 dotnet_diagnostic.CA1819.severity = suggestion		# CA1819: Properties should not return arrays
 dotnet_diagnostic.CA1849.severity = suggestion		# CA1849: Call async methods when in an async method
-
 dotnet_diagnostic.xUnit1026.severity = none			# xUnit1026: Theory methods should use all of their parameters
+dotnet_diagnostic.S1144.severity = suggestion		# S1144: Unused private types or members should be removed

tests/bunit.core.tests/ComponentParameterCollectionBuilderTests.cs

@@ -696,6 +696,7 @@ public void Test314()
 		action.ShouldNotThrow();
 	}
 
+#pragma warning disable S1144 // Unused private types or members should be removed
 	private class Params : ComponentBase
 	{
 		public int Field = -1;
@@ -770,4 +771,5 @@ private sealed class ValidNamesComponent : ComponentBase
 		[Parameter] public EventCallback<string> FacialExpressionChanged { get; set; }
 		[Parameter] public Expression<Func<string>> FacialExpressionExpression { get; set; }
 	}
+#pragma warning restore S1144 // Unused private types or members should be removed
 }