fix: Don't encode characters. (Fixes #898) (#899)

Author: linkdotnet

CHANGELOG.md

@@ -6,6 +6,9 @@ All notable changes to **bUnit** will be documented in this file. The project ad
 
 ## [Unreleased]
 
+### Fixed
+ - The created HTML contained encoded strings. Reported by [@tobiasbrandstaedter](https://github.com/tobiasbrandstaedter). Fixed by [@linkdotnet](https://github.com/linkdotnet).
+
 ## [1.11.7] - 2022-10-13
 
 ### Added

src/bunit.web/Rendering/Internal/Htmlizer.cs

@@ -21,8 +21,6 @@ internal static class Htmlizer
 	internal const string BlazorAttrPrefix = "blazor:";
 	internal const string ElementReferenceAttrName = BlazorAttrPrefix + "elementReference";
 
-	private static readonly HtmlEncoder HtmlEncoder = HtmlEncoder.Default;
-
 	private static readonly HashSet<string> SelfClosingElements = new(StringComparer.OrdinalIgnoreCase)
 	{
 		"area",
@@ -95,7 +93,7 @@ private static int RenderCore(
 			case RenderTreeFrameType.Attribute:
 				throw new InvalidOperationException($"Attributes should only be encountered within {nameof(RenderElement)}");
 			case RenderTreeFrameType.Text:
-				context.Result.Append(HtmlEncoder.Encode(frame.TextContent));
+				context.Result.Append(frame.TextContent);
 				return position + 1;
 			case RenderTreeFrameType.Markup:
 				context.Result.Append(frame.MarkupContent);
@@ -272,7 +270,7 @@ private static int RenderAttributes(
 					result.Append(frame.AttributeName);
 					result.Append('=');
 					result.Append('"');
-					result.Append(HtmlEncoder.Encode(value));
+					result.Append(value);
 					result.Append('"');
 					break;
 				default:
@@ -299,4 +297,4 @@ public ReadOnlySpan<RenderTreeFrame> GetRenderTreeFrames(int componentId)
 
 		public string? ClosestSelectValueAsString { get; set; }
 	}
-}
+}

tests/bunit.testassets/BlazorE2E/ComponentWithEscapableCharacters.razor

@@ -0,0 +1,5 @@
+<p style="@Escaped">@Escaped</p>
+
+@code {
+	private string Escaped => "url('')";
+}

tests/bunit.web.tests/BlazorE2E/ComponentRenderingTest.cs

@@ -609,4 +609,12 @@ public async Task CanHandleRemovedParentObjectsAsync()
 		cut.WaitForState(() => !cut.FindAll("div").Any());
 		cut.FindAll("div").Count.ShouldBe(0);
 	}
-}
+
+	[Fact]
+	public void EscapableCharactersDontGetEncoded()
+	{
+		var cut = RenderComponent<ComponentWithEscapableCharacters>();
+
+		cut.Markup.ShouldBe("<p style=\"url('')\">url('')</p>");
+	}
+}