added TaskCreationOptions.RunContinuationsAsynchronously for TSC

linkdotnet · linkdotnet · commit 911de0fffde9 · 2022-10-21T11:52:02.000+02:00
diff --git a/src/bunit.core/Rendering/TestRenderer.cs b/src/bunit.core/Rendering/TestRenderer.cs
@@ -12,7 +12,7 @@ public class TestRenderer : Renderer, ITestRenderer
 	private readonly List<RootComponent> rootComponents = new();
 	private readonly ILogger<TestRenderer> logger;
 	private readonly IRenderedComponentActivator activator;
-	private TaskCompletionSource<Exception> unhandledExceptionTsc = new();
+	private TaskCompletionSource<Exception> unhandledExceptionTsc = new(TaskCreationOptions.RunContinuationsAsynchronously);
 	private Exception? capturedUnhandledException;
 
 	/// <inheritdoc/>
@@ -352,7 +352,7 @@ protected override void HandleException(Exception exception)
 
 		if (!unhandledExceptionTsc.TrySetResult(capturedUnhandledException))
 		{
-			unhandledExceptionTsc = new TaskCompletionSource<Exception>();
+			unhandledExceptionTsc = new TaskCompletionSource<Exception>(TaskCreationOptions.RunContinuationsAsynchronously);
 			unhandledExceptionTsc.SetResult(capturedUnhandledException);
 		}
 	}
@@ -362,7 +362,7 @@ private void ResetUnhandledException()
 		capturedUnhandledException = null;
 
 		if (unhandledExceptionTsc.Task.IsCompleted)
-			unhandledExceptionTsc = new TaskCompletionSource<Exception>();
+			unhandledExceptionTsc = new TaskCompletionSource<Exception>(TaskCreationOptions.RunContinuationsAsynchronously);
 	}
 
 	private void AssertNoUnhandledExceptions()
diff --git a/src/bunit.web/JSInterop/InvocationHandlers/JSRuntimeInvocationHandlerBase{TResult}.cs b/src/bunit.web/JSInterop/InvocationHandlers/JSRuntimeInvocationHandlerBase{TResult}.cs
@@ -31,7 +31,7 @@ public abstract class JSRuntimeInvocationHandlerBase<TResult>
 	protected JSRuntimeInvocationHandlerBase(InvocationMatcher matcher, bool isCatchAllHandler)
 	{
 		invocationMatcher = matcher ?? throw new ArgumentNullException(nameof(matcher));
-		completionSource = new TaskCompletionSource<TResult>();
+		completionSource = new TaskCompletionSource<TResult>(TaskCreationOptions.RunContinuationsAsynchronously);
 		IsCatchAllHandler = isCatchAllHandler;
 	}
 
@@ -41,7 +41,7 @@ protected JSRuntimeInvocationHandlerBase(InvocationMatcher matcher, bool isCatch
 	protected void SetCanceledBase()
 	{
 		if (completionSource.Task.IsCompleted)
-			completionSource = new TaskCompletionSource<TResult>();
+			completionSource = new TaskCompletionSource<TResult>(TaskCreationOptions.RunContinuationsAsynchronously);
 
 		completionSource.SetCanceled();
 	}
@@ -54,7 +54,7 @@ protected void SetExceptionBase<TException>(TException exception)
 		where TException : Exception
 	{
 		if (completionSource.Task.IsCompleted)
-			completionSource = new TaskCompletionSource<TResult>();
+			completionSource = new TaskCompletionSource<TResult>(TaskCreationOptions.RunContinuationsAsynchronously);
 
 		completionSource.SetException(exception);
 	}
@@ -66,7 +66,7 @@ protected void SetExceptionBase<TException>(TException exception)
 	protected void SetResultBase(TResult result)
 	{
 		if (completionSource.Task.IsCompleted)
-			completionSource = new TaskCompletionSource<TResult>();
+			completionSource = new TaskCompletionSource<TResult>(TaskCreationOptions.RunContinuationsAsynchronously);
 
 		completionSource.SetResult(result);
 	}
diff --git a/src/bunit.web/TestDoubles/Authorization/FakeAuthenticationStateProvider.cs b/src/bunit.web/TestDoubles/Authorization/FakeAuthenticationStateProvider.cs
@@ -75,15 +75,15 @@ public void TriggerUnauthenticationStateChanged()
 	private void SetUnauthenticatedState()
 	{
 		if (authState.Task.IsCompleted)
-			authState = new TaskCompletionSource<AuthenticationState>();
+			authState = new TaskCompletionSource<AuthenticationState>(TaskCreationOptions.RunContinuationsAsynchronously);
 
 		authState.SetResult(CreateUnauthenticationState());
 	}
 
 	private void SetAuthorizingState()
 	{
 		if (authState.Task.IsCompleted)
-			authState = new TaskCompletionSource<AuthenticationState>();
+			authState = new TaskCompletionSource<AuthenticationState>(TaskCreationOptions.RunContinuationsAsynchronously);
 	}
 
 	private void SetAuthenticatedState(
@@ -93,7 +93,7 @@ private void SetAuthenticatedState(
 		string? authenticationType)
 	{
 		if (authState.Task.IsCompleted)
-			authState = new TaskCompletionSource<AuthenticationState>();
+			authState = new TaskCompletionSource<AuthenticationState>(TaskCreationOptions.RunContinuationsAsynchronously);
 
 		authState.SetResult(CreateAuthenticationState(userName, roles, claims, authenticationType));
 	}

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public class TestRenderer : Renderer, ITestRenderer`
`12`	`12`	`private readonly List<RootComponent> rootComponents = new();`
`13`	`13`	`private readonly ILogger<TestRenderer> logger;`
`14`	`14`	`private readonly IRenderedComponentActivator activator;`
`15`		`- private TaskCompletionSource<Exception> unhandledExceptionTsc = new();`
	`15`	`+ private TaskCompletionSource<Exception> unhandledExceptionTsc = new(TaskCreationOptions.RunContinuationsAsynchronously);`
`16`	`16`	`private Exception? capturedUnhandledException;`
`17`	`17`
`18`	`18`	`/// <inheritdoc/>`
`@@ -352,7 +352,7 @@ protected override void HandleException(Exception exception)`
`352`	`352`
`353`	`353`	`if (!unhandledExceptionTsc.TrySetResult(capturedUnhandledException))`
`354`	`354`	`{`
`355`		`- unhandledExceptionTsc = new TaskCompletionSource<Exception>();`
	`355`	`+ unhandledExceptionTsc = new TaskCompletionSource<Exception>(TaskCreationOptions.RunContinuationsAsynchronously);`
`356`	`356`	`unhandledExceptionTsc.SetResult(capturedUnhandledException);`
`357`	`357`	`}`
`358`	`358`	`}`
`@@ -362,7 +362,7 @@ private void ResetUnhandledException()`
`362`	`362`	`capturedUnhandledException = null;`
`363`	`363`
`364`	`364`	`if (unhandledExceptionTsc.Task.IsCompleted)`
`365`		`- unhandledExceptionTsc = new TaskCompletionSource<Exception>();`
	`365`	`+ unhandledExceptionTsc = new TaskCompletionSource<Exception>(TaskCreationOptions.RunContinuationsAsynchronously);`
`366`	`366`	`}`
`367`	`367`
`368`	`368`	`private void AssertNoUnhandledExceptions()`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public abstract class JSRuntimeInvocationHandlerBase<TResult>`
`31`	`31`	`protected JSRuntimeInvocationHandlerBase(InvocationMatcher matcher, bool isCatchAllHandler)`
`32`	`32`	`{`
`33`	`33`	`invocationMatcher = matcher ?? throw new ArgumentNullException(nameof(matcher));`
`34`		`- completionSource = new TaskCompletionSource<TResult>();`
	`34`	`+ completionSource = new TaskCompletionSource<TResult>(TaskCreationOptions.RunContinuationsAsynchronously);`
`35`	`35`	`IsCatchAllHandler = isCatchAllHandler;`
`36`	`36`	`}`
`37`	`37`
`@@ -41,7 +41,7 @@ protected JSRuntimeInvocationHandlerBase(InvocationMatcher matcher, bool isCatch`
`41`	`41`	`protected void SetCanceledBase()`
`42`	`42`	`{`
`43`	`43`	`if (completionSource.Task.IsCompleted)`
`44`		`- completionSource = new TaskCompletionSource<TResult>();`
	`44`	`+ completionSource = new TaskCompletionSource<TResult>(TaskCreationOptions.RunContinuationsAsynchronously);`
`45`	`45`
`46`	`46`	`completionSource.SetCanceled();`
`47`	`47`	`}`
`@@ -54,7 +54,7 @@ protected void SetExceptionBase<TException>(TException exception)`
`54`	`54`	`where TException : Exception`
`55`	`55`	`{`
`56`	`56`	`if (completionSource.Task.IsCompleted)`
`57`		`- completionSource = new TaskCompletionSource<TResult>();`
	`57`	`+ completionSource = new TaskCompletionSource<TResult>(TaskCreationOptions.RunContinuationsAsynchronously);`
`58`	`58`
`59`	`59`	`completionSource.SetException(exception);`
`60`	`60`	`}`
`@@ -66,7 +66,7 @@ protected void SetExceptionBase<TException>(TException exception)`
`66`	`66`	`protected void SetResultBase(TResult result)`
`67`	`67`	`{`
`68`	`68`	`if (completionSource.Task.IsCompleted)`
`69`		`- completionSource = new TaskCompletionSource<TResult>();`
	`69`	`+ completionSource = new TaskCompletionSource<TResult>(TaskCreationOptions.RunContinuationsAsynchronously);`
`70`	`70`
`71`	`71`	`completionSource.SetResult(result);`
`72`	`72`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,15 +75,15 @@ public void TriggerUnauthenticationStateChanged()`
`75`	`75`	`private void SetUnauthenticatedState()`
`76`	`76`	`{`
`77`	`77`	`if (authState.Task.IsCompleted)`
`78`		`- authState = new TaskCompletionSource<AuthenticationState>();`
	`78`	`+ authState = new TaskCompletionSource<AuthenticationState>(TaskCreationOptions.RunContinuationsAsynchronously);`
`79`	`79`
`80`	`80`	`authState.SetResult(CreateUnauthenticationState());`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`private void SetAuthorizingState()`
`84`	`84`	`{`
`85`	`85`	`if (authState.Task.IsCompleted)`
`86`		`- authState = new TaskCompletionSource<AuthenticationState>();`
	`86`	`+ authState = new TaskCompletionSource<AuthenticationState>(TaskCreationOptions.RunContinuationsAsynchronously);`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`private void SetAuthenticatedState(`
`@@ -93,7 +93,7 @@ private void SetAuthenticatedState(`
`93`	`93`	`string? authenticationType)`
`94`	`94`	`{`
`95`	`95`	`if (authState.Task.IsCompleted)`
`96`		`- authState = new TaskCompletionSource<AuthenticationState>();`
	`96`	`+ authState = new TaskCompletionSource<AuthenticationState>(TaskCreationOptions.RunContinuationsAsynchronously);`
`97`	`97`
`98`	`98`	`authState.SetResult(CreateAuthenticationState(userName, roles, claims, authenticationType));`
`99`	`99`	`}`