Fixed issue with fake auth where roles and claims was not available through a cascading parameter of Task<AuthenticationState>

* Switched from using FakeIdentity and FakePrincipal to using built in types

* Updated changelog

* Code cleanup

* Added IAsyncDisposable to TestServiceProvider (#292)

* Update main.yml

* Updated SourceFileFinder dependency version

* workflow updates

Author: egil

CHANGELOG.md

@@ -134,6 +134,8 @@ List of any bug fixes.
 
 - When an element, found in the DOM tree using the `Find()`, method was removed because of an event handler trigger on it, e.g. an `cut.Find("button").Click()` event trigger method, an `ElementNotFoundException` was thrown. Reported by [@nickmuller](https://github.com/nickmuller) in [#251](https://github.com/egil/bUnit/issues/251).
 
+- In the built-in fake authentication system in bUnit, roles and claims were not available in components through the a cascading parameter of type `Task<AuthenticationState>`. Reported by [@AFAde](https://github.com/AFAde) in [#253](https://github.com/egil/bUnit/discussions/253) and fixed in [#291](https://github.com/egil/bUnit/pull/291) by [@egil](https://github.com/egil).
+
 ## [1.0.0-beta 11] - 2020-10-26
 
 The following section list all changes in beta-11.

src/bunit.web/TestDoubles/Authorization/FakeAuthenticationStateProvider.cs

@@ -99,14 +99,15 @@ private static AuthenticationState CreateAuthenticationState(
 			IEnumerable<string>? roles = null,
 			IEnumerable<Claim>? claims = null)
 		{
-			var identity = new FakeIdentity { Name = username };
-			var testPrincipal = new FakePrincipal { Identity = identity, Roles = roles ?? Array.Empty<string>() };
-			var principal = new ClaimsPrincipal(testPrincipal);
+			roles = roles ?? Array.Empty<string>();
+			claims = claims ?? Array.Empty<Claim>();
 
-			if (claims is not null && claims.Any())
-			{
-				principal.AddIdentity(new ClaimsIdentity(claims));
-			}
+			var usernameClaim = new Claim(ClaimsIdentity.DefaultNameClaimType, username);
+			var roleClaims = roles.Select(x => new Claim(ClaimsIdentity.DefaultRoleClaimType, x));
+			var allClaims = roleClaims.Concat(claims).Prepend(usernameClaim);
+
+			var identity = new ClaimsIdentity(claims: allClaims, authenticationType: "bUnit Fake Authentication");
+			var principal = new ClaimsPrincipal(identity);
 
 			return new AuthenticationState(principal);
 		}
@@ -117,7 +118,7 @@ private static AuthenticationState CreateAuthenticationState(
 		/// <returns>Instance of AuthenticationState for an unauthenticated user.</returns>
 		private static AuthenticationState CreateUnauthenticationState()
 		{
-			var principal = new ClaimsPrincipal(new FakePrincipal());
+			var principal = new ClaimsPrincipal(new ClaimsIdentity());
 			return new AuthenticationState(principal);
 		}
 	}

src/bunit.web/TestDoubles/Authorization/FakeIdentity.cs

@@ -0,0 +1,17 @@
+@using Microsoft.AspNetCore.Components.Authorization
+
+<p>@isInRole</p>
+
+@code {
+	private bool isInRole;
+
+	[Parameter] public string ExpectedRole { get; set; } = string.Empty;
+
+	[CascadingParameter] public Task<AuthenticationState> AuthenticationStateTask { get; set; } = default!;
+
+	protected override async Task OnInitializedAsync()
+	{
+		var authenticationState = await AuthenticationStateTask;
+		isInRole = authenticationState.User.IsInRole(ExpectedRole);
+	}
+}

src/bunit.web/TestDoubles/Authorization/FakePrincipal.cs

@@ -5,17 +5,16 @@
 
 namespace Bunit.TestDoubles.Authorization
 {
-	public class AuthorizationTest
+	public class AuthorizationTest : TestContext
 	{
 		[Fact(DisplayName = "AuthorizeView with unauthenticated user")]
 		public void Test001()
 		{
 			// Arrange
-			using var ctx = new TestContext();
-			ctx.AddTestAuthorization();
+			this.AddTestAuthorization();
 
 			// Act
-			var cut = ctx.RenderComponent<SimpleAuthView>();
+			var cut = RenderComponent<SimpleAuthView>();
 
 			// Assert
 			cut.MarkupMatches("Not authorized?");
@@ -25,12 +24,11 @@ public void Test001()
 		public void Test002()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser", AuthorizationState.Authorized);
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthView>();
+			var cut = RenderComponent<SimpleAuthView>();
 
 			// assert
 			cut.MarkupMatches("Authorized!");
@@ -40,12 +38,11 @@ public void Test002()
 		public void Test003()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser", AuthorizationState.Unauthorized);
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthView>();
+			var cut = RenderComponent<SimpleAuthView>();
 
 			// assert
 			cut.MarkupMatches("Not authorized?");
@@ -55,11 +52,10 @@ public void Test003()
 		public void Test004()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 
 			// start off unauthenticated.
-			var cut = ctx.RenderComponent<SimpleAuthView>();
+			var cut = RenderComponent<SimpleAuthView>();
 			cut.MarkupMatches("Not authorized?");
 
 			// act
@@ -75,12 +71,11 @@ public void Test004()
 		public void Test005()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser005", AuthorizationState.Authorized);
 
 			// start off unauthenticated.
-			var cut = ctx.RenderComponent<SimpleAuthView>();
+			var cut = RenderComponent<SimpleAuthView>();
 			cut.MarkupMatches("Authorized!");
 
 			// act
@@ -95,11 +90,8 @@ public void Test005()
 		[Fact(DisplayName = "AuthorizeView rendering without authorization services registered")]
 		public void Test006()
 		{
-			// arrange
-			using var ctx = new TestContext();
-
 			// act
-			var ex = Assert.Throws<MissingFakeAuthorizationException>(() => ctx.RenderComponent<SimpleAuthView>());
+			var ex = Assert.Throws<MissingFakeAuthorizationException>(() => RenderComponent<SimpleAuthView>());
 
 			// assert
 			Assert.Equal("AuthenticationStateProvider", ex.ServiceName);
@@ -110,12 +102,11 @@ public void Test006()
 		public void Test007()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser").SetPolicies("ContentViewer");
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthViewWithPolicy>();
+			var cut = RenderComponent<SimpleAuthViewWithPolicy>();
 
 			// assert
 			cut.MarkupMatches("Authorized for content viewers.");
@@ -125,11 +116,10 @@ public void Test007()
 		public void Test008()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser");
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthViewWithPolicy>();
+			var cut = RenderComponent<SimpleAuthViewWithPolicy>();
 
 			// assert
 			cut.MarkupMatches("");
@@ -139,12 +129,11 @@ public void Test008()
 		public void Test0081()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser").SetPolicies("OtherPolicy");
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthViewWithPolicy>();
+			var cut = RenderComponent<SimpleAuthViewWithPolicy>();
 
 			// assert
 			cut.MarkupMatches("");
@@ -154,12 +143,11 @@ public void Test0081()
 		public void Test009()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser").SetRoles("Admin");
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthViewWithRole>();
+			var cut = RenderComponent<SimpleAuthViewWithRole>();
 
 			// assert
 			cut.MarkupMatches("Authorized content for admins.");
@@ -169,12 +157,11 @@ public void Test009()
 		public void Test010()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser");
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthViewWithRole>();
+			var cut = RenderComponent<SimpleAuthViewWithRole>();
 
 			// assert
 			cut.MarkupMatches("");
@@ -184,12 +171,11 @@ public void Test010()
 		public void Test011()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser").SetRoles("NotAdmin");
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthViewWithRole>();
+			var cut = RenderComponent<SimpleAuthViewWithRole>();
 
 			// assert
 			cut.MarkupMatches("");
@@ -199,12 +185,11 @@ public void Test011()
 		public void Test012()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorizing();
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthView>();
+			var cut = RenderComponent<SimpleAuthView>();
 
 			// assert
 			cut.MarkupMatches("Authorizing...");
@@ -215,14 +200,13 @@ public void Test013()
 		{
 			// arrange
 			var userId = new Guid("{5d5fa9c1-abf9-4ed6-8fb0-3365382b629c}");
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			var emailClaim = new Claim(ClaimTypes.Email, "[email protected]");
 			var uuidClaim = new Claim(ClaimTypes.Sid, userId.ToString());
 			authContext.SetAuthorized("TestUser").SetClaims(uuidClaim, emailClaim);
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthViewWithClaims>();
+			var cut = RenderComponent<SimpleAuthViewWithClaims>();
 
 			// assert
 			cut.MarkupMatches(@$"<div>Authorized!</div>
@@ -236,16 +220,28 @@ public void Test013()
 		public void Test014()
 		{
 			// arrange
-			using var ctx = new TestContext();
-			var authContext = ctx.AddTestAuthorization();
+			var authContext = this.AddTestAuthorization();
 			authContext.SetAuthorized("TestUser");
 
 			// act
-			var cut = ctx.RenderComponent<SimpleAuthViewWithClaims>();
+			var cut = RenderComponent<SimpleAuthViewWithClaims>();
 
 			// assert
 			cut.MarkupMatches(@$"<div>Authorized!</div>
 								<div>Name: TestUser</div>");
 		}
+
+		[Fact(DisplayName = "IsInRole can resolve role assigned to auth context")]
+		public void Test020()
+		{
+			var role = "myTestRole";
+			var authCtx = this.AddTestAuthorization();
+			authCtx.SetAuthorized("FooBar");
+			authCtx.SetRoles(role);
+
+			var cut = RenderComponent<AuthCascading>(ps => ps.Add(p => p.ExpectedRole, role));
+
+			cut.MarkupMatches("<p>True</p>");
+		}
 	}
 }