wip

Author: borkdude

src/sci/impl/async_macro.cljc

@@ -398,12 +398,17 @@
                 else-is-promise? (promise-form? transformed-else)
                 ;; If either branch is a promise-form, ensure BOTH branches return promises
                 ;; so we can safely call .then on the if result
+                ;; Also handle missing else when then is promise (implicit nil else)
                 final-then (if (and else-is-promise? (not then-is-promise?))
                              (wrap-promise transformed-then)
                              transformed-then)
-                final-else (if (and then-is-promise? (not else-is-promise?) transformed-else)
-                             (wrap-promise transformed-else)
-                             transformed-else)
+                final-else (cond
+                             ;; else is promise but then isn't - wrap then (handled above), keep else
+                             else-is-promise? transformed-else
+                             ;; then is promise but else isn't (including nil) - wrap else
+                             then-is-promise? (wrap-promise transformed-else)
+                             ;; neither is promise - keep as-is
+                             :else transformed-else)
                 branches-have-promise? (or then-is-promise? else-is-promise?)]
             (if (promise-form? transformed-test)
               (let [test-binding (gensym "test__")]

test/sci/async_await_test.cljs

@@ -406,6 +406,10 @@
                                :no-else-await-in-then
                                (if true (await (js/Promise.resolve :result)))
 
+                               ;; REGRESSION: no else, await in then, but test is false (implicit nil)
+                               :no-else-await-in-then-falsy
+                               (if false (await (js/Promise.resolve :never)))
+
                                ;; REGRESSION: loop with if having mixed branches
                                :nested-loop-mixed
                                (loop [sum 0 items [{:x 10} 5 {:x 20}]]
@@ -432,6 +436,7 @@
                            :await-both-falsy :else
                            :no-else-await-in-test :result
                            :no-else-await-in-then :result
+                           :no-else-await-in-then-falsy nil
                            :nested-loop-mixed 35
                            :expr-position-mixed 142}
                           result))))