ns-aliases now returns identical namespace objects as find-ns

Author: borkdude

CHANGELOG.md

@@ -13,6 +13,7 @@ SCI is used in [babashka](https://github.com/babashka/babashka),
 ## Unreleased
 
 - Add `ns` field to `sci.lang.Var` for compatibility with code that accesses `.ns` on vars
+- `ns-aliases` now returns identical namespace objects as `find-ns`
 - `copy-var` and `copy-var*` now preserve `:private` metadata
 - Add `proxy-super`, `proxy-call-with-super`, `update-proxy` and `proxy-mappings`
 - Support functional interface (FI) adaptation for instance targets (e.g. `(let [^Predicate p even?] (.test p 42))`)

src/sci/impl/namespaces.cljc

@@ -462,7 +462,7 @@
         aliases (get-in @(:env ctx) [:namespaces name :aliases])]
     (zipmap (keys aliases)
             (map (fn [sym]
-                   (sci.lang/->Namespace sym nil))
+                   (sci.impl.utils/namespace-object (:env ctx) sym false nil))
                  (vals aliases)))))
 
 (defn sci-ns-aliases [sci-ns]

test/sci/namespaces_test.cljc

@@ -93,6 +93,7 @@
   (is (= 'clojure.set (eval* "(ns-name (find-ns 'clojure.set))")))
   (is (= 'clojure.set (eval* "(ns-name (the-ns (the-ns 'clojure.set)))")))
   (is (= 'clojure.core (eval* "(alias 'c 'clojure.core) (ns-name (get (ns-aliases *ns*) 'c))")))
+  (is (true? (eval* "(alias 'c 'clojure.core) (identical? (find-ns 'clojure.core) (get (ns-aliases *ns*) 'c))")))
   (is (contains? (set (eval* "(clojure.repl/dir-fn 'clojure.string)"))
                  'last-index-of))
   (is (true? (eval* "(def foo-ns (create-ns 'foo)) (def another-foo-ns (create-ns 'foo))