Fix INSERT EXEC snapshot error when target table has AFTER triggers

Author: monk0707

contrib/babelfishpg_tsql/src/hooks.c

@@ -1682,9 +1682,6 @@ plsql_TriggerRecursiveCheck(ResultRelInfo *resultRelInfo)
 		return false;
 	if (pltsql_recursive_triggers)
 		return false;
-	/* Safety check for parallel workers where exec_state_call_stack may be NULL */
-	if (exec_state_call_stack == NULL)
-		return false;
 	cur = exec_state_call_stack;
 	while (cur != NULL)
 	{

contrib/babelfishpg_tsql/src/pl_exec-2.c

@@ -1276,6 +1276,23 @@ exec_stmt_exec(PLtsql_execstate *estate, PLtsql_stmt_exec *stmt)
 												   stmt->insert_exec_columns,
 												   saved_nested_tran_count);
 			insert_exec_context_set = true;
+			
+			/*
+			 * Temporarily disable T-SQL trigger transaction handling during INSERT EXEC.
+			 *
+			 * When a T-SQL AFTER trigger fires during INSERT EXEC, pltsql_exec_trigger
+			 * sets estate.atomic = false (because support_tsql_trans && 
+			 * !pltsql_disable_txn_in_triggers is true). This makes the trigger use
+			 * SPI_connect_ext(SPI_OPT_NONATOMIC), which pushes an independent snapshot
+			 * that conflicts with the portal's snapshot tracking, causing:
+			 *   "portal snapshots (1) did not account for all active snapshots (2)"
+			 *
+			 * Setting pltsql_disable_txn_in_triggers = true forces triggers to use
+			 * normal atomic SPI, which is compatible with the INSERT EXEC execution.
+			 * The trigger body still fires and executes normally — only the
+			 * Babelfish-specific non-atomic snapshot path is bypassed.
+			 */
+			pltsql_disable_txn_in_triggers = true;
 		}
 
 		rc = SPI_execute_plan_extended(expr->plan, &options);

contrib/babelfishpg_tsql/src/pl_exec.c

@@ -5468,7 +5468,13 @@ exec_stmt_execsql(PLtsql_execstate *estate,
 		if ((!pltsql_disable_batch_auto_commit || (stmt->txn_data != NULL)) &&
 			support_tsql_trans &&
 			(enable_txn_in_triggers || estate->trigdata == NULL) &&
-			!ro_func && !estate->insert_exec)
+			!ro_func && !estate->insert_exec &&
+			!pltsql_insert_exec_rewrite_active())   /* Don't commit inside INSERT EXEC context:
+			                                         * triggers firing during the flush INSERT would
+			                                         * call CommitTransactionCommand() which destroys
+			                                         * the outer SPI portal's snapshot state, causing
+			                                         * "portal snapshots did not account for all
+			                                         * active snapshots" at portalmem.c:1292 */
 		{
 			commit_stmt(estate, (estate->tsql_trigger_flags & TSQL_TRAN_STARTED));