Removed unused variable relname.

Changed some logic in objectproperty for IsSchemaBound

Signed-off-by: Rahul Parande <rparande@amazon.com>

Author: Rahul Parande

contrib/babelfishpg_tsql/runtime/functions.c

@@ -4482,12 +4482,13 @@ objectproperty_internal(PG_FUNCTION_ARGS)
 		if (pg_strcasecmp(property, "isschemabound") == 0)
 		{
 			bool is_weak_view = false;
+			bool is_view = (type == OBJECT_TYPE_VIEW);
 
-			if (type == OBJECT_TYPE_VIEW)
+			if (is_view)
 				check_is_tsql_view(object_id, &is_weak_view);
 
 			pfree(property);
-			PG_RETURN_INT32(((int) !is_weak_view));
+			PG_RETURN_INT32(is_view ? ((int) !is_weak_view) : 0);
 		}
 		/*
 		 * For ExecIsQuotedIdentOn and ExecIsAnsiNullsOn, we hardcoded it to 1

contrib/babelfishpg_tsql/src/hooks.c

@@ -6764,17 +6764,10 @@ update_bbf_view_flags(Oid viewOid, uint64 flags_to_set, uint64 flags_to_clear, b
 				flag_validity;
 	bool 		isnull;
 	bool 		updated = false;
-	char 		*relname = NULL;
 
 	Datum 		values[BBF_VIEW_DEF_NUM_COLS];
 	bool 		nulls[BBF_VIEW_DEF_NUM_COLS];
 	bool 		replaces[BBF_VIEW_DEF_NUM_COLS];
-
-	relname = get_rel_name(viewOid);
-	if (!relname)
-		ereport(ERROR,
-				(errcode(ERRCODE_UNDEFINED_TABLE),
-				errmsg("view with OID %u does not exist", viewOid)));
 
 	brel = table_open(get_bbf_view_def_oid(), RowExclusiveLock);
 	tuple = search_bbf_view_def(brel, viewOid);
@@ -7383,23 +7376,21 @@ handle_bbf_view_binding_on_object_drop(const ObjectAddress *droppedObject, Relat
 		if (OidIsValid(viewOid) && !list_member_oid(processed_views, viewOid))
 		{
 			processed_views = lappend_oid(processed_views, viewOid);
-			if (!is_alter_view)
+			
+			/* DROP operation: if dependent is weak view, mark broken */
+			is_weak_view = false;
+			if (check_is_tsql_view(viewOid, &is_weak_view) && is_weak_view)
 			{
-				/* DROP operation: if dependent is weak view, mark broken */
-				is_weak_view = false;
-				if (check_is_tsql_view(viewOid, &is_weak_view) && is_weak_view)
+				/* Mark view as broken */
+				updated = bbf_view_set_broken(viewOid, true);
+				
+				/* If the view was successfully marked as broken, create a dummy query */
+				if (updated)
 				{
-					/* Mark view as broken */
-					updated = bbf_view_set_broken(viewOid, true);
-					
-					/* If the view was successfully marked as broken, create a dummy query */
-					if (updated)
-					{
-						Query *dummyQuery = create_dummy_view_query_for_broken_view(viewOid);
-						StoreViewQuery(viewOid, dummyQuery, true);
-					}
-					CommandCounterIncrement();
+					Query *dummyQuery = create_dummy_view_query_for_broken_view(viewOid);
+					StoreViewQuery(viewOid, dummyQuery, true);
 				}
+				CommandCounterIncrement();
 			}
 			else if (is_alter_view && pltsql_weak_view_binding)
 			{