Fix crash in exec_internal_grant_on_function when logical schema is null (#4660) (#4674)

When creating functions in schemas created from PostgreSQL endpoint,
the logical schema name is null, causing a crash in
exec_internal_grant_on_function at CStringGetTextDatum(logicalschema).

Fixed an issue where the system would crash when attempting to grant
permissions on functions created in PostgreSQL-endpoint schemas by
adding a null check for logicalschema before calling
CStringGetTextDatum.

Task: BABEL-6390
Signed-off-by: Harsh Lunagariya <lunharsh@amazon.com>

Author: HarshLunagariya

contrib/babelfishpg_tsql/src/catalog.c

@@ -644,7 +644,7 @@ get_logical_schema_name(const char *physical_schema_name, bool missingOk)
 		if (!missingOk)
 			ereport(ERROR,
 					(errcode(ERRCODE_INTERNAL_ERROR),
-					 errmsg("Could find logical schema name for: \"%s\"", physical_schema_name)));
+					 errmsg("Could not find logical schema name for: \"%s\"", physical_schema_name)));
 		return NULL;
 	}
 	datum = SysCacheGetAttr(SYSNAMESPACENAME, tuple, Anum_namespace_ext_orig_name, &isnull);
@@ -4460,7 +4460,7 @@ exec_internal_grant_on_function(Oid objectId)
 	object_name = NameStr(procedureStruct->proname);
 	phy_sch_oid = procedureStruct->pronamespace;
 	schema = get_namespace_name(phy_sch_oid);
-	logicalschema = get_logical_schema_name(schema, true);
+	logicalschema = get_logical_schema_name(schema, false);
 	object_type = procedureStruct->prokind;
 
 	/* Fetch the relation */

test/JDBC/expected/TestInteropProcedures.out

@@ -251,3 +251,22 @@ GO
 -- psql     currentSchema=master_dbo,public
 DROP PROCEDURE psql_interop_proc
 GO
+
+-- psql
+CREATE SCHEMA master_s6390;
+GO
+
+GRANT ALL ON SCHEMA master_s6390 TO PUBLIC ;
+GO
+
+-- tsql
+CREATE FUNCTION s6390.f1() RETURNS INT AS BEGIN return 1 END;
+GO
+~~ERROR (Code: 33557097)~~
+
+~~ERROR (Message: Could not find logical schema name for: "master_s6390")~~
+
+
+-- psql
+DROP SCHEMA master_s6390;
+GO

test/JDBC/expected/db_securityadmin-vu-verify.out

@@ -980,28 +980,28 @@ GRANT SELECT ON sys.database_principals TO babel_5135_u1;
 GO
 ~~ERROR (Code: 33557097)~~
 
-~~ERROR (Message: Could find logical schema name for: "sys")~~
+~~ERROR (Message: Could not find logical schema name for: "sys")~~
 
 
 REVOKE SELECT ON sys.database_principals FROM babel_5135_u1;
 GO
 ~~ERROR (Code: 33557097)~~
 
-~~ERROR (Message: Could find logical schema name for: "sys")~~
+~~ERROR (Message: Could not find logical schema name for: "sys")~~
 
 
 GRANT SELECT ON pg_catalog.pg_namespace TO babel_5135_u1;
 GO
 ~~ERROR (Code: 33557097)~~
 
-~~ERROR (Message: Could find logical schema name for: "pg_catalog")~~
+~~ERROR (Message: Could not find logical schema name for: "pg_catalog")~~
 
 
 REVOKE SELECT ON pg_catalog.pg_namespace FROM babel_5135_u1;
 GO
 ~~ERROR (Code: 33557097)~~
 
-~~ERROR (Message: Could find logical schema name for: "pg_catalog")~~
+~~ERROR (Message: Could not find logical schema name for: "pg_catalog")~~
 
 
 REVOKE SELECT ON babel_5135_db1.dbo.babel_5135_show_role_mem TO babel_5135_u1;

test/JDBC/input/interoperability/TestInteropProcedures.mix

@@ -192,3 +192,18 @@ GO
 -- psql     currentSchema=master_dbo,public
 DROP PROCEDURE psql_interop_proc
 GO
+
+-- psql
+CREATE SCHEMA master_s6390;
+GO
+
+GRANT ALL ON SCHEMA master_s6390 TO PUBLIC ;
+GO
+
+-- tsql
+CREATE FUNCTION s6390.f1() RETURNS INT AS BEGIN return 1 END;
+GO
+
+-- psql
+DROP SCHEMA master_s6390;
+GO