Skip to content

Commit c393b4d

Browse files
author
Rahul Parande
committed
Fixed cppcheck failure for unintialized variables in search_bbf_view_def
Signed-off-by: Rahul Parande <rparande@amazon.com>
1 parent 3bc936f commit c393b4d

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

contrib/babelfishpg_tsql/src/catalog.c

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1207,23 +1207,23 @@ search_bbf_view_def(Relation bbf_view_def_rel, Oid viewOid)
12071207
HeapTuple scantup,
12081208
oldtup;
12091209
Oid schema_id;
1210-
char *schema_name,
1211-
*view_name;
1210+
char *schema_name = NULL;
1211+
char *view_name = NULL;
12121212
const char *logical_schema_name = NULL;
12131213
int16 dbid = InvalidDbid;
12141214

1215-
if (OidIsValid(viewOid))
1216-
{
1217-
schema_id = get_rel_namespace(viewOid);
1218-
schema_name = get_namespace_name(schema_id);
1219-
view_name = get_rel_name(viewOid);
1220-
1221-
if (!schema_name)
1222-
return NULL;
1223-
1224-
logical_schema_name = get_logical_schema_name(schema_name, true);
1225-
dbid = get_dbid_from_physical_schema_name(schema_name, true);
1226-
}
1215+
if (!OidIsValid(viewOid))
1216+
return NULL;
1217+
1218+
schema_id = get_rel_namespace(viewOid);
1219+
schema_name = get_namespace_name(schema_id);
1220+
view_name = get_rel_name(viewOid);
1221+
1222+
if (!schema_name)
1223+
return NULL;
1224+
1225+
logical_schema_name = get_logical_schema_name(schema_name, true);
1226+
dbid = get_dbid_from_physical_schema_name(schema_name, true);
12271227

12281228
if (!DbidIsValid(dbid) || logical_schema_name == NULL || view_name == NULL)
12291229
{

0 commit comments

Comments
 (0)