Skip to content

Commit 4c12b4c

Browse files
author
Justin Skiles
committed
Removed method which binds to non-existent endpoint after Valve removed it. Fixed issue with GetLiveLeagueGames deserialization.
1 parent 3af4a2c commit 4c12b4c

File tree

5 files changed

+12
-40
lines changed

5 files changed

+12
-40
lines changed

src/Steam.Models/DOTA2/LiveLeagueGamePlayerDetailModel.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ public class LiveLeagueGamePlayerDetailModel
1616
public uint ExperiencePerMinute { get; set; }
1717
public uint UltimateState { get; set; }
1818
public uint UltimateCooldown { get; set; }
19-
public uint Item0 { get; set; }
20-
public uint Item1 { get; set; }
21-
public uint Item2 { get; set; }
22-
public uint Item3 { get; set; }
23-
public uint Item4 { get; set; }
24-
public uint Item5 { get; set; }
19+
public int Item0 { get; set; }
20+
public int Item1 { get; set; }
21+
public int Item2 { get; set; }
22+
public int Item3 { get; set; }
23+
public int Item4 { get; set; }
24+
public int Item5 { get; set; }
2525
public uint RespawnTimer { get; set; }
2626
public double PositionX { get; set; }
2727
public double PositionY { get; set; }

src/Steam.UnitTests/DOTA2EconTests.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,6 @@ public DOTA2EconTests()
1919
steamInterface = factory.CreateSteamWebInterface<DOTA2Econ>(new HttpClient());
2020
}
2121

22-
[Fact]
23-
public async Task GetGameItemsAsync_Should_Succeed()
24-
{
25-
var response = await steamInterface.GetGameItemsAsync();
26-
Assert.NotNull(response);
27-
Assert.NotNull(response.Data);
28-
}
29-
3022
[Fact]
3123
public async Task GetHeroesAsync_Should_Succeed()
3224
{

src/SteamWebAPI2/Interfaces/DOTA2Econ.cs

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -31,24 +31,6 @@ public DOTA2Econ(IMapper mapper, ISteamWebRequest steamWebRequest, ISteamWebInte
3131
this.dota2TestWebInterface = new SteamWebInterface("IEconDOTA2_205790", steamWebRequest);
3232
}
3333

34-
/// <summary>
35-
/// Returns a collection of in game Dota 2 items. Example: blink dagger.
36-
/// </summary>
37-
/// <param name="language"></param>
38-
/// <returns></returns>
39-
public async Task<ISteamWebResponse<IReadOnlyCollection<Steam.Models.DOTA2.GameItem>>> GetGameItemsAsync(string language = "en_us")
40-
{
41-
List<SteamWebRequestParameter> parameters = new List<SteamWebRequestParameter>();
42-
43-
parameters.AddIfHasValue(language, "language");
44-
45-
var steamWebResponse = await dota2WebInterface.GetAsync<GameItemResultContainer>("GetGameItems", 1, parameters);
46-
47-
var steamWebResponseModel = mapper.Map<ISteamWebResponse<GameItemResultContainer>, ISteamWebResponse<IReadOnlyCollection<Steam.Models.DOTA2.GameItem>>>(steamWebResponse);
48-
49-
return steamWebResponseModel;
50-
}
51-
5234
/// <summary>
5335
/// Returns a collection of heroes and basic hero data.
5436
/// </summary>

src/SteamWebAPI2/Interfaces/IDOTA2Econ.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ namespace SteamWebAPI2.Interfaces
77
{
88
public interface IDOTA2Econ
99
{
10-
Task<ISteamWebResponse<IReadOnlyCollection<GameItem>>> GetGameItemsAsync(string language = "");
11-
1210
Task<ISteamWebResponse<IReadOnlyCollection<Hero>>> GetHeroesAsync(string language = "", bool itemizedOnly = false);
1311

1412
Task<ISteamWebResponse<IReadOnlyCollection<Rarity>>> GetRaritiesAsync(string language = "");

src/SteamWebAPI2/Models/DOTA2/LiveLeagueGameResultContainer.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -192,12 +192,12 @@ internal class LiveLeagueGamePlayerDetail
192192
[JsonProperty(PropertyName = "ultimate_cooldown")]
193193
public uint UltimateCooldown { get; set; }
194194

195-
public uint Item0 { get; set; }
196-
public uint Item1 { get; set; }
197-
public uint Item2 { get; set; }
198-
public uint Item3 { get; set; }
199-
public uint Item4 { get; set; }
200-
public uint Item5 { get; set; }
195+
public int Item0 { get; set; }
196+
public int Item1 { get; set; }
197+
public int Item2 { get; set; }
198+
public int Item3 { get; set; }
199+
public int Item4 { get; set; }
200+
public int Item5 { get; set; }
201201

202202
[JsonProperty(PropertyName = "respawn_timer")]
203203
public uint RespawnTimer { get; set; }

0 commit comments

Comments
 (0)