Added RawPayload, fixed unit test

Author: babenkoivan

src/Console/ElasticIndexUpdateCommand.php

@@ -8,6 +8,7 @@
 use ScoutElastic\Console\Features\requiresIndexConfiguratorArgument;
 use ScoutElastic\Facades\ElasticClient;
 use ScoutElastic\Payloads\IndexPayload;
+use ScoutElastic\Payloads\RawPayload;
 
 class ElasticIndexUpdateCommand extends Command
 {
@@ -75,15 +76,19 @@ protected function createWriteAlias()
 
         $indices = ElasticClient::indices();
 
-        if ($indices->existsAlias(['name' => $configurator->getWriteAlias()])) {
+        $existsPayload = (new RawPayload())
+            ->set('name', $configurator->getWriteAlias())
+            ->get();
+
+        if ($indices->existsAlias($existsPayload)) {
             return;
         }
 
-        $payload = (new IndexPayload($configurator))
+        $putPayload = (new IndexPayload($configurator))
             ->set('name', $configurator->getWriteAlias())
             ->get();
 
-        $indices->putAlias($payload);
+        $indices->putAlias($putPayload);
 
         $this->info(sprintf(
             'The %s alias for the %s index was created!',

src/Payloads/IndexPayload.php

@@ -5,10 +5,8 @@
 use Exception;
 use ScoutElastic\IndexConfigurator;
 
-class IndexPayload
+class IndexPayload extends RawPayload
 {
-    protected $payload = [];
-
     protected $protectedKeys = [
         'index'
     ];
@@ -41,24 +39,10 @@ public function useAlias($alias)
 
     public function set($key, $value)
     {
-        if (!is_null($key) && !in_array($key, $this->protectedKeys)) {
-            array_set($this->payload, $key, $value);
-        }
-
-        return $this;
-    }
-
-    public function setIfNotEmpty($key, $value)
-    {
-        if (empty($value)) {
+        if (in_array($key, $this->protectedKeys)) {
             return $this;
         }
 
-        return $this->set($key, $value);
-    }
-
-    public function get($key = null)
-    {
-        return array_get($this->payload, $key);
+        return parent::set($key, $value);
     }
 }

src/Payloads/RawPayload.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace ScoutElastic\Payloads;
+
+class RawPayload
+{
+    protected $payload = [];
+
+    public function set($key, $value)
+    {
+        if (!is_null($key)) {
+            array_set($this->payload, $key, $value);
+        }
+
+        return $this;
+    }
+
+    public function setIfNotEmpty($key, $value)
+    {
+        if (empty($value)) {
+            return $this;
+        }
+
+        return $this->set($key, $value);
+    }
+
+    public function get($key = null)
+    {
+        return array_get($this->payload, $key);
+    }
+}

tests/ElasticEngineTest.php

@@ -24,7 +24,7 @@ public function test_if_the_update_method_builds_correct_payload()
         $this->mockClient()
             ->shouldReceive('index')
             ->with([
-                'index' => 'test_index',
+                'index' => 'test_index_write',
                 'type' => 'test_table',
                 'id' => 1,
                 'body' => [