Skip to content
This repository was archived by the owner on Jul 20, 2025. It is now read-only.

Commit 0e6b535

Browse files
fix: resolve comments
1 parent b9bc56a commit 0e6b535

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/components/Menu/MenuDrawer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export const MenuDrawer: React.FC<MenuDrawerProps> = ({
9494
// For fullHeight drawers (mobile), use Portal to ensure proper theme sync
9595
if (fullHeight) {
9696
return (
97-
<Portal mounted={true} rootClassName="menu-drawer-portal">
97+
<Portal mounted rootClassName="menu-drawer-portal">
9898
{onBackdropClick && (
9999
<div
100100
className={twJoin(

src/widgets/new-design/SettingMenu/SettingMenu.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {
1212
type SettingMenuDescriptionProps,
1313
type SettingMenuCustomContentProps,
1414
} from "./types";
15+
import { twJoin } from "tailwind-merge";
1516

1617
const SettingsIcon = () => (
1718
<svg width="29" height="28" viewBox="0 0 29 28" fill="none" xmlns="http://www.w3.org/2000/svg">
@@ -71,7 +72,7 @@ const SettingMenuBase: React.FC<SettingMenuProps> = ({
7172
};
7273

7374
const SettingMenuTitle: React.FC<SettingMenuTitleProps> = ({ children, className = "" }) => (
74-
<Text variant="body1" className={`px-7 pb-6 text-accent-primary md:hidden ${className}`}>
75+
<Text variant="body1" className={twJoin("px-7 pb-6 text-accent-primary md:hidden", className)}>
7576
{children}
7677
</Text>
7778
);
@@ -93,7 +94,7 @@ const SettingMenuGroup: React.FC<SettingMenuGroupProps> = ({
9394
}
9495
};
9596

96-
return <div className={`${getBackgroundClass()} ${className}`.trim()}>{children}</div>;
97+
return <div className={twJoin(getBackgroundClass(), className)}>{children}</div>;
9798
};
9899

99100
// Item component
@@ -125,7 +126,7 @@ const SettingMenuItem: React.FC<SettingMenuItemProps> = ({
125126
disabled={disabled}
126127
selected={selected}
127128
className={className}
128-
suffix={suffix || <ChevronRightIcon />}
129+
suffix={suffix === undefined && onClick ? <ChevronRightIcon /> : suffix}
129130
/>
130131
);
131132
};

0 commit comments

Comments
 (0)