This repository was archived by the owner on Jul 20, 2025. It is now read-only.
feat: add menu component #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jeremy-babylonlabs
force-pushed
the
feat/menu-component
branch
from
32886c0 to
f7a0f57
Compare
jeremy-babylonlabs
requested review from
0xDazzer,
jonybur,
jrwbabylonlab,
gbarkhatov and
Copilot
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jrwbabylonlab
approved these changes
Jul 17, 2025
jrwbabylonlab
approved these changes
Jul 17, 2025
|
the implementation of the menu should be put in components I think we can add a PR to put the Setting Menu in the widget |
gbarkhatov
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
Pull Request Overview
Adds a fully-featured, responsive Menu component with nested submenus, mobile drawer support, and a viewport detection hook.
- Introduces
useIsMobilehook for mobile breakpoint detection. - Implements Menu, SubMenu, MenuItem, SubMenuItem, MenuDrawer, and MenuContext for flexible menu structures.
- Wires up responsive behavior: Popover on desktop, sliding drawer on mobile.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/index.tsx | Export the new Menu entry point |
| src/hooks/useIsMobile.ts | Add hook to detect mobile viewport size |
| src/components/Menu/index.ts | Aggregate exports for Menu subcomponents |
| src/components/Menu/SubMenuItem.tsx | Render submenu items with labels, description, and suffix |
| src/components/Menu/SubMenu.tsx | Implement nested submenu with sliding drawer logic |
| src/components/Menu/MenuItem.tsx | Implement menu item with click handling and context-based close |
| src/components/Menu/MenuDrawer.tsx | Sliding drawer component with header and backdrop |
| src/components/Menu/MenuContext.tsx | Create React context for menu state management |
| src/components/Menu/Menu.tsx | Main Menu component combining Popover and mobile drawer |
| src/components/Menu/Menu.stories.tsx | Add Storybook example demonstrating default menu |
Comments suppressed due to low confidence (2)
src/components/Menu/SubMenu.tsx:10
- Prop naming is inconsistent: SubMenu uses
namewhile SubMenuItem useslabelfor primary text. Consider unifying these prop names across Menu components for API consistency.
name?: string; // This is the recommended property for the primary text in menu items. Use this instead of older alternatives.
src/hooks/useIsMobile.ts:29
- The
useIsMobilehook currently lacks unit tests. Consider adding tests to verify correct behavior across different window widths and resize events.
return isMobile;
jonybur
approved these changes
Jul 17, 2025
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
jeremy-babylonlabs
force-pushed
the
feat/menu-component
branch
from
5e49859 to
6735c7c
Compare
|
@jeremy-babylonlabs it's quite hard to review what's been changed since last approval Could u squash later commits or just push a single commit once ready? |
|
@gbarkhatov @jonybur plz double check if there are more comments. |
jrwbabylonlab
approved these changes
Jul 18, 2025
jonybur
approved these changes
Jul 18, 2025
gbarkhatov
approved these changes
Jul 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.