core: add events for allow-list (#103)

## Description

This PR adds event for allow-list updates (`handle_add_to_allowlist`,
`handle_remove_from_allowlist`)

Fixes #102

## Checklist

- [x] I have updated the
[docs/SPEC.md](https://github.com/babylonlabs-io/rollup-bsn-contracts/blob/main/docs/SPEC.md)
file if this change affects the specification
- [x] I have updated the schema by running `cargo gen-schema`

Author: 0xAleksaOpacic

CHANGELOG.md

@@ -39,17 +39,19 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ### State and API breaking
 
-* [82](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/108) core: 
+* [#82](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/108) core: 
   add allow-list to instantiate arg
-* [97](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/97) feat:
+* [#97](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/97) feat:
   versioning of FP allowlist
-* [100](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/100) chore:
+* [#100](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/100) chore:
   add query to fetch highest voted height
 
 ### Improvements
 
 * [#108](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/91) feat:
   optimize public key handling by using bytes instead of hex
+* [#103](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/103) core: 
+  add events for allow-list
 * [#91](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/91) feat:
   optimize public key handling by using bytes instead of hex
 * [#98](https://github.com/babylonlabs-io/rollup-bsn-contracts/pull/98) feat:

contracts/finality/src/contract.rs

@@ -1533,6 +1533,59 @@ pub(crate) mod tests {
         }
     }
 
+    #[test]
+    fn test_allowlist_events() {
+        let mut deps = mock_deps_babylon();
+        let admin = deps.api.addr_make(INIT_ADMIN);
+        let admin_info = message_info(&admin, &[]);
+
+        // Instantiate contract
+        let instantiate_msg = InstantiateMsg {
+            admin: admin.to_string(),
+            bsn_id: "test-bsn-id".to_string(),
+            min_pub_rand: 100,
+            max_msgs_per_interval: MAX_MSGS_PER_INTERVAL,
+            rate_limiting_interval: RATE_LIMITING_INTERVAL,
+            bsn_activation_height: 0,
+            finality_signature_interval: 1,
+            allowed_finality_providers: None,
+        };
+        let info = message_info(&deps.api.addr_make(CREATOR), &[]);
+        instantiate(deps.as_mut(), mock_env(), info, instantiate_msg).unwrap();
+
+        // Test add to allowlist event
+        let fp_keys = vec![
+            "02a0434d9e47f3c86235477c7b1ae6ae5d3442d49b1943c2b752a68e2a47e247c7".to_string(),
+            "c51bff10d544a2daa9e57fa00b70eb4b61d01a646c040fd0c7c1f69fd8289c8ac3".to_string(),
+        ];
+        let add_msg = ExecuteMsg::AddToAllowlist {
+            fp_pubkey_hex_list: fp_keys.clone(),
+        };
+        let res = execute(deps.as_mut(), mock_env(), admin_info.clone(), add_msg).unwrap();
+
+        // Check event was emitted
+        assert_eq!(res.events.len(), 1);
+        let event = &res.events[0];
+        assert_eq!(event.ty, "add_to_allowlist");
+        assert_eq!(event.attributes.len(), 1);
+        assert_eq!(event.attributes[0].key, "fp_pubkeys");
+        assert_eq!(event.attributes[0].value, fp_keys.join(","));
+
+        // Test remove from allowlist event
+        let remove_msg = ExecuteMsg::RemoveFromAllowlist {
+            fp_pubkey_hex_list: vec![fp_keys[0].clone()],
+        };
+        let res = execute(deps.as_mut(), mock_env(), admin_info, remove_msg).unwrap();
+
+        // Check event was emitted
+        assert_eq!(res.events.len(), 1);
+        let event = &res.events[0];
+        assert_eq!(event.ty, "remove_from_allowlist");
+        assert_eq!(event.attributes.len(), 1);
+        assert_eq!(event.attributes[0].key, "fp_pubkeys");
+        assert_eq!(event.attributes[0].value, fp_keys[0].clone());
+    }
+
     #[test]
     fn test_instantiate_allowlist_event() {
         let mut deps = mock_deps_babylon();

contracts/finality/src/exec/allowlist.rs

@@ -1,4 +1,4 @@
-use cosmwasm_std::{DepsMut, Env, MessageInfo, Response};
+use cosmwasm_std::{DepsMut, Env, Event, MessageInfo, Response};
 
 use crate::error::ContractError;
 use crate::msg::BabylonMsg;
@@ -37,7 +37,11 @@ pub fn handle_add_to_allowlist(
 
     add_finality_providers_to_allowlist(deps.storage, &fp_btc_pk_bytes_list, env.block.height)?;
 
+    let event =
+        Event::new("add_to_allowlist").add_attribute("fp_pubkeys", fp_pubkey_hex_list.join(","));
+
     Ok(Response::new()
+        .add_event(event)
         .add_attribute("action", "add_to_allowlist")
         .add_attribute("num_added", fp_pubkey_hex_list.len().to_string()))
 }
@@ -75,7 +79,11 @@ pub fn handle_remove_from_allowlist(
         env.block.height,
     )?;
 
+    let event = Event::new("remove_from_allowlist")
+        .add_attribute("fp_pubkeys", fp_pubkey_hex_list.join(","));
+
     Ok(Response::new()
+        .add_event(event)
         .add_attribute("action", "remove_from_allowlist")
         .add_attribute("num_removed", fp_pubkey_hex_list.len().to_string()))
 }