Skip to content

Commit 95031c8

Browse files
authored
js console fix (#421)
1 parent 33ee4b7 commit 95031c8

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/components/CodeEditor/CodeEditor.react.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ export default class CodeEditor extends React.Component {
2525
if (this.state.code !== props.code) {
2626
this.setState({ code: props.code });
2727
}
28-
require(`ace-builds/src-noconflict/mode-${props.mode}`);
29-
require(`ace-builds/src-noconflict/snippets/${props.mode}`);
28+
if (props.mode) {
29+
require(`ace-builds/src-noconflict/mode-${props.mode}`);
30+
require(`ace-builds/src-noconflict/snippets/${props.mode}`);
31+
}
3032
}
3133

3234
get value() {
@@ -38,7 +40,7 @@ export default class CodeEditor extends React.Component {
3840
}
3941

4042
render() {
41-
const { placeHolder, fontSize = 18, mode } = this.props;
43+
const { placeHolder, fontSize = 18, mode = 'javascript' } = this.props;
4244
const { code } = this.state;
4345

4446
return (

src/dashboard/Data/Playground/Playground.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export default class Playground extends Component {
146146
return React.cloneElement(
147147
<div className={styles['playground-ctn']}>
148148
<Toolbar section={this.section} subsection={this.subsection} />
149-
<div style={{ minHeight: '25vh' }}>
149+
<div style={{ height: 'calc(100vh - 96px)' }}>
150150
<CodeEditor
151151
placeHolder={`const myObj = new Parse.Object('MyClass');
152152
myObj.set('myField', 'Hello World!')

src/dashboard/Data/Playground/Playground.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.playground-ctn {
2-
padding-top: 96px;
2+
padding-top: 48px;
33
background-color: #002b36;
44
height: 100vh;
55
}

0 commit comments

Comments
 (0)