refactor(pi): drop isSubmitPathAllowed alias

isSubmitPathAllowed was a pure pass-through to isPlanWritePathAllowed
with no plausible reason to diverge. Use the write-gate helper directly
from submit_plan and drop the alias.

For provenance purposes, this commit was AI assisted.

Author: backnotprop

apps/pi-extension/index.ts

@@ -52,7 +52,6 @@ import {
 import {
 	getToolsForPhase,
 	isPlanWritePathAllowed,
-	isSubmitPathAllowed,
 	PLAN_SUBMIT_TOOL,
 	type Phase,
 	stripPlanningOnlyTools,
@@ -552,7 +551,7 @@ export default function plannotator(pi: ExtensionAPI): void {
 				};
 			}
 
-			if (!isSubmitPathAllowed(inputPath, ctx.cwd)) {
+			if (!isPlanWritePathAllowed(inputPath, ctx.cwd)) {
 				return {
 					content: [
 						{

apps/pi-extension/tool-scope.test.ts

@@ -2,7 +2,6 @@ import { describe, expect, test } from "bun:test";
 import {
 	getToolsForPhase,
 	isPlanWritePathAllowed,
-	isSubmitPathAllowed,
 	PLAN_SUBMIT_TOOL,
 	stripPlanningOnlyTools,
 } from "./tool-scope";
@@ -87,18 +86,3 @@ describe("plan write path gate", () => {
 		expect(isPlanWritePathAllowed("notes.MdX", cwd)).toBe(true);
 	});
 });
-
-describe("submit path gate", () => {
-	const cwd = "/r";
-
-	test("accepts markdown paths inside cwd", () => {
-		expect(isSubmitPathAllowed("PLAN.md", cwd)).toBe(true);
-		expect(isSubmitPathAllowed("plans/auth.md", cwd)).toBe(true);
-	});
-
-	test("rejects traversal and non-markdown", () => {
-		expect(isSubmitPathAllowed("../escape.md", cwd)).toBe(false);
-		expect(isSubmitPathAllowed("plan.txt", cwd)).toBe(false);
-		expect(isSubmitPathAllowed("plans/", cwd)).toBe(false);
-	});
-});

apps/pi-extension/tool-scope.ts

@@ -26,7 +26,7 @@ export function getToolsForPhase(
 	];
 }
 
-// During planning, agents may write/edit any markdown file inside cwd.
+// Used by both the planning-phase write gate and plannotator_submit_plan.
 // Path must resolve inside cwd (no traversal, no absolute escape) and end
 // in a permitted markdown extension.
 export function isPlanWritePathAllowed(inputPath: string, cwd: string): boolean {
@@ -37,8 +37,3 @@ export function isPlanWritePathAllowed(inputPath: string, cwd: string): boolean
 	const ext = extname(targetAbs).toLowerCase();
 	return ALLOWED_PLAN_EXTENSIONS.has(ext);
 }
-
-// Validates an agent-supplied submit_plan path. Same rules as the write gate.
-export function isSubmitPathAllowed(inputPath: string, cwd: string): boolean {
-	return isPlanWritePathAllowed(inputPath, cwd);
-}