fix(repo): pickup the node versions for CI jobs from the workspace package.json to resolve CI failures #6806 (#6805)

* fix(repo): pickup the node versions for CI jobs from the workspace package.json

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* chore: drop EOL Node 18 version from workspaces, added 22 to these workspaces that has configured just 20 with this change

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* fix(blackduck): update Node versions to 22 and 24 to resolve CI issues (it is updated to Backstage 1.46 already)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* fix(topology): remove isolated-vm resolution that was added to bypass CI issues (this workspace is still on Backstage 1.45 and will be updated asap)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* fix(tekton): remove isolated-vm resolution that was added to bypass CI issues (this workspace is still on Backstage 1.45 and will be updated asap)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* fix(acr): update Node versions to 22 and 24 to resolve CI issues (it is updated to Backstage 1.46 already)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* fix(quay): update Node versions to 22 and 24 to resolve CI issues (it is updated to Backstage 1.46 already)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* fix(doc): update faq

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

---------

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

Author: christoph-jerolimov

.github/workflows/ci.yml

@@ -13,6 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     outputs:
       workspaces: ${{ steps.find-changed-workspaces.outputs.workspaces }}
+      workspaceNodeMatrix: ${{ steps.find-changed-workspaces.outputs.workspace_node_matrix }}
     steps:
       - name: Calculate number of commits in PR
         id: calculate-commits
@@ -45,17 +46,16 @@ jobs:
           BASE_REF: origin/${{ github.event.pull_request.base.ref }}
 
   ci:
-    name: Workspace ${{ matrix.workspace }}, CI step for node ${{ matrix.node-version }}
+    name: Workspace ${{ matrix.workspaceNodeMatrix.workspace }}, CI step for node ${{ matrix.workspaceNodeMatrix.nodeVersion }}
     runs-on: ubuntu-latest
     needs: find-changed-workspaces
     strategy:
       matrix:
-        workspace: ${{ fromJSON(needs.find-changed-workspaces.outputs.workspaces) }}
-        node-version: [22.x, 24.x]
+        workspaceNodeMatrix: ${{ fromJSON(needs.find-changed-workspaces.outputs.workspaceNodeMatrix) }}
       fail-fast: false
     defaults:
       run:
-        working-directory: ./workspaces/${{ matrix.workspace }}
+        working-directory: ./workspaces/${{ matrix.workspaceNodeMatrix.workspace }}
 
     env:
       CI: true
@@ -71,10 +71,10 @@ jobs:
         with:
           ref: ${{ github.event.workflow_run.head_branch }}
 
-      - name: Set up Node ${{ matrix.node-version }}
+      - name: Set up Node ${{ matrix.workspaceNodeMatrix.nodeVersion }}
         uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4
         with:
-          node-version: ${{ matrix.node-version }}
+          node-version: ${{ matrix.workspaceNodeMatrix.nodeVersion }}
           registry-url: https://registry.npmjs.org/ # Needed for auth
 
       - name: yarn install
@@ -84,7 +84,7 @@ jobs:
         run: yarn fix --check
 
       - name: validate config
-        if: ${{ hashFiles(format('workspaces/{0}/app-config.yaml', matrix.workspace)) != '' }}
+        if: ${{ hashFiles(format('workspaces/{0}/app-config.yaml', matrix.workspaceNodeMatrix.workspace)) != '' }}
         run: yarn backstage-cli config:check --lax
 
       - name: type checking and declarations
@@ -96,7 +96,7 @@ jobs:
       - name: read knipReports flag from bcp.json
         id: bcpKnipReports
         run: |
-          echo "Checking for bcp.json in workspace: workspaces/${{ matrix.workspace }}"
+          echo "Checking for bcp.json in workspace: workspaces/${{ matrix.workspaceNodeMatrix.workspace }}"
           if [ -f bcp.json ]; then
             echo "Reading knipReports flag..."
             KNIP_REPORTS=$(jq -r '.["knipReports"]' bcp.json)
@@ -114,7 +114,7 @@ jobs:
       - name: read listDeprecations flag from bcp.json
         id: bcpListDeprecations
         run: |
-          echo "Checking for bcp.json in workspace: workspaces/${{ matrix.workspace }}"
+          echo "Checking for bcp.json in workspace: workspaces/${{ matrix.workspaceNodeMatrix.workspace }}"
           if [ -f bcp.json ]; then
             echo "Reading listDeprecations flag..."
             LIST_DEPRECATIONS=$(jq -r '.["listDeprecations"]' bcp.json)
@@ -147,7 +147,7 @@ jobs:
       - name: read playwrightTests flag from bcp.json
         id: bcpPlaywrightTests
         run: |
-          echo "Checking for bcp.json in workspace: workspaces/${{ matrix.workspace }}"
+          echo "Checking for bcp.json in workspace: workspaces/${{ matrix.workspaceNodeMatrix.workspace }}"
           if [ -f bcp.json ]; then
             echo "Reading playwrightTests flag..."
             PLAYWRIGHT_TESTS=$(jq -r '.["playwrightTests"]' bcp.json)

docs/plugin-maintainers-guide.md

@@ -24,6 +24,7 @@
     - [A GitHub check is stuck "waiting for status to be reported".](#a-github-check-is-stuck-waiting-for-status-to-be-reported)
     - [The "API Report" check is failing.](#the-api-report-check-is-failing)
     - [My build is failing with errors about `package.json` metadata.](#my-build-is-failing-with-errors-about-packagejson-metadata)
+    - [My CI workflow is failing with some Node.js versions.](#my-ci-workflow-is-failing-with-some-nodejs-versions)
     - [My CI workflow is failing due to linting errors.](#my-ci-workflow-is-failing-due-to-linting-errors)
     - [How do I create a new plugin?](#how-do-i-create-a-new-plugin)
 
@@ -289,6 +290,18 @@ The `package.json` for your plugin might be missing required fields or have inco
 2.  Run `yarn backstage-cli repo fix --publish`
 3.  This will check for and automatically fix common `package.json` issues. Commit any changes.
 
+### My CI workflow is failing with some Node.js versions.
+
+The CI workflow runs your tests automatically with all versions configured in your workspace root `package.json`, configured under `engines.node`, like:
+
+```json
+  "engines": {
+    "node": "22 || 24"
+  },
+```
+
+This versions should match the [Node.js versions supported by Backstage](https://backstage.io/docs/overview/versioning-policy/#nodejs-releases).
+
 ### My CI workflow is failing due to linting errors.
 
 This means your code doesn't match the project's automatic formatting rules.

scripts/ci/list-workspaces-with-changes.js

@@ -49,7 +49,6 @@ async function main() {
   if (!process.env.GITHUB_OUTPUT) {
     throw new Error('GITHUB_OUTPUT environment variable not set');
   }
-
   const repoRoot = resolvePath(__dirname, '..', '..');
   process.chdir(repoRoot);
 
@@ -81,10 +80,46 @@ async function main() {
 
   console.log('workspaces that exist:', Array.from(workspaces));
 
+  // Automatically detect the supported Node versions from package.json
+  const workspaceNodeMatrix = [];
+  for (const workspace of workspaces) {
+    const packageJson = JSON.parse(
+      await fs.readFile(`workspaces/${workspace}/package.json`),
+    );
+    const nodeString = packageJson.engines.node;
+    if (!nodeString) {
+      throw new Error(
+        `No node engine specified in workspaces/${workspace}/package.json`,
+      );
+    }
+    const nodeVersions = nodeString.split('||').map(v => v.trim());
+    console.log(
+      `Detected node versions for workspace ${workspace}:`,
+      nodeVersions,
+    );
+    // Convert versions like "18" to "18.x" for GitHub matrix usage
+    nodeVersions.forEach(nodeVersion => {
+      if (nodeVersion.match(/^\d\d$/)) {
+        workspaceNodeMatrix.push({
+          workspace,
+          nodeVersion: `${nodeVersion}.x`,
+        });
+      } else {
+        workspaceNodeMatrix.push({ workspace, nodeVersion });
+      }
+    });
+  }
+
   await fs.appendFile(
     process.env.GITHUB_OUTPUT,
     `workspaces=${JSON.stringify(Array.from(workspaces))}${EOL}`,
   );
+  await fs.appendFile(
+    process.env.GITHUB_OUTPUT,
+    `workspace_node_matrix=${JSON.stringify(
+      Array.from(workspaceNodeMatrix),
+    )}${EOL}`,
+  );
 }
 
 main().catch(error => {

workspaces/3scale/package.json

@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "private": true,
   "engines": {
-    "node": "18 || 20 || 22"
+    "node": "20 || 22"
   },
   "scripts": {
     "start": "backstage-cli repo start",

workspaces/acr/package.json

@@ -4,7 +4,7 @@
   "version": "1.0.0",
   "private": true,
   "engines": {
-    "node": "18 || 20 || 22"
+    "node": "22 || 24"
   },
   "scripts": {
     "start": "backstage-cli repo start",

workspaces/acs/package.json

@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "private": true,
   "engines": {
-    "node": "20.x"
+    "node": "20 || 22"
   },
   "scripts": {
     "dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",

workspaces/adr/package.json

@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "private": true,
   "engines": {
-    "node": "18 || 20 || 22"
+    "node": "20 || 22"
   },
   "scripts": {
     "dev": "yarn workspaces foreach -A --include @backstage-community/plugin-adr --include @backstage-community/plugin-adr-backend --parallel -v -i run start",

workspaces/amplication/package.json

@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "private": true,
   "engines": {
-    "node": "18 || 20 || 22"
+    "node": "20 || 22"
   },
   "scripts": {
     "start": "backstage-cli repo start",

workspaces/analytics/package.json

@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "private": true,
   "engines": {
-    "node": "18 || 20 || 22"
+    "node": "20 || 22"
   },
   "scripts": {
     "tsc": "tsc",

workspaces/azure-resources/package.json

@@ -3,7 +3,7 @@
   "version": "1.0.0",
   "private": true,
   "engines": {
-    "node": "18 || 20 || 22"
+    "node": "20 || 22"
   },
   "scripts": {
     "start": "backstage-cli repo start",