Skip to content

Commit 2cd7e22

Browse files
enable knip reports for lighthouse workspace (#7566)
Signed-off-by: Karthik <karthik.jk11@gmail.com>
1 parent 340bb32 commit 2cd7e22

File tree

9 files changed

+192
-2222
lines changed

9 files changed

+192
-2222
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@backstage-community/plugin-lighthouse-backend': patch
3+
'@backstage-community/plugin-lighthouse-common': patch
4+
'@backstage-community/plugin-lighthouse': patch
5+
---
6+
7+
remove unused dependencies

workspaces/lighthouse/.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@ dist-types
33
coverage
44
.vscode
55
.eslintrc.js
6+
knip-report.md

workspaces/lighthouse/bcp.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"autoVersionBump": true,
3-
"knipReports": false
3+
"knipReports": true
44
}
Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,2 @@
11
# Knip report
22

3-
## Unused dependencies (1)
4-
5-
| Name | Location | Severity |
6-
| :------ | :----------- | :------- |
7-
| winston | package.json | error |

workspaces/lighthouse/plugins/lighthouse-backend/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@
5252
"@backstage/catalog-model": "backstage:^",
5353
"@backstage/config": "backstage:^",
5454
"@backstage/plugin-catalog-node": "backstage:^",
55-
"@backstage/types": "backstage:^",
56-
"winston": "^3.2.1"
55+
"@backstage/types": "backstage:^"
5756
},
5857
"devDependencies": {
5958
"@backstage/backend-defaults": "backstage:^",
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
# Knip report
2+
Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,2 @@
11
# Knip report
22

3-
## Unused devDependencies (2)
4-
5-
| Name | Location | Severity |
6-
| :------------------- | :----------- | :------- |
7-
| @testing-library/dom | package.json | error |
8-
| canvas | package.json | error |

workspaces/lighthouse/plugins/lighthouse/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,9 @@
7272
"devDependencies": {
7373
"@backstage/cli": "backstage:^",
7474
"@backstage/core-app-api": "backstage:^",
75-
"@backstage/dev-utils": "backstage:^",
7675
"@backstage/frontend-defaults": "backstage:^",
7776
"@backstage/plugin-catalog": "backstage:^",
7877
"@backstage/test-utils": "backstage:^",
79-
"@testing-library/dom": "^10.0.0",
8078
"@testing-library/jest-dom": "^6.0.0",
8179
"@testing-library/react": "^15.0.0",
8280
"@types/react-dom": "^18.2.19",

0 commit comments

Comments
 (0)