feat check localstorage if no search param (#24)

* fix: broken tests

* feat: use localstorage to populate, if there's no yarn plugin search param

* chore: removed unnecessary export keyword

* update with suggested changes

Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>

* update with suggested changes

Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>

* update with suggested changes

Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>

* update with suggested changes

Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>

* update with suggested changes

Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>

* update with suggested changes

Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>

* fix: tests should adhere more to upstream

---------

Co-authored-by: Vincenzo Scamporlino <vincenzos@spotify.com>

Author: Sacquer

src/SettingsProvider.tsx

@@ -1,16 +1,25 @@
-import React, { ReactNode, useContext } from 'react'
+import React, { ReactNode, useContext, useEffect } from 'react'
 import useLocalStorage from 'react-use/lib/useLocalStorage'
 import useSearchParam from 'react-use/lib/useSearchParam'
 
 import { SHOW_LATEST_RCS, USE_YARN_PLUGIN } from './utils'
 import { updateURL } from './utils/update-url'
 
-const INITIAL_STATE = {
+interface SETTINGS {
+  [SHOW_LATEST_RCS]: boolean
+  [USE_YARN_PLUGIN]: boolean
+}
+
+type State = {
+  settings: SETTINGS
+  setSettings(settings: SETTINGS): void
+}
+const INITIAL_STATE: State = {
   settings: {
     [`${SHOW_LATEST_RCS}`]: false,
     [`${USE_YARN_PLUGIN}`]: false,
   },
-  setSettings: (setting: any) => {},
+  setSettings: () => {},
 }
 
 export const SettingsContext = React.createContext(INITIAL_STATE)
@@ -21,15 +30,22 @@ export const SettingsProvider = React.memo(function ({
   children: ReactNode
 }) {
   const useYarnPluginParam = useSearchParam('yarnPlugin')
+  const shouldPopulateYarnPluginParam = useYarnPluginParam === null
   const useYarnPlugin =
-    useYarnPluginParam !== null ? !!Number(useYarnPluginParam) : false
+    !shouldPopulateYarnPluginParam ? !!Number(useYarnPluginParam) : false
 
   const [settings, setLocalStorageSettings] = useLocalStorage(
     'backstage:upgrade-helper:settings',
     INITIAL_STATE.settings
   )
 
-  const setSettings = (settings: typeof INITIAL_STATE.settings) => {
+  useEffect(() => {
+    if (shouldPopulateYarnPluginParam) {
+      updateURL({ yarnPlugin: settings?.[USE_YARN_PLUGIN] ?? false })
+    }
+  }, [shouldPopulateYarnPluginParam, settings?.[USE_YARN_PLUGIN]])
+
+  const setSettings = (settings: SETTINGS) => {
     const { [USE_YARN_PLUGIN]: newUseYarnPlugin, ...localStorageSettings } =
       settings
 

src/__tests__/utils.spec.ts

@@ -4,7 +4,7 @@ import { getVersionsContentInDiff, getChangelogURL } from '../utils'
 
 const fixtureVersions = ['0.59', '0.58', '0.57', '0.56'].map((version) => ({
   version,
-  createApp: '',
+  createApp: undefined!,
 }))
 
 describe('getVersionsContentInDiff', () => {