feat: check on empty array key values (#12)

* Check on empty array key values

* PHPStan issues

* Fix styling

---------

Co-authored-by: Baspa <[email protected]>

Author: Baspa

src/Concerns/CanMapDynamicFields.php

@@ -79,7 +79,11 @@ protected function mutateBeforeSave(array $data): array
             return $data;
         }
 
-        $values = $data[$this->record?->valueColumn];
+        $values = isset($data[$this->record?->valueColumn]) ? $data[$this->record?->valueColumn] : [];
+
+        if (empty($values)) {
+            return $data;
+        }
 
         $fieldsFromValues = array_keys($values);
 

src/Fields.php

@@ -6,7 +6,7 @@
 
 class Fields
 {
-    private static array $fields = [];
+    protected static array $fields = [];
 
     public static function registerField(string $className): void
     {

src/Fields/Repeater.php

@@ -8,7 +8,6 @@
 use Backstage\Fields\Contracts\FieldContract;
 use Backstage\Fields\Enums\Field as FieldEnum;
 use Backstage\Fields\Facades\Fields;
-use Backstage\Fields\Fields\Select as FieldsSelect;
 use Backstage\Fields\Models\Field;
 use Filament\Forms;
 use Filament\Forms\Components\Hidden;
@@ -28,21 +27,6 @@ class Repeater extends Base implements FieldContract
     use HasFieldTypeResolver;
     use HasOptions;
 
-    private const FIELD_TYPE_MAP = [
-        'text' => Text::class,
-        'textarea' => Textarea::class,
-        'rich-editor' => RichEditor::class,
-        'repeater' => Repeater::class,
-        'select' => FieldsSelect::class,
-        'checkbox' => Checkbox::class,
-        'checkbox-list' => CheckboxList::class,
-        'key-value' => KeyValue::class,
-        'radio' => Radio::class,
-        'toggle' => Toggle::class,
-        'color' => Color::class,
-        'date-time' => DateTime::class,
-    ];
-
     public static function getDefaultConfig(): array
     {
         return [

src/Fields/RichEditor.php

@@ -2,8 +2,8 @@
 
 namespace Backstage\Fields\Fields;
 
-use Backstage\Enums\ToolbarButton;
 use Backstage\Fields\Contracts\FieldContract;
+use Backstage\Fields\Enums\ToolbarButton;
 use Backstage\Fields\Models\Field;
 use Backstage\Fields\Services\ContentCleaningService;
 use Filament\Forms;

src/Filament/RelationManagers/FieldsRelationManager.php

@@ -118,43 +118,6 @@ public function form(Form $form): Form
             ]);
     }
 
-    private function formatCustomFields(array $fields): array
-    {
-        return collect($fields)->mapWithKeys(function ($field, $key) {
-            $parts = explode('\\', $field);
-            $lastPart = end($parts);
-            $formattedName = Str::title(Str::snake($lastPart, ' '));
-
-            return [$key => $formattedName];
-        })->toArray();
-    }
-
-    private function initializeDefaultConfig(string $fieldType): array
-    {
-        $className = 'Backstage\\Fields\\Fields\\' . Str::studly($fieldType);
-
-        if (! class_exists($className)) {
-            return [];
-        }
-
-        $fieldInstance = app($className);
-
-        return $fieldInstance::getDefaultConfig();
-    }
-
-    private function initializeCustomConfig(string $fieldType): array
-    {
-        $className = Fields::getFields()[$fieldType] ?? null;
-
-        if (! class_exists($className)) {
-            return [];
-        }
-
-        $fieldInstance = app($className);
-
-        return $fieldInstance::getDefaultConfig();
-    }
-
     public function table(Table $table): Table
     {
         return $table
@@ -185,13 +148,13 @@ public function table(Table $table): Table
                     ->slideOver()
                     ->mutateFormDataUsing(function (array $data) {
 
-                        $key = $this->ownerRecord->getKeyName() ?? 'id';
+                        $key = $this->ownerRecord->getKeyName();
 
                         return [
                             ...$data,
                             'position' => Field::where('model_key', $key)->get()->max('position') + 1,
                             'model_type' => 'setting',
-                            'model_key' => $this->ownerRecord->slug,
+                            'model_key' => $this->ownerRecord->getKey(),
                         ];
                     })
                     ->after(function (Component $livewire) {
@@ -203,7 +166,7 @@ public function table(Table $table): Table
                     ->slideOver()
                     ->mutateRecordDataUsing(function (array $data) {
 
-                        $key = $this->ownerRecord->getKeyName() ?? 'id';
+                        $key = $this->ownerRecord->getKeyName();
 
                         return [
                             ...$data,
@@ -222,7 +185,7 @@ public function table(Table $table): Table
                                 ->hasColumn($this->ownerRecord->getTable(), $record->valueColumn)
                         ) {
 
-                            $key = $this->ownerRecord->getKeyName() ?? 'id';
+                            $key = $this->ownerRecord->getKeyName();
 
                             $this->ownerRecord->update([
                                 $record->valueColumn => collect($this->ownerRecord->{$record->valueColumn})->forget($record->{$key})->toArray(),

src/Models/Field.php

@@ -11,6 +11,23 @@
 use Illuminate\Support\Facades\Config;
 use Staudenmeir\LaravelAdjacencyList\Eloquent\HasRecursiveRelationships;
 
+/**
+ * @property string $ulid
+ * @property string|null $parent_ulid
+ * @property string $model_type
+ * @property string $model_key
+ * @property string $slug
+ * @property string $name
+ * @property string $field_type
+ * @property array<string, mixed>|null $config
+ * @property int $position
+ * @property string|null $group
+ * @property \Carbon\Carbon $created_at
+ * @property \Carbon\Carbon $updated_at
+ * @property-read \Illuminate\Database\Eloquent\Model|null $model
+ * @property-read \Illuminate\Database\Eloquent\Collection<int, Field> $children
+ * @property-read \Illuminate\Database\Eloquent\Model|null $tenant
+ */
 class Field extends Model
 {
     use HasPackageFactory;

src/Services/FieldInspectionService.php

@@ -7,7 +7,9 @@
 use Illuminate\Support\Str;
 use ReflectionClass;
 use ReflectionMethod;
+use ReflectionNamedType;
 use ReflectionProperty;
+use ReflectionType;
 
 class FieldInspectionService implements FieldInspector
 {
@@ -63,7 +65,7 @@ private function getMethodsDetails(ReflectionClass $reflection): array
                 'visibility' => $this->getVisibility($method),
                 'static' => $method->isStatic(),
                 'parameters' => $this->getParametersDetails($method),
-                'returnType' => $method->getReturnType() ? $method->getReturnType()->getName() : null,
+                'returnType' => $this->getTypeName($method->getReturnType()),
                 'docComment' => $method->getDocComment() ?: null,
             ];
         }
@@ -78,7 +80,7 @@ private function getPropertiesDetails(ReflectionClass $reflection): array
             $properties[$property->getName()] = [
                 'visibility' => $this->getVisibility($property),
                 'static' => $property->isStatic(),
-                'type' => $property->getType() ? $property->getType()->getName() : null,
+                'type' => $this->getTypeName($property->getType()),
                 'docComment' => $property->getDocComment() ?: null,
                 'defaultValue' => $this->getPropertyDefaultValue($property),
             ];
@@ -92,7 +94,7 @@ private function getParametersDetails(ReflectionMethod $method): array
         $parameters = [];
         foreach ($method->getParameters() as $param) {
             $parameters[$param->getName()] = [
-                'type' => $param->getType() ? $param->getType()->getName() : null,
+                'type' => $this->getTypeName($param->getType()),
                 'hasDefaultValue' => $param->isDefaultValueAvailable(),
                 'defaultValue' => $param->isDefaultValueAvailable() ? $param->getDefaultValue() : null,
                 'isVariadic' => $param->isVariadic(),
@@ -103,6 +105,15 @@ private function getParametersDetails(ReflectionMethod $method): array
         return $parameters;
     }
 
+    private function getTypeName(?ReflectionType $type): ?string
+    {
+        if ($type instanceof ReflectionNamedType) {
+            return $type->getName();
+        }
+
+        return null;
+    }
+
     private function getVisibility($reflection): string
     {
         if ($reflection->isPrivate()) {