php 8.3 and 8.4 support, phpstan fixes (#84)

Author: Baspa

.github/workflows/phpstan.yml

@@ -12,7 +12,7 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: "8.1"
+          php-version: "8.4"
 
       - name: Cache composer dependencies
         uses: actions/cache@v4

.github/workflows/run-tests.yml

@@ -13,7 +13,7 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-latest, windows-latest]
-        php: [8.1, 8.2]
+        php: [8.1, 8.2, 8.3, 8.4]
         laravel: [10.*, 11.*, 12.*]
         stability: [prefer-lowest, prefer-stable]
         include:

CHANGELOG.md

@@ -2,6 +2,16 @@
 
 All notable changes to `laravel-seo` will be documented in this file.
 
+## v3.2.0 - 2024-12-19
+
+### What's Changed
+
+-   Add support for PHP 8.3 and 8.4
+-   Ensure full Laravel 12.x compatibility
+-   Update GitHub Actions workflows to test against new PHP versions
+
+**Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v3.1.0...v3.2.0
+
 ## v3.1.0 - 2023-08-17
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v3.0.0...v3.1.0
@@ -10,32 +20,32 @@ All notable changes to `laravel-seo` will be documented in this file.
 
 ### What's Changed
 
-- Crawl Javascript pages (SPA) by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/39
+-   Crawl Javascript pages (SPA) by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/39
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v2.6.1...v3.0.0
 
 ## v2.6.1 - 2023-08-04
 
 ### What's Changed
 
-- Keyword checks by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/36
+-   Keyword checks by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/36
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v2.5.0...v2.6.1
 
 ## v2.5.0 - 2023-08-03
 
 ### What's Changed
 
-- Remove title check by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/35
+-   Remove title check by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/35
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v2.4.0...v2.5.0
 
 ## v2.4.0 - 2023-08-03
 
 ### What's Changed
 
-- Bump dependabot/fetch-metadata from 1.5.1 to 1.6.0 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/34
-- Replace cURL with HTTP by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/33
+-   Bump dependabot/fetch-metadata from 1.5.1 to 1.6.0 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/34
+-   Replace cURL with HTTP by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/33
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v2.3.0...v2.4.0
 
@@ -49,21 +59,21 @@ Broken image check now also saves the status in the database.
 
 ### What's Changed
 
-- Bump dependabot/fetch-metadata from 1.4.0 to 1.5.1 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/31
-- Bump aglipanci/laravel-pint-action from 2.2.0 to 2.3.0 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/32
-- [Feature] Domain custom resolve by @markvaneijk in https://github.com/backstagephp/laravel-seo-scanner/pull/22
+-   Bump dependabot/fetch-metadata from 1.4.0 to 1.5.1 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/31
+-   Bump aglipanci/laravel-pint-action from 2.2.0 to 2.3.0 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/32
+-   [Feature] Domain custom resolve by @markvaneijk in https://github.com/backstagephp/laravel-seo-scanner/pull/22
 
 ### New Contributors
 
-- @markvaneijk made their first contribution in https://github.com/backstagephp/laravel-seo-scanner/pull/22
+-   @markvaneijk made their first contribution in https://github.com/backstagephp/laravel-seo-scanner/pull/22
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v2.1.0...v2.2.0
 
 ## v2.1.0 - 2023-05-29
 
 ### What's Changed
 
-- Prunable scans by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/30
+-   Prunable scans by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/30
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v2.0.0...v2.1.0
 
@@ -73,49 +83,49 @@ Broken image check now also saves the status in the database.
 
 The following changes have been made to classnames with abbreviations in the checks:
 
-- `CCSSizeCheck` has been changed to `CssSizeCheck`
-- `TTFBSizeCheck` has been changed to `TtfbSizeCheck`
-- `HTMLSizeCheck` has been changed to `HtmlSizeCheck`
+-   `CCSSizeCheck` has been changed to `CssSizeCheck`
+-   `TTFBSizeCheck` has been changed to `TtfbSizeCheck`
+-   `HTMLSizeCheck` has been changed to `HtmlSizeCheck`
 
 If you have scans saved in the database, please ensure you update the failed_checks column in the seo_scans table. The previous namespaces used in this column are no longer compatible.
 
 ### What's Changed
 
-- Bump dependabot/fetch-metadata from 1.3.6 to 1.4.0 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/27
-- Save broken link status code by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/28
-- Reformat to abbrevation to lowercase by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/29
+-   Bump dependabot/fetch-metadata from 1.3.6 to 1.4.0 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/27
+-   Save broken link status code by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/28
+-   Reformat to abbrevation to lowercase by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/29
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v1.3.0...v2.0.0
 
 ## v1.3.0 - 2023-05-05
 
 ### What's Changed
 
-- Bump aglipanci/laravel-pint-action from 2.1.0 to 2.2.0 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/25
-- Run scan with queued job by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/26
+-   Bump aglipanci/laravel-pint-action from 2.1.0 to 2.2.0 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/25
+-   Run scan with queued job by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/26
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v1.2.0...v1.3.0
 
 ## v1.2.0 - 2023-03-09
 
 ### What's Changed
 
-- Adding a new config to disable SSL certificate integrity check by @MuriloChianfa in https://github.com/backstagephp/laravel-seo-scanner/pull/18
-- Bump dependabot/fetch-metadata from 1.3.5 to 1.3.6 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/20
-- [Feature] Laravel 10 compatibility by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/24
+-   Adding a new config to disable SSL certificate integrity check by @MuriloChianfa in https://github.com/backstagephp/laravel-seo-scanner/pull/18
+-   Bump dependabot/fetch-metadata from 1.3.5 to 1.3.6 by @dependabot in https://github.com/backstagephp/laravel-seo-scanner/pull/20
+-   [Feature] Laravel 10 compatibility by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/24
 
 ### New Contributors
 
-- @MuriloChianfa made their first contribution in https://github.com/backstagephp/laravel-seo-scanner/pull/18
+-   @MuriloChianfa made their first contribution in https://github.com/backstagephp/laravel-seo-scanner/pull/18
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v1.1.0...v1.2.0
 
 ## v1.1.0 - 2023-01-13
 
 ### What's Changed
 
-- Fix Windows tests by removing SSL validation when using `curl()` by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/16
-- Check if a relative url is used when performing broken link checks by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/17
+-   Fix Windows tests by removing SSL validation when using `curl()` by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/16
+-   Check if a relative url is used when performing broken link checks by @Baspa in https://github.com/backstagephp/laravel-seo-scanner/pull/17
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/compare/v1.0.1...v1.1.0
 
@@ -127,11 +137,11 @@ If you have scans saved in the database, please ensure you update the failed_che
 
 #### Features
 
-- Total of 21 checks
-- Extensive config file where you can configure how the package behaves.
-- Command to check all configured routes
-- Command to check a single url
-- Possibility to save results into the database
-- Corresponding models to easily retrieve the data
+-   Total of 21 checks
+-   Extensive config file where you can configure how the package behaves.
+-   Command to check all configured routes
+-   Command to check a single url
+-   Possibility to save results into the database
+-   Corresponding models to easily retrieve the data
 
 **Full Changelog**: https://github.com/backstagephp/laravel-seo-scanner/commits/v1.0.0

README.md

@@ -49,8 +49,8 @@ Easily configure which routes to scan, exclude or include specific checks or eve
 
 ## Minimum requirements
 
--   PHP 8.1 or higher
--   Laravel 9.0 or higher
+-   PHP 8.1 or higher (8.1, 8.2, 8.3, 8.4)
+-   Laravel 9.0 or higher (9.x, 10.x, 11.x, 12.x)
 
 ## Installation
 
@@ -62,7 +62,7 @@ composer require backstage/laravel-seo-scanner
 
 If you want to scan pages that are rendered using Javascript, for example Vue or React, you need to install Puppeteer. You can install it using the following command:
 
-> If you want to know how to scan Javascript rendered pages, check out [Scanning routes in an SPA application](#scanning-routes-in-an-spa-application). Want to know more about Puppeteer? Check out the [Puppeteer documentation](https://pptr.dev/). 
+> If you want to know how to scan Javascript rendered pages, check out [Scanning routes in an SPA application](#scanning-routes-in-an-spa-application). Want to know more about Puppeteer? Check out the [Puppeteer documentation](https://pptr.dev/).
 
 ```bash
 npm install puppeteer
@@ -283,6 +283,7 @@ When you want to save the SEO score to the database, you need to set the `save`
 Optionally you can specify the database connection in the config file. If you want to save the SEO score to a model, you need to add the model to the `models` array in the config file. More information about this can be found in the [Check the SEO score of a model](#check-the-seo-score-of-a-model) section.
 
 #### Pruning the database
+
 Per default the package will prune the database from old scans. You can specify the number of days you want to keep the scans in the database. The default is 30 days.
 
 If you want to prune the database, you need to add the prune command to your `App\Console\Kernel`:

composer.json

@@ -16,7 +16,7 @@
         }
     ],
     "require": {
-        "php": "^8.1",
+        "php": "^8.1|^8.2|^8.3|^8.4",
         "guzzlehttp/guzzle": "^7.5",
         "illuminate/contracts": "^9.0|^10.0|^11.0|^12.0",
         "j0k3r/php-readability": "^2.0",

phpstan.neon.dist

@@ -9,5 +9,4 @@ parameters:
     tmpDir: build/phpstan
     checkOctaneCompatibility: true
     checkModelProperties: true
-    checkMissingIterableValueType: false
 

src/Checks/Content/MultipleHeadingCheck.php

@@ -52,7 +52,7 @@ public function validateContent(Crawler $crawler): bool
             return false;
         }
 
-        if (is_array($content) && count($content) > 1) {
+        if (count($content) > 1) {
             $this->actualValue = $content;
 
             $this->failureReason = __('failed.content.multiple_h1', [

src/Checks/Meta/DescriptionCheck.php

@@ -44,10 +44,10 @@ public function check(Response $response, Crawler $crawler): bool
 
     public function getDescriptionContent(Crawler $crawler): ?string
     {
-        /** @var \DOMElement $node */
+        /** @var \DOMElement|null $node */
         $node = $crawler->filterXPath('//meta[@name="description"]')->getNode(0);
 
-        if ($node instanceof \DOMElement && $node->hasAttribute('content')) {
+        if ($node && $node->hasAttribute('content')) {
             return $node->getAttribute('content');
         }
 

src/Checks/Performance/ResponseCheck.php

@@ -33,10 +33,8 @@ class ResponseCheck implements Check
 
     public function check(Response $response, Crawler $crawler): bool
     {
-        /** @phpstan-ignore-next-line */
         $this->actualValue = $response->getStatusCode();
 
-        /** @phpstan-ignore-next-line */
         if ($response->getStatusCode() === 200) {
             return true;
         }

src/Traits/HasSeoScore.php

@@ -8,6 +8,7 @@
 use Illuminate\Contracts\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Relations\MorphMany;
 
+/** @phpstan-ignore-next-line */
 trait HasSeoScore
 {
     public function seoScore(): SeoScore