Added shell command for lighting output overridden and tracking value. (#41)

Added shell command for lighting output overridden and tracking value.

Author: skarg

zephyr/samples/profiles/b-ld/boards/nucleo_f429zi.overlay

@@ -4,6 +4,35 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+/delete-node/ &storage_partition;
+
+/ {
+  leds {
+    status = "disabled";
+  };
+
+  pwmleds {
+    compatible = "pwm-leds";
+    green_pwm_led: green_pwm_led {
+      pwms = <&pwm3 3 PWM_MSEC(20) PWM_POLARITY_NORMAL>;
+    };
+  };
+  aliases {
+    pwm-led0 = &green_pwm_led;
+  };
+};
+
+&timers3 {
+    status = "okay";
+    st,prescaler = <64>;
+    /* User LD1 GREEN */
+    pwm3: pwm {
+        status = "okay";
+        pinctrl-0 = <&tim3_ch3_pb0>;
+        pinctrl-names = "default";
+    };
+};
+
 &flash0 {
   partitions {
     /* Set 48KB of storage at the beginning of bank2 in order to have 3 sectors smaller than 32K

zephyr/samples/profiles/b-ld/prj.conf

@@ -22,7 +22,6 @@ CONFIG_INIT_STACKS=y
 
 # BACnet Library
 CONFIG_BACNETSTACK=y
-CONFIG_BACNETSTACK_LOG_LEVEL=3
 # BACnet Library - shell
 CONFIG_BACNETSTACK_BACNET_SHELL=y
 CONFIG_BACNETSTACK_BACNET_BASIC_SHELL=y
@@ -139,3 +138,7 @@ CONFIG_SETTINGS_RUNTIME=y
 
 CONFIG_TEST_RANDOM_GENERATOR=y
 CONFIG_TIMER_RANDOM_GENERATOR=y
+
+# Lighting output controlling PWM LEDs
+CONFIG_PWM=y
+CONFIG_LED=y

zephyr/samples/profiles/b-ld/src/main.c

@@ -6,7 +6,11 @@
  * @copyright SPDX-License-Identifier: Apache-2.0
  */
 #include <zephyr/kernel.h>
+#include <zephyr/device.h>
+#include <zephyr/devicetree.h>
+#include <zephyr/drivers/led.h>
 #include <zephyr/random/random.h>
+#include <zephyr/sys/util.h>
 #include <stdint.h>
 #include <stdlib.h>
 /* BACnet Stack defines - first */
@@ -38,6 +42,11 @@ static const uint32_t Device_Instance = 260125;
 /* object instances */
 static const uint32_t Lighting_Instance = 1;
 
+#define LED_PWM_NODE_ID DT_COMPAT_GET_ANY_STATUS_OKAY(pwm_leds)
+const char *led_label[] = { DT_FOREACH_CHILD_SEP_VARGS(
+    LED_PWM_NODE_ID, DT_PROP_OR, (, ), label, NULL) };
+const int num_leds = ARRAY_SIZE(led_label);
+
 /**
  * @brief BACnet Lighting Output tracking value handler
  * @param object-instance [in] The object-instance number of the object
@@ -46,24 +55,46 @@ static const uint32_t Lighting_Instance = 1;
 void BACnet_Lighting_Output_Tracking_Value_Handler(
     uint32_t object_instance, float old_value, float value)
 {
-    uint16_t steps = 0;
+    uint8_t steps = 0;
+    int err;
+    uint8_t led;
+    const struct device *led_pwm;
 
     (void)old_value;
     if (object_instance != Lighting_Instance) {
         return;
     }
     /* Tracking value are 0.0 and 1.0-100.0 normalized */
     if (isgreaterequal(value, 1.0) && islessequal(value, 100.0)) {
-        steps = linear_interpolate(1.0, value, 100.0, 1, UINT16_MAX);
+        steps = (uint8_t)linear_interpolate(1.0, value, 100.0, 1, 100.0);
     } else if (isgreater(value, 100.0)) {
-        steps = UINT16_MAX;
+        steps = 100;
     } else {
         steps = 0;
     }
     LOG_INF(
         "Lighting Output[%lu]: value=%f step=%u/%u",
         (unsigned long)object_instance, (double)value, (unsigned)steps,
-        (unsigned)UINT16_MAX);
+        (unsigned)UINT8_MAX);
+    /* hardware control */
+    led_pwm = DEVICE_DT_GET(LED_PWM_NODE_ID);
+    if (!device_is_ready(led_pwm)) {
+        LOG_ERR("Device %s is not ready", led_pwm->name);
+        return;
+    }
+    if (!num_leds) {
+        LOG_ERR("No LEDs found for %s", led_pwm->name);
+        return;
+    }
+    if (object_instance > 0U) {
+        led = object_instance - 1U;
+    }
+    err = led_set_brightness(led_pwm, led, steps);
+    if (err < 0) {
+        LOG_ERR(
+            "Failed to set brightness of LED %u to %u: %d", (unsigned)led,
+            (unsigned)steps, err);
+    }
 }
 
 /**

zephyr/samples/profiles/b-ls/boards/nucleo_f429zi.overlay

@@ -4,6 +4,8 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+/delete-node/ &storage_partition;
+
 &flash0 {
   partitions {
     /* Set 48KB of storage at the beginning of bank2 in order to have 3 sectors smaller than 32K

zephyr/samples/profiles/b-ls/prj.conf

@@ -22,7 +22,6 @@ CONFIG_INIT_STACKS=y
 
 # BACnet Library
 CONFIG_BACNETSTACK=y
-CONFIG_BACNETSTACK_LOG_LEVEL=3
 # BACnet Library - shell
 CONFIG_BACNETSTACK_BACNET_SHELL=y
 CONFIG_BACNETSTACK_BACNET_BASIC_SHELL=y

zephyr/samples/profiles/b-sa/boards/nucleo_f429zi.overlay

@@ -4,6 +4,8 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+/delete-node/ &storage_partition;
+
 &flash0 {
   partitions {
     /* Set 48KB of storage at the beginning of bank2 in order to have 3 sectors smaller than 32K

zephyr/samples/profiles/b-sa/prj.conf

@@ -22,7 +22,6 @@ CONFIG_INIT_STACKS=y
 
 # BACnet Library
 CONFIG_BACNETSTACK=y
-CONFIG_BACNETSTACK_LOG_LEVEL=3
 # BACnet Library - shell
 CONFIG_BACNETSTACK_BACNET_SHELL=y
 CONFIG_BACNETSTACK_BACNET_BASIC_SHELL=y

zephyr/samples/profiles/b-ss/boards/nucleo_f429zi.overlay

@@ -4,6 +4,8 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+/delete-node/ &storage_partition;
+
 &flash0 {
     partitions {
         /* Set 48KB of storage at the beginning of bank2 in order to have 3 sectors smaller than 32K

zephyr/samples/profiles/b-ss/prj.conf

@@ -22,7 +22,6 @@ CONFIG_INIT_STACKS=y
 
 # BACnet Library
 CONFIG_BACNETSTACK=y
-CONFIG_BACNETSTACK_LOG_LEVEL=3
 # BACnet Library - shell
 CONFIG_BACNETSTACK_BACNET_SHELL=y
 CONFIG_BACNETSTACK_BACNET_BASIC_SHELL=y

zephyr/subsys/bacnet_shell/bacnet_shell_datetime.c

@@ -15,7 +15,7 @@
 #include "bacnet/bactext.h"
 #include "bacnet/datetime.h"
 
-static void cmd_date_time(const struct shell *shell, int argc, char **argv)
+static int cmd_date_time(const struct shell *shell, int argc, char **argv)
 {
     BACNET_DATE bdate = { 0 };
     BACNET_TIME btime = { 0 };
@@ -32,15 +32,17 @@ static void cmd_date_time(const struct shell *shell, int argc, char **argv)
                 datetime_timesync(&bdate, &btime, false);
             } else {
                 shell_print(shell, " date time format: YYYY/MM/DD HH:MM:SS.hh");
-                return;
+                return -EINVAL;
             }
         }
         datetime_local(&bdate, &btime, &utc_offset_minutes, &dst_active);
         datetime_date_to_ascii(&bdate, date_string, sizeof(date_string));
         datetime_time_to_ascii(&btime, time_string, sizeof(time_string));
         shell_print(shell, "%s %s", date_string, time_string);
+        return 0;
     } else {
         shell_help(shell);
+        return -EINVAL;
     }
 }