Fixed compile in BACnet/IP subsys using CONFIG_POSIX_API=y. (#47)

Author: skarg

zephyr/Kconfig

@@ -69,7 +69,6 @@ config BACDL_BIP
     bool "BACnet BIP datalink"
     select NETWORKING
     select NET_SOCKETS
-    select NET_SOCKETS_POSIX_NAMES
     select NET_UDP
     select NET_IPV4
     help
@@ -79,7 +78,6 @@ config BACDL_BIP6
     bool "BACnet BIP6 datalink"
     select NETWORKING
     select NET_SOCKETS
-    select NET_SOCKETS_POSIX_NAMES
     select NET_UDP
     select NET_IPV6
     help

zephyr/subsys/bacnet_datalink/bip-init.c

@@ -50,21 +50,6 @@ static char ipv4_addr_str[16] = { 0 };
 static char ipv4_addr_str[] = "";
 #endif
 
-/**
- * @brief Return a string representation of an IPv4 address
- * @param a - IPv4 address
- * @return Pointer to global string
- */
-char *inet_ntoa(struct in_addr *a)
-{
-    if (IS_ENABLED(CONFIG_BACNETSTACK_LOG_LEVEL)) {
-        snprintf(
-            ipv4_addr_str, sizeof(ipv4_addr_str), "%d.%d.%d.%d", a->s4_addr[0],
-            a->s4_addr[1], a->s4_addr[2], a->s4_addr[3]);
-    }
-
-    return &ipv4_addr_str[0];
-}
 
 /**
  * @brief Print the IPv4 address with debug info
@@ -78,7 +63,8 @@ static void debug_print_ipv4(
     const unsigned int count)
 {
     LOG_DBG(
-        "%s %s:%hu (%u bytes)", str, inet_ntoa((struct in_addr *)&addr),
+        "%s %s:%hu (%u bytes)", str,
+        net_addr_ntop(AF_INET, addr, ipv4_addr_str, sizeof(ipv4_addr_str)),
         ntohs(port), count);
 }
 

zephyr/subsys/bacnet_datalink/bip6-init.c

@@ -51,31 +51,11 @@ static char ipv6_addr_str[] = "";
 static char *inet6_ntoa(struct in6_addr *a)
 {
 #if CONFIG_BACNETSTACK_LOG_LEVEL
-    uint8_t x = 0;
-    uint8_t d = 0;
-    uint8_t non_zero_count = 0;
-
     /* Avoid overwhelming the logging system */
     while (log_buffered_cnt()) {
         k_sleep(K_MSEC(1));
     }
-
-    for (x = 0; x < IP6_ADDRESS_MAX; x += 2) {
-        if (a->s6_addr[x] | a->s6_addr[x + 1]) {
-            non_zero_count++;
-            d += snprintf(
-                &ipv6_addr_str[d], sizeof(ipv6_addr_str), "%02X%02X",
-                a->s6_addr[x], a->s6_addr[x + 1]);
-        }
-
-        if (x < 14) {
-            d += snprintf(&ipv6_addr_str[d], sizeof(ipv6_addr_str), ":");
-        }
-    }
-
-    if (!non_zero_count) {
-        snprintf(&ipv6_addr_str[0], sizeof(ipv6_addr_str), "undefined");
-    }
+    net_addr_ntop(AF_INET6, a, &ipv6_addr_str[0], sizeof(ipv6_addr_str));
 #endif
     return &ipv6_addr_str[0];
 }