chore: Move test to another file to ensure setting the TAGS env correctly (#181)

* Move test to another file to ensure setting the TAGS env correctly

* Extract test setup

Author: sawasawasawa

lib/resolveStepDefinition.test.js

@@ -1,37 +1,7 @@
 /* eslint-disable global-require */
 /* global jest */
-const fs = require("fs");
-const { Parser } = require("gherkin");
+const { readAndParseFeatureFile } = require("./setup");
 const { createTestsFromFeature } = require("./createTestsFromFeature");
-const {
-  defineParameterType,
-  defineStep,
-  when,
-  then,
-  given,
-  and,
-  but
-} = require("./resolveStepDefinition");
-
-window.defineParameterType = defineParameterType;
-window.when = when;
-window.then = then;
-window.given = given;
-window.and = and;
-window.but = but;
-window.defineStep = defineStep;
-window.cy = {
-  log: jest.fn()
-};
-
-window.Cypress = {
-  env: jest.fn()
-};
-
-const readAndParseFeatureFile = featureFilePath => {
-  const spec = fs.readFileSync(featureFilePath);
-  return new Parser().parse(spec.toString());
-};
 
 describe("Scenario Outline", () => {
   require("../cypress/support/step_definitions/scenario_outline_integer");
@@ -99,41 +69,7 @@ describe("Tags implementation", () => {
   );
 });
 
-describe("Tags inheritance", () => {
-  window.Cypress = {
-    env: () => "@inherited-tag and @own-tag"
-  };
-  require("../cypress/support/step_definitions/tags_implementation_with_env_set");
-
-  createTestsFromFeature(
-    readAndParseFeatureFile("./cypress/integration/TagsInheritance.feature")
-  );
-});
-
-// TODO we need to take a look why these do not work properly, but as long as they run correctly with cypress run we can skip for now.
-describe.skip("Tags with env TAGS set", () => {
-  window.Cypress = {
-    env: () => "@test-tag and not @ignore-tag"
-  };
-  require("../cypress/support/step_definitions/tags_implementation_with_env_set");
-
-  createTestsFromFeature(
-    readAndParseFeatureFile(
-      "./cypress/integration/TagsImplementationWithEnvSet.feature"
-    )
-  );
-
-  createTestsFromFeature(
-    readAndParseFeatureFile(
-      "./cypress/integration/TagsImplementationWithEnvSetScenarioLevel.feature"
-    )
-  );
-});
-
 describe("Smart tagging", () => {
-  window.Cypress = {
-    env: () => ""
-  };
   require("../cypress/support/step_definitions/smart_tagging");
 
   createTestsFromFeature(
@@ -156,3 +92,22 @@ describe("defineStep", () => {
     readAndParseFeatureFile("./cypress/integration/DefineStep.feature")
   );
 });
+
+describe("Tags with env TAGS set", () => {
+  window.Cypress = {
+    env: () => "@test-tag and not @ignore-tag"
+  };
+  require("../cypress/support/step_definitions/tags_implementation_with_env_set");
+
+  createTestsFromFeature(
+    readAndParseFeatureFile(
+      "./cypress/integration/TagsImplementationWithEnvSet.feature"
+    )
+  );
+
+  createTestsFromFeature(
+    readAndParseFeatureFile(
+      "./cypress/integration/TagsImplementationWithEnvSetScenarioLevel.feature"
+    )
+  );
+});

lib/setup.js

@@ -0,0 +1,37 @@
+/* eslint-disable global-require */
+/* global jest */
+const fs = require("fs");
+const { Parser } = require("gherkin");
+const {
+  defineParameterType,
+  defineStep,
+  when,
+  then,
+  given,
+  and,
+  but
+} = require("./resolveStepDefinition");
+
+window.defineParameterType = defineParameterType;
+window.when = when;
+window.then = then;
+window.given = given;
+window.and = and;
+window.but = but;
+window.defineStep = defineStep;
+window.cy = {
+  log: jest.fn()
+};
+
+window.Cypress = {
+  env: jest.fn()
+};
+
+const readAndParseFeatureFile = featureFilePath => {
+  const spec = fs.readFileSync(featureFilePath);
+  return new Parser().parse(spec.toString());
+};
+
+module.exports = {
+  readAndParseFeatureFile
+};

lib/tagsInheritance.test.js

@@ -0,0 +1,16 @@
+/* eslint-disable global-require */
+/* global jest */
+const { readAndParseFeatureFile } = require("./setup");
+const { createTestsFromFeature } = require("./createTestsFromFeature");
+
+describe("Tags inheritance", () => {
+  window.Cypress = {
+    env: () => "@inherited-tag and @own-tag"
+  };
+
+  require("../cypress/support/step_definitions/tags_implementation_with_env_set");
+
+  createTestsFromFeature(
+    readAndParseFeatureFile("./cypress/integration/TagsInheritance.feature")
+  );
+});